Skip to content
  1. Aug 13, 2021
    • Squirrel's avatar
      depend-o-pocalipse (#9450) · 7e9b8d27
      Squirrel authored
      Remove unneeded dependencies and dev-dependencies.
      Made self_destruct test not dependent on wasm bin size.  
      Updated code related to deprecated warning on tracing-subscriber `scope()` 
      ( See https://github.com/tokio-rs/tracing/issues/1429 )
      7e9b8d27
  2. Aug 11, 2021
  3. Aug 09, 2021
  4. Aug 07, 2021
    • Gavin Wood's avatar
      Remove Filter and use Contains instead (#9514) · bdda3ed6
      Gavin Wood authored
      
      
      * Remove Filter and use Contains instead
      
      * Fixes
      
      * Formatting
      
      * Update docs/Upgrading-2.0-to-3.0.md
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Typo
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      bdda3ed6
    • Shawn Tabrizi's avatar
      FRAME Weights with Storage Metadata (#9471) · 0489c176
      Shawn Tabrizi authored
      
      
      * weights with metadata
      
      * fix
      
      * fix contract test
      
      * skip metadata tag
      
      * special handling for `frame_system`
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * add skip metadata to contracts
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix contract test
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bounties --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bounties/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * expose component information
      
      * fix test generation
      
      * refactor list benchmarks
      
      * move component selection out of runtime
      
      * add benchmark verification
      
      * missing feature
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bounties --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bounties/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * add internal repeats
      
      * update weights with internal repeats
      
      * fix warning
      
      * return error with pov
      
      * try without tracking
      
      * Revert "return error with pov"
      
      This reverts commit 44c36cbbd3c6818f36f377e3e291f1df156e40f7.
      
      * Revert "try without tracking"
      
      This reverts commit f401c44aebff2232389d8d307b20924891e5d77d.
      
      * Revert "Revert "try without tracking""
      
      This reverts commit 4b4e05929802ad3e8154e107359447634e5fb21b.
      
      * state without tracking
      
      * fix build
      
      * temp test
      
      * split db and timing benchmarks
      
      * extend db results?
      
      * default repeat is internal
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix warning
      
      * bump linked hash map
      
      * use linked hash map for storage tracker
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * remove conflicting short command
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * missed one linked hashmap
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bounties --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bounties/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bounties --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bounties/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * new weights with latest changes
      
      * Update frame/benchmarking/src/utils.rs
      
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      0489c176
  5. Aug 01, 2021
    • Shawn Tabrizi's avatar
      Refactor Benchmarks for Less Wasm Memory Usage (#9373) · fa8c6274
      Shawn Tabrizi authored
      
      
      * extract repeat out of benchmark
      
      * remove r
      
      * unused
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * use linked map to keep order
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Delete pallet_balances.rs
      
      * Delete out
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * steps and repeat to tuple (current_*, total_*)
      
      * idea for list command
      
      * fmt
      
      * use benchmark list in cli
      
      * handle steps in cli
      
      * move log update to cli
      
      * fmt
      
      * remove old todo
      
      * line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * benchmark metadata function
      
      * don't need this warm up
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix warnings
      
      * fix node-template
      
      * fix
      
      * fmt
      
      * line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * improve docs
      
      * improve cli
      
      * fix format
      
      * fix bug?
      
      * Revert "fix bug?"
      
      This reverts commit 8051bf1bf9bae862ff28dfff386e7045cd3f045e.
      
      * skip frame-metadata
      
      * extract repeat out of benchmark
      
      * remove r
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * use linked map to keep order
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Delete pallet_balances.rs
      
      * Delete out
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * steps and repeat to tuple (current_*, total_*)
      
      * idea for list command
      
      * fmt
      
      * use benchmark list in cli
      
      * handle steps in cli
      
      * move log update to cli
      
      * remove old todo
      
      * line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * benchmark metadata function
      
      * don't need this warm up
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix warnings
      
      * fix node-template
      
      * fix
      
      * fmt
      
      * line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * improve docs
      
      * improve cli
      
      * fix format
      
      * fix bug?
      
      * Revert "fix bug?"
      
      This reverts commit 8051bf1bf9bae862ff28dfff386e7045cd3f045e.
      
      * skip frame-metadata
      
      * Update .gitlab-ci.yml
      
      * fix import
      
      * Update .gitlab-ci.yml
      
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      fa8c6274
  6. Jul 29, 2021
  7. Jul 28, 2021
  8. Jul 27, 2021
  9. Jul 26, 2021
  10. Jul 24, 2021
  11. Jul 23, 2021
  12. Jul 22, 2021
  13. Jul 21, 2021
    • Bastian Köcher's avatar
      Run cargo fmt on the whole code base (#9394) · 7b56ab15
      Bastian Köcher authored
      * Run cargo fmt on the whole code base
      
      * Second run
      
      * Add CI check
      
      * Fix compilation
      
      * More unnecessary braces
      
      * Handle weights
      
      * Use --all
      
      * Use correct attributes...
      
      * Fix UI tests
      
      * AHHHHHHHHH
      
      * 🤦
      
      * Docs
      
      * Fix compilation
      
      * 🤷
      
      * Please stop
      
      * 🤦
      
       x 2
      
      * More
      
      * make rustfmt.toml consistent with polkadot
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      7b56ab15
  14. Jul 16, 2021
  15. Jul 13, 2021
  16. Jul 12, 2021
  17. Jul 11, 2021
    • Benjamin Kampmann's avatar
      Attempting to fix publishing (#9140) · c78c2892
      Benjamin Kampmann authored
      
      
      * mark template and utils as non-publish
      
      * switch to development version for testing
      
      * activate unleash check
      
      * maybe if I disable all rules...
      
      * Fix isolated compilation of `max-encoded-len-derive` with `syn`
      
      error[E0369]: binary operation `==` cannot be applied to type `syn::Path`
        --> src/lib.rs:88:29
         |
      88 |             .filter(|attr| attr.path == parse_quote!(max_encoded_len_crate))
         |                            --------- ^^ ----------------------------------- _
         |                            |
         |                            syn::Path
      
      error: aborting due to previous error
      
      For more information about this error, try `rustc --explain E0369`.
      Error: could not compile `max-encoded-len-derive`
      
      * WIP: bump changes crates since v3 tag to next breaking
      
      cargo unleash version bump-breaking --changed-since v3.0.0
      cargo unleash version set-pre dev --changed-since v3.0.0
      
      FIXME: Don't modify crates that are not yet released, e.g.
      `max-encoded-len-derive`
      
      * Update lockfile
      
      * WIP: Bump sp-transaction-pool as well
      
      * WIP: Bump sp-offchain as well
      
      * WIP: Bump frame-system-rpc-runtime-api as well
      
      * WIP: Bump sp-authority-discovery as well
      
      * Manually deactivate dev-deps before `cargo unleash check`
      
      Otherwise we run into `Cycle detected` error.
      
      * Bump sp-consensus-slots
      
      * Add missing Cargo.lock change
      
      * Bump sp-consensus-vrf as well
      
      * Bump sp-keyring as well
      
      * Bump sp-consensus-pow as well
      
      * Try to speed up the `unleash-check` job
      
      Previously, the job took 106 minutes - let's see if explicitly
      specifying a `CARGO_TARGET_DIR` will help
      
      * fixup: Ensure the temp target dir exists for unleash check
      
      * Bump pallet-transaction-payment-rpc-runtime-api as well
      
      Needed for Polkadot
      
      * Bump pallet-transaction-payment-rpc as well
      
      Needed for Polkadot
      
      * Try updating crates after patching in the Polkadot CI job
      
      * Use another approach to update patched Substrate crates
      
      * Try to update all sp-core versions in Polkadot CI job
      
      * Simplify sp-core version checking
      
      * Apply another shellcheck lint
      
      * Just do the simplest thing I guess
      
      * Welp don't do --offline then
      
      * Clean up `unleash-check` job triggers
      
      Co-authored-by: default avatarDenis Pisarev <[email protected]>
      
      * Fix a note in unleash-check cache step
      
      * Add a note about temporary optimization in cargo-unleash
      
      * Pin a newer version of cargo-unleash
      
      Co-authored-by: default avatarIgor Matuszewski <[email protected]>
      Co-authored-by: default avatarDenis Pisarev <[email protected]>
      c78c2892
  18. Jul 09, 2021
    • Kian Paimani's avatar
      Make election benchmarks more *memory-aware* (#9286) · 3850a433
      Kian Paimani authored
      
      
      * Make benchmarks a bit better with mem
      
      * Make election benchmarks more *memory-aware*
      
      * Fix a few errors
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Manually fix the weights
      
      * Update lock file
      
      * remove dupe
      
      * Fix tests
      
      * cargo update pwasm
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      3850a433
  19. Jul 07, 2021
  20. Jul 06, 2021
  21. Jul 05, 2021
  22. Jun 29, 2021
  23. Jun 28, 2021
    • Shawn Tabrizi's avatar
      Improve Staking Limits (#9193) · 5cd04820
      Shawn Tabrizi authored
      * only allow `chill_other` near threshold.
      
      * improve test
      
      * skip limit check for existing validators / nominators
      
      * add `ChillThreshold`
      
      * rename to `set` for consistent api
      
      * more tests
      
      * fix some line width
      5cd04820
  24. Jun 24, 2021
  25. Jun 21, 2021
    • Shawn Tabrizi's avatar
      New Weights for All Pallets (#9148) · e5831c3d
      Shawn Tabrizi authored
      * Create run_benchmarks.sh
      
      * Update run_benchmarks.sh
      
      * new weights
      
      * Delete run_benchmarks.sh
      
      * wrong folder
      
      * remove grandpa weight
      
      * Update weights.rs
      e5831c3d
  26. Jun 16, 2021
  27. Jun 15, 2021
  28. Jun 14, 2021
  29. Jun 12, 2021
  30. Jun 09, 2021
    • Keith Yeung's avatar
      Use pallet names to name enum variants (#8990) · 828d1d74
      Keith Yeung authored
      * Remove unused event_metadata variable
      
      * Eliminate mod_name and use pallet names to name enum variants
      
      * Rename field name `pallet` to `path`
      
      * Use only the pallet name to generate variant names
      
      * Use new naming scheme for Event enum in sudo pallet tests
      
      * Use new naming scheme for Event enum in offences pallet tests
      
      * Use new naming scheme for Event enum in contracts pallet tests
      
      * Use new naming scheme for Event enum in collective pallet tests
      
      * Use new naming scheme for Event enum in bounties pallet tests
      
      * Use new naming scheme for Event enum in balances pallet tests
      
      * Use new naming scheme for Event enum in assets pallet tests
      
      * Use new naming scheme for Event enum in frame support tests
      
      * Use new naming scheme for Event enum in tips pallet tests
      
      * Use new naming scheme for Event enum in transaction payment pallet tests
      
      * Use new naming scheme for GenesisConfig fields in example pallet tests
      
      * Use new naming scheme for GenesisConfig fields in elections pallet tests
      
      * Use new naming scheme for Event enum in election provider multi-phase pallet tests
      
      * Use new naming scheme for Event enum in elections phragmen pallet tests
      
      * Use new naming scheme for GenesisConfig fields in chain spec
      
      * Use new naming scheme for Event enum in staking pallet mock
      
      * Use new naming scheme for GenesisConfig fields in node-template chain spec
      
      * Use new naming scheme for GenesisConfig fields in node-testing chain spec
      
      * Use new naming scheme for Event enum in node executor tests
      
      * Use new naming scheme for GenesisConfig fields in transaction storage pallet mock
      
      * Refactor match conditions
      828d1d74
  31. Jun 08, 2021
    • Shawn Tabrizi's avatar
      Emit `Bonded` event when rebonding (#9040) · 28bfba14
      Shawn Tabrizi authored
      
      
      * Emit `Bonded` event when rebonding
      
      * fix borrow checker
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      28bfba14
  32. Jun 07, 2021
  33. Jun 04, 2021
    • Xiliang Chen's avatar
      Named reserve (#7778) · 223529e4
      Xiliang Chen authored
      
      
      * add NamedReservableCurrency
      
      * move currency related trait and types into a new file
      
      * implement NamedReservableCurrency
      
      * remove empty reserves
      
      * Update frame/support/src/traits.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * fix build
      
      * bump year
      
      * add MaxReserves
      
      * repatriate_reserved_named should put reserved fund into named reserved
      
      * add tests
      
      * add some docs
      
      * fix warning
      
      * Update lib.rs
      
      * fix test
      
      * fix test
      
      * fix
      
      * fix
      
      * triggier CI
      
      * Move NamedReservableCurrency.
      
      * Use strongly bounded vec for reserves.
      
      * Fix test.
      
      * remove duplicated file
      
      * trigger CI
      
      * Make `ReserveIdentifier` assosicated type
      
      * add helpers
      
      * make ReserveIdentifier assosicated type
      
      * fix
      
      * update
      
      * trigger CI
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * trigger CI
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarShaun Wang <[email protected]>
      223529e4