Skip to content
Snippets Groups Projects
  1. Jun 02, 2023
  2. Jun 01, 2023
  3. May 31, 2023
  4. May 30, 2023
    • Michal Kucharczyk's avatar
      app_crypto: macro improvements (#14263) · e7e13116
      Michal Kucharczyk authored
      * app_crypto: macro improvements
      
      During `app_crypto`  macro expansion the `cfg` feature gate was injected
        into the macro client crate. This resulted in compilation error if
      `serde` or `std` was not defined in client crate. This PR fixes this
      problem.
      
      For reference, the error was:
      
      ```
        error: cannot find macro `format` in this scope
          --> /home/miszka/parity/10-genesis-config/substrate-2/primitives/consensus/aura/src/lib.rs:32:3
           |
        32 |         app_crypto!(sr25519, AURA);
           |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
           |
      ...
      
        error[E0433]: failed to resolve: use of undeclared type `String`
          -->
      /home/miszka/parity/10-genesis-config/substrate-2/primitives/consensus/aura/src/lib.rs:32:3
           |
        32 |         app_crypto!(sr25519, AURA);
           |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared type `String`
      ```
      
      * app_crypto: cleanup
      e7e13116
    • Kian Paimani's avatar
      Default Pallet Config Trait / derive_impl (#13454) · 263a5d6c
      Kian Paimani authored
      
      * first draft, probably won't work
      
      * first draft, probably won't work
      
      * good progress..
      
      * good milestone, still a lot to do.
      
      * EVERYTHING WORKS
      
      * Update frame/support/procedural/src/derive_impl.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      
      * Update frame/support/procedural/src/derive_impl.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      
      * clean up + cargo fmt
      
      * import tokens WIP
      
      * export_tokens working with impl Trait
      
      * WIP / notes
      
      * use macro_magic 0.2.0's export_tokens to access foreign items
      
      * token importing working properly using macro_magic 0.2.5
      
      * combine_impls almost working
      
      * successfully get foreign path via macro_magic 0.2.6
      
      * combine_impls using implementing_type generics
      
      * working + clean up
      
      * more clean up
      
      * decrease rightwards drift and add docs to combine_impls
      
      * add support for macros to impl_item_ident in case we hit that
      
      * add docs for impl_item_ident method
      
      * fix no_std issues
      
      * re-export of macro_magic working in pallets :tada:
      
      * clean up + fully resolve no_std issue with macro_magic with v0.2.11
      
      * remove trait item code for different trait item types since this
      is now handled directly by combine_impls
      
      * clean up
      
      * remove dev comments
      
      * only generate default trait if #[pallet::default_trait] is attached
      
      * authorship and most other pallets now compiling
      
      * compiling :tada:
      
      * add check for more than two pallet attributes on Config trait
      
      * remove unused import in nomination-pool
      
      * clean up debug code
      
      * upgrade to macro_magic v0.2.12
      
      * add neater #[register_default_config(SomeIdent)] macro
      
      * really just a thin wrapper around #[export_tokens]
      
      * upgrade to macro_magic 0.3.1
      
      * rewrite parsing to be compatible with syn 2.x, compiling :tada:
      
      
      
      * remove unused keywords
      
      * macro stubs for the new pallet:: macros, preliminary docs
      
      * upgrade to macro_magic v0.3.2
      
      * rename register_default_config => register_default_impl
      
      * bump to macro_magic v0.3.3
      
      * custom disambiguation_path working as 2nd arg to derive_impl
      
      * overhaul docs
      
      * fixes, ident-style paths shortcut working
      
      * remove ident-style shortcut because it makes testing difficult
      
      * add passing UI tests for derive_impl
      
      * switch to `ForeignPath as DisambiguationPath` syntax + update docs
      
      * add UI test for bad foreign path
      
      * add UI test for bad disambiguation path
      
      * add UI test for missing disambiguation path
      
      * add UI test for attached to non impl
      
      * fix derive_impl_attr_args_parsing test
      
      * move tests to bottom
      
      * fix nightly issue
      
      * add doc notes on importing/re-exporting
      
      * remove explicit use of macro_magic::use_attr
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * use explicit macro_magic::use_attr
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * remove unneeded {}
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * remove unneeded collect
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * add docs for TestDefaultConfig
      
      * remove unneeded `#[export_tokens]` on `DefaultConfig`
      
      * add docs for auto-generated `DefaultConfig`
      
      * no need to clone
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * clean up combine_impls + compiling again
      
      * remove unused dependency
      
      * simplify struct definition
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * fix register_default_impl docs
      
      * reduce rightward drift / refactor
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * fix derive_impl after keith's changes
      
      * simplify disambiguation_path calculation
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * compiling again
      
      * simplify parsing of trait item
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * rename preludes => prelude
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * fix other places where we used preludes instead of prelude
      
      * fix indents
      
      * simplify PalletAttr parsing
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * go back to having no_default and constant as keywords
      
      * make it more clear that disambiguation_path is optional
      
      * make default_trait_items just a Vec instead of Option<Vec>
      
      * rename foreign_path => default_impl_path within substrate
      
      * fix docs
      
      * Change {} to ;
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * highlight full end-to-end example with link
      
      * add pallet-default-config-example, start by copying dev mode code
      
      * update dev-mode specific docs
      
      * use Person and Points instead of Dummy and Bar
      
      * add docs to example pallet
      
      * revert changes to pallets other than the default config example
      
      * fix outdated references to basic example pallet
      
      * re-order docs to be a bit more clear
      
      * better errors for extra attributes
      
      * add UI tests for duplicate/extra attributes on trait items
      
      * change `#[pallet::default_config]` to option on `#[pallet::config()]`
      
      * update UI tests
      * add UI test covering missing `#[pallet::config(with_default)]` when
        `#[pallet::no_default]` is used
      
      * add note about new optional conventions
      
      * improve docs about `DefaultConfig` and link to these from a few places
      
      * fix doc comment
      
      * fix old comment referencing `pallet::default_config`
      
      * use u32 instead of u64 for block number
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * use () instead of u32 for `AccountData`
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * use ConstU32<10> for BlockHashCount instead of ConstU64<10>
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * people are not dummies
      
      Co-authored-by: default avatarLiam Aharon <liam.aharon@hotmail.com>
      
      * fix wording
      
      Co-authored-by: default avatarJust van Stam <vstam1@users.noreply.github.com>
      
      * Person => People and compiling again
      
      * add docs for `prelude` module in frame_system
      
      * update Cargo.lock
      
      * cleaner example
      
      * tweaks
      
      * update docs more
      
      * update docs more
      
      * update docs more
      
      * update docs more
      
      * fix ui tests
      
      * err
      
      * Update frame/support/test/tests/pallet_ui.rs
      
      * update ui tests
      
      ---------
      
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarSam Johnson <sam@durosoft.com>
      Co-authored-by: parity-processbot <>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      Co-authored-by: default avatarLiam Aharon <liam.aharon@hotmail.com>
      Co-authored-by: default avatarJust van Stam <vstam1@users.noreply.github.com>
      263a5d6c
  5. May 29, 2023
  6. May 28, 2023
    • Bastian Köcher's avatar
      wasm-builder: Enforce `runtime_version` wasm section (#14228) · 6947b334
      Bastian Köcher authored
      * wasm-builder: Enforce `runtime_version` wasm section
      
      This pr changes the `wasm-builder` to enforce the `runtime_version` wasm section. This wasm section
      is being created by the `sp_version::runtime_version` attribute macro. This attribute macro now
      exists since quite some time and `runtime_version` also is the only way for parachains to support
      reading the `RuntimeVersion` from the runtime.
      
      \# Disabling the check
      
      By default the `WasmBuilder` will now check for this wasm section and if not found, exit with an
      error. However, there are situations where you may want to disable this check (like for tests). In
      this case there exists the `disable_runtime_version_section_check` function.
      
      ```
      WasmBuilder::new()
         ...
         ...
         ...
         .disable_runtime_version_section_check()
         .build()
      ```
      
      By using this method you get back the old behavior.
      
      * Review comment
      
      * Fix
      
      * Fix issue with `enum-as-inner`
      6947b334
    • dependabot[bot]'s avatar
      Bump lru from 0.8.1 to 0.10.0 (#14211) · 54022123
      dependabot[bot] authored
      
      Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.8.1 to 0.10.0.
      - [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/jeromefroe/lru-rs/compare/0.8.1...0.10.0)
      
      ---
      updated-dependencies:
      - dependency-name: lru
        dependency-type: direct:production
        update-type: version-update:semver-minor
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      54022123
  7. May 27, 2023
  8. May 26, 2023