Skip to content
  1. Nov 09, 2020
  3. Nov 08, 2020
  5. Nov 06, 2020
    • Sergey Pepyakin's avatar
      Implement HRMP (#1900) · c96f8cfc
      Sergey Pepyakin authored 
      

* HRMP: Update the impl guide

* HRMP: Incorporate the channel notifications into the guide

* HRMP: Renaming in the impl guide

* HRMP: Constrain the maximum number of HRMP messages per candidate

This commit addresses the HRMP part of https://github.com/paritytech/polkadot/issues/1869

* XCM: Introduce HRMP related message types

* HRMP: Data structures and plumbing

* HRMP: Configuration

* HRMP: Data layout

* HRMP: Acceptance & Enactment

* HRMP: Test base logic

* Update adder collator

* HRMP: Runtime API for accessing inbound messages

Also, removing some redundant fully-qualified names.

* HRMP: Add diagnostic logging in acceptance criteria

* HRMP: Additional tests

* Self-review fixes

* save test refactorings for the next time

* Missed a return statement.

* a formatting blip

* Add missing logic for appending HRMP digests

* Remove the channel contents vectors which became empty

* Tighten HRMP channel digests invariants.

* Apply suggestions from code review

Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>

* Remove a note about sorting for channel id

* Add missing rustdocs to the configuration

* Clarify and update the invariant for HrmpChannelDigests

* Make the onboarding invariant less sloppy

Namely, introduce `Paras::is_valid_para` (in fact, it already is present
in the implementation) and hook up the invariant to that.

Note that this says "within a session" because I don't want to make it
super strict on the session boundary. The logic on the session boundary
should be extremely careful.

* Make `CandidateCheckContext` use T::BlockNumber for hrmp_watermark

Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      c96f8cfc
    • Bastian Köcher's avatar
      Distribute a PoV after seconding it (#1924) · 8a2911b8
      Bastian Köcher authored 
      We need to distribute the PoV after we have seconded it. Other nodes
that will receive our `Secondded` statement and want to validate the
candidate another time will request this PoV from us.
      8a2911b8
  7. Nov 05, 2020
  9. Nov 04, 2020
  11. Nov 03, 2020
    • s3krit's avatar
      remove stale migrations (#1914) · 033f208d
      s3krit authored
      033f208d
    • Bastian Köcher's avatar
      Moare fixes for parachains (#1911) · 04da99de
      Bastian Köcher authored 
      

* Moare fixes for parachains

- Sending data to a job should always contain a relay parent. Done this
for the provisioner
- Fixed the `select_availability_bitfields` function. It was assuming we
have one core per validator, while we only have one core per parachain.
- Drive by async "rewrite" in proposer

* Make tests compile

* Update primitives/src/v1.rs

Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>

Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      04da99de
    • Shawn Tabrizi's avatar
      Update Proxy Filters (#1890) · 04eba097
      Shawn Tabrizi authored 
      * Update proxy filters

* add session
      04eba097
    • Shawn Tabrizi's avatar
      New Weights v0.8.26 (#1889) · 33daa45b
      Shawn Tabrizi authored 
      

* new polkadot weights

* kusama weights

* update for westend

* cargo update -p sp-io

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_session --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_session --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/

* cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_session --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/

Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      33daa45b
    • Bastian Köcher's avatar
      Parachain improvements (#1905) · 002e1141
      Bastian Köcher authored 
      

* Parachain improvements

- Set the parachains configuration in Rococo genesis
- Don't stop the overseer when a subsystem job is stopped
- Several small code changes

* Remove unused functionality

* Return error from the runtime instead of printing it

* Apply suggestions from code review

Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>

* Update primitives/src/v1.rs

Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>

* Update primitives/src/v1.rs

Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>

* Fix test

* Revert "Update primitives/src/v1.rs"

This reverts commit 11fce2785acd1de481ca57815b8e18400f09fd52.

* Revert "Update primitives/src/v1.rs"

This reverts commit d6439fed4f954360c89fb1e12b73954902c76a41.

* Revert "Return error from the runtime instead of printing it"

This reverts commit cb4b5c0830ac516a6d54b2c24197e9354f2b98cb.

* Revert "Fix test"

This reverts commit 0c5fa1b5566d4cd3c55a55d485e707165ce7a59e.

* Update runtime/parachains/src/runtime_api_impl/v1.rs

Co-authored-by: default avatarSergei Shulepov <[email protected]>

Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
Co-authored-by: default avatarSergei Shulepov <[email protected]>
      002e1141
    • Peter Goodspeed-Niklaus's avatar
      add native logging to check_upward_messages (#1906) · 45c9aefd
      Peter Goodspeed-Niklaus authored 
      

* add native logging to check_upward_messages

This doesn't affect the WASM builds, but ensures that native versions
(such as are used for testing) emit diagnostics anytime the
check_upward_messages function exits, which should reduce the pain
of debugging when something goes wrong.

* Apply suggestions from code review

Co-authored-by: default avatarSergei Shulepov <[email protected]>

* verb tense

Co-authored-by: default avatarSergei Shulepov <[email protected]>
      45c9aefd
  13. Nov 02, 2020
  15. Nov 01, 2020
  17. Oct 31, 2020
    • asynchronous rob's avatar
      fix service build: enable notifications protocol only under real overseer (#1894) · ad9e1fdf
      asynchronous rob authored 
      

Co-authored-by: default avatarRobert Habermeier <[email protected]>
      ad9e1fdf
    • Bastian Köcher's avatar
      Adds test parachain adder collator (#1864) · f82de7b9
      Bastian Köcher authored 
      

* start working on building the real overseer

Unfortunately, this fails to compile right now due to an upstream
failure to compile which is probably brought on by a recent upgrade
to rustc v1.47.

* fill in AllSubsystems internal constructors

* replace fn make_metrics with Metrics::attempt_to_register

* update to account for #1740

* remove Metrics::register, rename Metrics::attempt_to_register

* add 'static bounds to real_overseer type params

* pass authority_discovery and network_service to real_overseer

It's not straightforwardly obvious that this is the best way to handle
the case when there is no authority discovery service, but it seems
to be the best option available at the moment.

* select a proper database configuration for the availability store db

* use subdirectory for av-store database path

* apply Basti's patch which avoids needing to parameterize everything on Block

* simplify path extraction

* get all tests to compile

* Fix Prometheus double-registry error

for debugging purposes, added this to node/subsystem-util/src/lib.rs:472-476:

```rust
Some(registry) => Self::try_register(registry).map_err(|err| {
	eprintln!("PrometheusError calling {}::register: {:?}", std::any::type_name::<Self>(), err);
	err
}),
```

That pointed out where the registration was failing, which led to
this fix. The test still doesn't pass, but it now fails in a new
and different way!

* authorities must have authority discovery, but not necessarily overseer handlers

* fix broken SpawnedSubsystem impls

detailed logging determined that using the `Box::new` style of
future generation, the `self.run` method was never being called,
leading to dropped receivers / closed senders for those subsystems,
causing the overseer to shut down immediately.

This is not the final fix needed to get things working properly,
but it's a good start.

* use prometheus properly

Prometheus lets us register simple counters, which aren't very
interesting. It also allows us to register CounterVecs, which are.
With a CounterVec, you can provide a set of labels, which can
later be used to filter the counts.

We were using them wrong, though. This pattern was repeated in a
variety of places in the code:

```rust
// panics with an cardinality mismatch
let my_counter = register(CounterVec::new(opts, &["succeeded", "failed"])?, registry)?;
my_counter.with_label_values(&["succeeded"]).inc()
```

The problem is that the labels provided in the constructor are not
the set of legal values which can be annotated, but a set of individual
label names which can have individual, arbitrary values.

This commit fixes that.

* get av-store subsystem to actually run properly and not die on first signal

* typo fix: incomming -> incoming

* don't disable authority discovery in test nodes

* Fix rococo-v1 missing session keys

* Update node/core/av-store/Cargo.toml

* try dummying out av-store on non-full-nodes

* overseer and subsystems are required only for full nodes

* Reduce the amount of warnings on browser target

* Fix two more warnings

* InclusionInherent should actually have an Inherent module on rococo

* Ancestry: don't return genesis' parent hash

* Update Cargo.lock

* fix broken test

* update test script: specify chainspec as script argument

* Apply suggestions from code review

Co-authored-by: default avatarBastian Köcher <[email protected]>

* Update node/service/src/lib.rs

Co-authored-by: default avatarBastian Köcher <[email protected]>

* node/service/src/lib: Return error via ? operator

* post-merge blues

* add is_collator flag

* prevent occasional av-store test panic

* simplify fix; expand application

* run authority_discovery in Role::Discover when collating

* distinguish between proposer closed channel errors

* add IsCollator enum, remove is_collator CLI flag

* improve formatting

* remove nop loop

* Fix some stuff

* Adds test parachain adder collator

* Add sudo to Rococo, change session length to 30 seconds and some renaming

* Update to the latest changes on master

* Some fixes

* Fix compilation

* Update parachain/test-parachains/adder/collator/src/lib.rs

Co-authored-by: default avatarSergei Shulepov <[email protected]>

* Review comments

* Downgrade transaction version

* Fixes

* MOARE

* Register notification protocols

* utils: remove unused error

* av-store: more resilient to some errors

* address review nits

* address more review nits

Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
Co-authored-by: default avatarAndronik Ordian <[email protected]>
Co-authored-by: default avatarFedor Sakharov <[email protected]>
Co-authored-by: default avatarRobert Habermeier <[email protected]>
Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
Co-authored-by: default avatarMax Inden <[email protected]>
Co-authored-by: default avatarSergey Shulepov <[email protected]>
Co-authored-by: default avatarSergei Shulepov <[email protected]>
      f82de7b9
    • Fedor Sakharov's avatar
      A real overseer feature (#1892) · 16f8da1d
      Fedor Sakharov authored 
      

* A real overseer feature

* Fix build without feature

* Update node/service/src/lib.rs

Co-authored-by: default avatarBastian Köcher <[email protected]>

Co-authored-by: default avatarRobert Habermeier <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
      16f8da1d
    • asynchronous rob's avatar
      Implementer's guide: Approval Voting Subsystem (#1691) · 43be64f2
      asynchronous rob authored 
      

* add storage for approvals module

* basics of approval logic

* fix links

* Session info module

* create an approvals_inherent module

* integrate approvals module with inclusion

* Remove approvals runtime

* tweak mentions of on-chain logic

* add note on finality-grandpa voting rule

* elaborate on node-side components

* stub for availability recovery

* add another note on voting rule

* Beginnings of approval subsystems

* flesh out approval voting now

* logic for checking assignment certs

* initial scheduler logic

* scheduler logic

* adjst tranche taking logic

* approval voting import

* approval work (voting side)

* amend some TODOs

* mark some TODOs

* describe `ApprovedAncestor`

* reference protocol-approval.md

* clarity on bitfield

* remove approvals_inherent

* tweak session_info module according to review

* formatting & nits

Co-authored-by: default avatarRobert Habermeier <[email protected]>
      43be64f2
  19. Oct 30, 2020
  21. Oct 29, 2020
  23. Oct 28, 2020