Skip to content
  1. Jan 13, 2021
    • Bernhard Schuster's avatar
      display errors with their sources (#2264) · 1d28f59e
      Bernhard Schuster authored
      * update futures to 0.3.9
      
      * companion changes for generic error types
      
      * improve errors, keep error sources
      
      * command compile fix
      
      * use the correct Error type, add annotation
      
      * avoid async { fut.await.map_err(E::Variant) } with TryFuture
      
      * fix cargo lock, bump futures to 0.3.10
      
      futures 0.3.9 got yanked
      
      * chore cargo update -p sp-io
      
      * minor quirk
      
      * make rustc 1.48 happy by bouning the error more tightly
      
      * be more explicit
      
      * cargo lock futures
      1d28f59e
    • Sergey Pepyakin's avatar
      ff341a7b
    • ordian's avatar
      Companion for substrate#7892 (#2262) · e1773be6
      ordian authored
      * session_info: use correct authorities set
      
      * bump rococo spec_version to 19
      
      * "Update Substrate"
      
      Co-authored-by: parity-processbot <>
      e1773be6
    • Bernhard Schuster's avatar
      metered mpsc channels (#2235) · d7adf8f2
      Bernhard Schuster authored
      d7adf8f2
    • Sergey Pepyakin's avatar
      HRMP channel deposits (#2225) · c644c39f
      Sergey Pepyakin authored
      * Drive by fixes
      
      The visibility modifiers are remnants of the previous structure where
      HRMP wasn't a standalone module, by rather a submodule of the router
      module.
      
      * Add Currency assoc type to Config
      
      This would allow us to reserve balance for deposits. This commit also
      integrates the HRMP module in rococo, test-runtime and mocks to use the
      balances pallet.
      
      * Fix a bug that doesn't increment the age
      
      In case the request is not confirmed, the age would be incremented but
      not persisted.
      
      * Fix cleaning the indexes
      
      Before that change, the cleaning of the channel indexes was wrong, because it
      naively removed entire rows that was pertaining to the para we delete.
      This approach is flawed because it doesn't account for the rows that are
      pertaining to other paras that contain the outgoing one.
      
      This clearly violates the invariant imposed on the indexes, that all
      the index rows must contain alive paras, but apart from that it also
      lead to the situation where ingress index would contain the a different
      set of channels that an egress have.
      
      * Reserve currency for opening the channels
      
      Note the ugly `unique_saturated_into` calls. The reason for them is the
      currency trait accepts and defines the `Balance` associated type and the
      deposit values are coming from the `HostConfiguration` where they are
      defined using the `Balance`.
      
      I figured that parameterising `HostConfiguration` would be annoying. On
      the other hand, I don't expect these `unique_saturated_into` calls to
      give us problems since it seems to be a reasonable assumption that this
      module will be instantiated within a runtime where the Currency provided
      will have a Balance that matches the one used in the configuration.
      
      * Tests: Adapt `run_to_block` so that it submits a proper config
      
      * Tests: exercise the deposit logic
      c644c39f
    • Sergey Pepyakin's avatar
      Avoid inlining `update_config_member` (#2246) · eae961ee
      Sergey Pepyakin authored
      Closes #2241
      eae961ee
  2. Jan 12, 2021
  3. Jan 11, 2021
  4. Jan 08, 2021
    • asynchronous rob's avatar
      subsystems have an unbounded channel to the overseer (#2236) · 03e39cf5
      asynchronous rob authored
      
      
      * subsystems have an unbounded channel to the overseer
      
      * Update node/overseer/src/lib.rs
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      
      * bump Cargo.lock
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      03e39cf5
    • Bastian Köcher's avatar
      Do not send empty view updates to peers (#2233) · 475915ff
      Bastian Köcher authored
      
      
      * Do not send empty view updates to peers
      
      It happened that we send empty view updates to our peers, because we
      only updated our finalized block. This could lead to situations where we
      overwhelmed sub systems with too many messages. On Rococo this lead to
      constant restarts of our nodes, because some node apparently was
      finalizing a lot of blocks.
      
      To prevent this, the pr is doing the following:
      
      1. If a peer sends us an empty view, we report this peer and decrease it
      reputation.
      
      2. We ensure that we only send a view update when the `heads` changed
      and not only the `finalized_number`.
      
      3. We do not send empty `ActiveLeavesUpdates` from the overseer, as this
      makes no sense to send these empty updates. If some subsystem is relying
      on the finalized block, it needs to listen for the overseer signal.
      
      * Update node/network/bridge/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * Don't work if they're are no added heads
      
      * Fix test
      
      * Ahhh
      
      * More fixes
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      475915ff
    • Fedor Sakharov's avatar
      Exit from av-store loop on fatal error. (#2232) · 8f293e18
      Fedor Sakharov authored
      * Fuse receive stream in Context
      
      * Revert "Fuse receive stream in Context"
      
      This reverts commit ddd26fa98f0ca1afbc22064e93010e4193a058b2.
      
      * Exit on node shutdown from av-store loop
      
      * Filter only context error
      8f293e18
  5. Jan 07, 2021
  6. Jan 06, 2021
    • ordian's avatar
      upgrade a few dependencies (companion for 7831) (#2205) · a0a5f4cf
      ordian authored
      * upgrade a few dependencies
      
      * "Update Substrate"
      
      Co-authored-by: parity-processbot <>
      a0a5f4cf
    • Denis_P's avatar
      CI: remove squash and fix buildah push (#2212) · 6bc1ec90
      Denis_P authored
      6bc1ec90
    • Pierre Krieger's avatar
      Make order consistent (#2215) · 2c951e10
      Pierre Krieger authored
      2c951e10
    • felix's avatar
      added new bootnode to chain spec's (#2204) · 9d07e99c
      felix authored
      * added new bootnode to chain spec's
      
      * remove trailing newline
      9d07e99c
    • Peter Goodspeed-Niklaus's avatar
      Add metrics timing message passing from OverseerSubsystemContext to Overseer::route_message (#2201) · cd58c02c
      Peter Goodspeed-Niklaus authored
      * add timing setup to OverseerSubsystemContext
      
      * figure out how to initialize the rng
      
      * attach a timer to a portion of the messages traveling to the Overseer
      
      This timer only exists / logs a fraction of the time (configurable
      by `MESSAGE_TIMER_METRIC_CAPTURE_RATE`). When it exists, it tracks
      the span between the `OverSubsystemContext` receiving the message
      and its receipt in `Overseer::run`.
      
      * propagate message timing to the start of route_message
      
      This should be more accurate; it ensures that the timer runs
      at least as long as that function. As `route_message` is async,
      it may not actually run for some time after it is called (or ever).
      
      * fix failing test
      
      * rand_chacha apparently implicitly has getrandom feature
      
      * change rng initialization
      
      The previous impl using `from_entropy` depends on the `getrandom`
      crate, which uses the system entropy source, and which does not
      work on `wasm32-unknown-unknown` because it wants to fall back to
      a JS implementation which we can't assume exists.
      
      This impl depends only on `rand::thread_rng`, which has no documentation
      stating that it's similarly limited.
      
      * remove randomness in favor of a simpler 1 of N procedure
      
      This deserves a bit of explanation, as the motivating issue explicitly
      requested randomness. In short, it's hard to get randomness to compile
      for `wasm32-unknown-unknown` because that is explicitly intended to be
      as deterministic as practical. Additionally, even though it would never
      be used for consensus purposes, it still felt offputting to intentionally
      introduce randomness into a node's operations. Except, it wasn't really
      random, either: it was a deterministic PRNG varying only in its state,
      and getting the state to work right for that target would have required
      initializing from a constant.
      
      Given that it was a deterministic sequence anyway, it seemed much simpler
      and more explicit to simply select one of each N messages instead of
      attempting any kind of realistic randomness.
      
      * reinstate randomness for better statistical properties
      
      This partially reverts commit 0ab8594c328b3f9ce1f696fe405556d4000630e9.
      
      `oorandom` is much lighter than the previous `rand`-based implementation,
      which makes this easier to work with.
      
      This implementation gives each subsystem and each child RNG a distinct
      increment, which should ensure they produce distinct streams of values.
      cd58c02c
    • dependabot[bot]'s avatar
      Bump trie-db from 0.22.1 to 0.22.2 (#2208) · 54054b6d
      dependabot[bot] authored
      
      
      Bumps [trie-db](https://github.com/paritytech/trie) from 0.22.1 to 0.22.2.
      - [Release notes](https://github.com/paritytech/trie/releases)
      - [Commits](https://github.com/paritytech/trie/compare/trie-db-v0.22.1...trie-db-v0.22.2)
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      54054b6d
    • André Silva's avatar
      runtime: add Babe::next_epoch runtime api method (#2200) · a00c6fd6
      André Silva authored
      * runtime: add Babe::next_epoch runtime api method
      
      * "Update Substrate"
      
      Co-authored-by: parity-processbot <>
      a00c6fd6
    • dependabot[bot]'s avatar
      Bump pin-project from 1.0.2 to 1.0.3 (#2209) · 82ee539d
      dependabot[bot] authored
      
      
      Bumps [pin-project](https://github.com/taiki-e/pin-project) from 1.0.2 to 1.0.3.
      - [Release notes](https://github.com/taiki-e/pin-project/releases)
      - [Changelog](https://github.com/taiki-e/pin-project/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/taiki-e/pin-project/compare/v1.0.2...v1.0.3)
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      82ee539d
    • Shawn Tabrizi's avatar
      Companion PR for 7822 (Remove `_{}` from benchmarks) (#2202) · 73d26e0b
      Shawn Tabrizi authored
      * Remove `_{}` from benchmarks macro
      
      * "Update Substrate"
      
      Co-authored-by: parity-processbot <>
      73d26e0b
  7. Jan 05, 2021
    • Bastian Köcher's avatar
      Improve the `unbacked-span` (#2206) · 453b6fff
      Bastian Köcher authored
      This ensures that we also record the first `import_statement` that will
      lead to the creation of the `unbacked-span`.
      453b6fff
    • Peter Goodspeed-Niklaus's avatar
      Reduce the inclusion inherent's actual weight if the block is already heavy (#2060) · fcc0fca1
      Peter Goodspeed-Niklaus authored
      
      
      * don't modify inherent data on heavy block
      
      * write up current thinking on block weight detection
      
      * extract inherent inclusion check into its own function
      
      * put heavy block check into runtime
      
      * the `inclusion` inherent call is Operational, not Mandatory
      
      This resolves a lot of the trickiness about this issue, because
      we no longer need to override or supplant any existing proposer
      logic; the existing logic should exhibit these behaviors:
      
      - the `inclusion` inherent is prioritized over standard transactions
      - but if it's too heavy, i.e. in case of runtime upgrade, it'll be
        dropped in favor of that.
      
      It is my belief that allowing the proposer to just not include
      this data won't have any adverse effects: it's equivalent to replacing
      them with empty versions of themselves, which the `ProvideInherent`
      impl already does.
      
      * Revert "the `inclusion` inherent call is Operational, not Mandatory"
      
      This reverts commit e58858d109b18b84e7af3ac47981c6900b2d9a3e.
      
      * Revert "write up current thinking on block weight detection"
      
      This reverts commit fd587b80c46761b2a2b62448193348237863f99f.
      
      * Revert "don't modify inherent data on heavy block"
      
      This reverts commit 38299d3c23e9efb5a354d8cfa658e62a5c8c7ddf.
      
      * add backed candidate block weight assumption to configuration
      
      * Limit backed candidates according to a candidate weight heuristic.
      
      This approach replaces making the inclusion inherent non-mandatory.
      It's still not ideal in that we have to configure a heuristic for
      how much each backed candidate 'weighs', instead of directly
      measuring it somehow.
      
      This approach also never truncates the signed bitfields. The
      rationale for that depends on some assumptions:
      
      - processing the signed bitfields is cheap compared to the
        backed candidates
      - it is beneficial to the progress of the relay chain
        to update the signed bitfields even if not all backed candidates
        are updated
      
      * simplify limit_backed_candidates and weight assumption
      
      * don't trust the provisioner to fairly distribute candidates
      
      * use saturating subtraction
      
      * empty commit to restart ci
      
      * use new mechanism for getting max block weight
      
      * apply weight refunds to the inclusion inherent
      
      This makes some assumptions about fundamental weights, which are
      encapsulated as constants. From there, it lets Substrate know
      what the actual computed weight of the inherent is.
      
      * use a correct fixed weight for the inclusion inherent
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * use dynamic inclusion weight so we reduce calculated weight when excluding candidates
      
      * don't double-count this intrinsic's weight in the block weight
      
      * add unit tests of fn limit_backed_candidates
      
      * add tests that the inclusion inherent's weight correctly updates
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      fcc0fca1