- Dec 19, 2022
-
-
Michal Kucharczyk authored* sc-network-test::Peer: block push methods return hashes vec This commit reworks the block generation/push methods in sc-network-test::Peer. Now methods are providing the vector of hashes that were built. This allows to get rid of redundant `block_hash_from_id` call, as all hashes are known just after being built. Similar approach was taken in BeefyTestNet::generate_blocks_and_sync method. This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * fix * Apply suggestions from code review Co-authored-by:
Bastian Köcher <[email protected]> Co-authored-by:
-
Qinxuan Chen authored
* *: update rand to v0.8.5 * *: remove useless deps from Cargo.toml * fix pallet-session-benchmarking * fix pallet-election-provider-support test * remove useless rand from dev-dependencies
-
- Dec 17, 2022
-
-
Bastian Köcher authored
* Save * Add some test * Yep * Move to its own file * More work * More * Finish implementation * Start resolving comments and fixing bugs * Fix all review comments * Update frame/support/src/storage/stream_iter.rs Co-authored-by:
Koute <[email protected]> * Update frame/support/src/storage/stream_iter.rs Co-authored-by:
-
Bastian Köcher authored
-
- Dec 16, 2022
-
-
Bastian Köcher authored
* Defensive traits: Ensure doc tests are also working without `debug_assertions` Closes: https://github.com/paritytech/substrate/issues/12940 * Only run 'panics' tests if they will panic Signed-off-by:
Oliver Tale-Yazdi <[email protected]> Signed-off-by:
-
Bastian Köcher authored
* Fix missing block number issue on forced canonicalization There is this issue about missing block numbers on forced canonicalization. I looked over the code now 10000 times and there are possible ways this can be triggered, but I don't really know how this is triggered. So, this pr is going to solve the symptom and not the cause. The block number to hash mapping is set when we import a new best block. Forced canonicalization will now stop at the best block and it will canonicalize the other blocks later when the best block moved. As the error reports indicated that this issue mainly happened on major sync, there should not be any forks, so not doing the canonicalization directly shouldn't be that harmful. All known implementations should import all blocks as best block on major sync anyway (I mean somewhere there is the bug, but I didn't yet found it). I will also do some changes to Cumulus around some potential culprit for this issue. Closes: https://github.com/paritytech/substrate/issues/12613 * Add some docs * Fix fix * Review comments * Review comments
-
Dmitry Markin authored
-
João Paulo Silva de Souza authored
* set WASM_BUILD_WORKSPACE_HINT this enables wasm-builder to find the Cargo.lock from within generated packages * wip: try out https://github.com/paritytech/pipeline-scripts/pull/90 * wip: fixup * wip * revert ci skip * set up WASM_BUILD_WORKSPACE_HINT for .kubernetes-env as well * Update scripts/ci/gitlab/pipeline/publish.yml Co-authored-by:
Alexander Samusev <[email protected]> Co-authored-by:
-
Bernardo A. Rodrigues authored* improve ocw validator/collator CLI description * rename WhenValidating to WhenAuthoring * Update client/cli/src/arg_enums.rs Co-authored-by:
Alexandru Vasile <[email protected]> Co-authored-by:
-
- Dec 15, 2022
-
-
Bastian Köcher authored
-
João Paulo Silva de Souza authored
necessary when lots of crates need to be published, as demonstrated by https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2158667
-
Oliver Tale-Yazdi authored* Warn on missing call_index Signed-off-by:
-
Adrian Catangiu authored
* beefy: add BEEFY 'spec' * Apply suggestions from code review Signed-off-by:
Adrian Catangiu <[email protected]> Co-authored-by:
Tomasz Drwięga <[email protected]> Co-authored-by:
André Silva <[email protected]> Co-authored-by:
-
Gonçalo Pestana authored
* Prevents max unbonding chunk slots from being filled when unbonding in the staking pallet * hardcode num_slashing to unlock chunks automatically * refactor withdraw logic to do_withdraw; idiomatic rust improvements * a * callable unbond() to return a DispatchWithPostInfo to dynamically update the consumed weight * refunds overpaid fees when unbond with withdraw * fetches real slashing spans before withdrawal call * nits * addresses PR comments * Adds more testing * fixes doc comments * Fixes weight refunding logic for fn unbond * generalizes to return used weight or dispatch error * Update frame/staking/src/pallet/mod.rs Co-authored-by:
Kian Paimani <[email protected]> * Update frame/staking/src/pallet/mod.rs Co-authored-by:
-
- Dec 14, 2022
-
-
Kian Paimani authored
* fix online/offline confusion * unified cache file * multi-threaded babyyy * checkpoint for niklas * compiles * all tests pass with --test-threads 1 * child-tree scrape is also multi-threaded now. * better thread splitting * some suggestions (#12532) * some suggestions * tokio multithread * move unused dependencies * snapshot command * fix rem * a bit of cleanup * support optional checks * fix * OCW command migrated to wasm-only, as an example * state-version management fully in remote-ext * almost everything move to wasm executor, some CLI flags reduced * follow-chain works as well * Master.into() * everything builds now * concurrent insertion and download for remote builds * minor fix * fix a bug * checkpoint * some updates * fmt * review comments * fmt * fix * fmt * update * fmt * rename * fix the damn UI tests * fmt * remoe the thread abstraction for the time being * cleanup * fix CI * fmt * fix * fix a few more things * tweak log levels * better error handling * address grumbles: use futures::mpsc * review comments * fmt * Apply suggestions from code review Co-authored-by:
Alexandru Vasile <[email protected]> * cli: Keep `finalized` notation and remove `canonical` one * cli: Fix cargo doc * cli: `PruningModeClap` IR enum Signed-off-by:
🤔 * General Message Queue Pallet (#12485) * The message queue * Make fully generic * Refactor * Docs * Refactor * Use iter not slice * Per-origin queues * Multi-queue processing * Introduce MaxReady * Remove MaxReady in favour of ready ring * Cleanups * ReadyRing and tests * Stale page reaping * from_components -> from_parts Signed-off-by:Robert Klotzner <[email protected]> Signed-off-by:
Keith Yeung <[email protected]> * zombienet timings adjusted (#12890) * zombinet tests: add some timeout to allow net spin-up Sometimes tests are failing at first try, as the pods were not up yet. Adding timeout should allow the network to spin up properly. * initial timeout increased to 30s * Move import queue out of `sc-network` (#12764) * Move import queue out of `sc-network` Add supplementary asynchronous API for the import queue which means it can be run as an independent task and communicated with through the `ImportQueueService`. This commit removes removes block and justification imports from `sc-network` and provides `ChainSync` with a handle to import queue so it can import blocks and justifications. Polling of the import queue is moved complete out of `sc-network` and `sc_consensus::Link` is implemented for `ChainSyncInterfaceHandled` so the import queue can still influence the syncing process. * Fix tests * Apply review comments * Apply suggestions from code review Co-authored-by:
Andronik <[email protected]> * fix * Update frame/staking/src/pallet/impls.rs * update lock * fix all tests * review comments * fmt * fix offence bench * clippy * ".git/.scripts/bench-bot.sh" pallet dev pallet_staking Co-authored-by:
Ankan <[email protected]> Co-authored-by: command-bot <> * bounties calls docs fix (#12909) Co-authored-by: parity-processbot <> * pallet-contracts migration pre-upgrade fix for v8 (#12905) * Only run pre-v8 migration check for versions older than 8 * Logix fix * use custom environment for publishing crates (#12912) * [contracts] Add debug buffer limit + enforcement (#12845) * Add debug buffer limit + enforcement Add debug buffer limit + enforcement * use BoundedVec for the debug buffer * revert schedule (debug buf len limit not needed anymore) * return DispatchError * addressed review comments * frame/remote-externalities: Fix clippy Signed-off-by:
Vlad <[email protected]>
Co-authored-by: Anthony Alaribe <[email protected]> Co-authored-by:
Gavin Wood <[email protected]> Co-authored-by:
Michal Kucharczyk <[email protected]> Co-authored-by:
Aaro Altonen <[email protected]> Co-authored-by:
tgmichel <[email protected]> Co-authored-by:
Ankan <[email protected]> Co-authored-by:
Luke Schoen <[email protected]> Co-authored-by:
Niklas Adolfsson <[email protected]> Co-authored-by:
Arkadiy Paronyan <[email protected]> Co-authored-by:
Muharem Ismailov <[email protected]> Co-authored-by:
Dino Pačandi <[email protected]> Co-authored-by:
João Paulo Silva de Souza <[email protected]> Co-authored-by:
Sasha Gryaznov <[email protected]> Co-authored-by:
Alexander Popiak <[email protected]> Co-authored-by:
🤔 * General Message Queue Pallet (#12485) * The message queue * Make fully generic * Refactor * Docs * Refactor * Use iter not slice * Per-origin queues * Multi-queue processing * Introduce MaxReady * Remove MaxReady in favour of ready ring * Cleanups * ReadyRing and tests * Stale page reaping * from_components -> from_parts Signed-off-by:Vlad <[email protected]>
Co-authored-by: Davide Galassi <[email protected]> * Revert "Lexnv/kiz revamp try runtime stuff (#12932)" This reverts commit 378cfb26d984bcde467781f07ef8ddb6998212cb. * fmt * update * fix publish Signed-off-by:
Vlad <[email protected]>
Co-authored-by: -
Gonçalo Pestana authored
* Staking: store last min-active-bond on-chain Storing the `min-active-bond` onchain helps the UIs with minimal on-chain costs. Closes https://github.com/paritytech/substrate/issues/12746 * Avoid relying on sorting to set the * Addresses PR comments
-
Davide Galassi authored* Use shared LOG_TARGET in consensus related crates * Rename target from "afg" to "grandpa"
-
Alexander Samusev authored
-
Arkadiy Paronyan authored
* Pin all canonicalized blocks * Added a test * Docs
-
Alexander Popiak authored
add numerator and denominator to Rational128 Debug impl and increase precision of float representation (#12914)
-
- Dec 13, 2022
-
-
Bastian Köcher authored
* Fixup some wrong dependencies Dev dependencies should not appear in the feature list. If features are required, they should be directly enabled for the `dev-dependency`. * More fixups * Fix fix * Remove deprecated feature * Make all work properly and nice!! * FMT * Fix formatting
-
Sasha Gryaznov authored
* Add debug buffer limit + enforcement Add debug buffer limit + enforcement * use BoundedVec for the debug buffer * revert schedule (debug buf len limit not needed anymore) * return DispatchError * addressed review comments
-
João Paulo Silva de Souza authored
-
Dino Pačandi authored
* Only run pre-v8 migration check for versions older than 8 * Logix fix
-
- Dec 12, 2022
-
-
Muharem Ismailov authored
Co-authored-by: parity-processbot <>
-
Kian Paimani authored
* don't read slashing spans when taking election snapshot * update cargo.toml * bring back remote test * fix merge stuff * fix npos-voters function sig * remove as much redundant diff as you can * Update frame/staking/src/pallet/mod.rs Co-authored-by:
-
Arkadiy Paronyan authored
-
Oliver Tale-Yazdi authored
* frame-system: explicit call index Signed-off-by:
-
Oliver Tale-Yazdi authored
* Fix license Signed-off-by:
-
Niklas Adolfsson authored
* jsonrpsee v0.16 add backwards compatibility run old http server on http only * cargo fmt * update jsonrpsee 0.16.1 * less verbose cors log * fix nit in log: WS -> HTTP * revert needless changes in Cargo.lock * remove unused features in tower * fix nits; add client-core feature * jsonrpsee v0.16.2
-
- Dec 11, 2022
-
-
Bastian Köcher authored
* ValidateUnsigned: Improve docs. * Review comments
-
Luke Schoen authored
-
- Dec 10, 2022
-
-
Ankan authored
* checked call for desired targets * fix compile * fmt * fix tests * cleaner with and_then
-
Bastian Köcher authored
* Ensure that we inform all tasks to stop before starting the 60 seconds shutdown The change of waiting in maximum 60 seconds for the node to shutdown actually introduced a bug. We were actually waiting always 60 seconds as we didn't informed our tasks to shutdown. The solution to this problem is to drop the task manager as this will then inform all tasks to end. It also adds tests to ensure that the behaviors work as expected. (This should already have been done in the first pr! :() * ".git/.scripts/fmt.sh" 1 Co-authored-by: command-bot <>
-
- Dec 09, 2022
-
-
tgmichel authored
* Trace result in default `jsonrpsee` middleware * `rpc_metrics::extra` Co-authored-by:
-
Aaro Altonen authored
* Move import queue out of `sc-network` Add supplementary asynchronous API for the import queue which means it can be run as an independent task and communicated with through the `ImportQueueService`. This commit removes removes block and justification imports from `sc-network` and provides `ChainSync` with a handle to import queue so it can import blocks and justifications. Polling of the import queue is moved complete out of `sc-network` and `sc_consensus::Link` is implemented for `ChainSyncInterfaceHandled` so the import queue can still influence the syncing process. * Fix tests * Apply review comments * Apply suggestions from code review Co-authored-by:
-
Michal Kucharczyk authored
* zombinet tests: add some timeout to allow net spin-up Sometimes tests are failing at first try, as the pods were not up yet. Adding timeout should allow the network to spin up properly. * initial timeout increased to 30s
-
Gavin Wood authored
* The message queue * Make fully generic * Refactor * Docs * Refactor * Use iter not slice * Per-origin queues * Multi-queue processing * Introduce MaxReady * Remove MaxReady in favour of ready ring * Cleanups * ReadyRing and tests * Stale page reaping * from_components -> from_parts Signed-off-by:
-
Bastian Köcher authored
* Don't indefinitely on shutting down Tokio Now we wait in maximum 60 seconds before we shutdown the node. Tasks are may be leaked and leading to some data corruption. * Drink less
🤔 -
Anthony Alaribe authored
Revert "Move LockableCurrency trait to fungibles::Lockable and deprecate LockableCurrency (#12798)" (#12882) This reverts commit 9a014d1e.
-
