Skip to content
  1. Nov 09, 2020
  2. Nov 06, 2020
    • Sergey Pepyakin's avatar
      Implement HRMP (#1900) · c96f8cfc
      Sergey Pepyakin authored
      
      
      * HRMP: Update the impl guide
      
      * HRMP: Incorporate the channel notifications into the guide
      
      * HRMP: Renaming in the impl guide
      
      * HRMP: Constrain the maximum number of HRMP messages per candidate
      
      This commit addresses the HRMP part of https://github.com/paritytech/polkadot/issues/1869
      
      * XCM: Introduce HRMP related message types
      
      * HRMP: Data structures and plumbing
      
      * HRMP: Configuration
      
      * HRMP: Data layout
      
      * HRMP: Acceptance & Enactment
      
      * HRMP: Test base logic
      
      * Update adder collator
      
      * HRMP: Runtime API for accessing inbound messages
      
      Also, removing some redundant fully-qualified names.
      
      * HRMP: Add diagnostic logging in acceptance criteria
      
      * HRMP: Additional tests
      
      * Self-review fixes
      
      * save test refactorings for the next time
      
      * Missed a return statement.
      
      * a formatting blip
      
      * Add missing logic for appending HRMP digests
      
      * Remove the channel contents vectors which became empty
      
      * Tighten HRMP channel digests invariants.
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * Remove a note about sorting for channel id
      
      * Add missing rustdocs to the configuration
      
      * Clarify and update the invariant for HrmpChannelDigests
      
      * Make the onboarding invariant less sloppy
      
      Namely, introduce `Paras::is_valid_para` (in fact, it already is present
      in the implementation) and hook up the invariant to that.
      
      Note that this says "within a session" because I don't want to make it
      super strict on the session boundary. The logic on the session boundary
      should be extremely careful.
      
      * Make `CandidateCheckContext` use T::BlockNumber for hrmp_watermark
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      c96f8cfc
  3. Nov 03, 2020
  4. Nov 02, 2020
  5. Oct 31, 2020
    • Bastian Köcher's avatar
      Adds test parachain adder collator (#1864) · f82de7b9
      Bastian Köcher authored
      
      
      * start working on building the real overseer
      
      Unfortunately, this fails to compile right now due to an upstream
      failure to compile which is probably brought on by a recent upgrade
      to rustc v1.47.
      
      * fill in AllSubsystems internal constructors
      
      * replace fn make_metrics with Metrics::attempt_to_register
      
      * update to account for #1740
      
      * remove Metrics::register, rename Metrics::attempt_to_register
      
      * add 'static bounds to real_overseer type params
      
      * pass authority_discovery and network_service to real_overseer
      
      It's not straightforwardly obvious that this is the best way to handle
      the case when there is no authority discovery service, but it seems
      to be the best option available at the moment.
      
      * select a proper database configuration for the availability store db
      
      * use subdirectory for av-store database path
      
      * apply Basti's patch which avoids needing to parameterize everything on Block
      
      * simplify path extraction
      
      * get all tests to compile
      
      * Fix Prometheus double-registry error
      
      for debugging purposes, added this to node/subsystem-util/src/lib.rs:472-476:
      
      ```rust
      Some(registry) => Self::try_register(registry).map_err(|err| {
      	eprintln!("PrometheusError calling {}::register: {:?}", std::any::type_name::<Self>(), err);
      	err
      }),
      ```
      
      That pointed out where the registration was failing, which led to
      this fix. The test still doesn't pass, but it now fails in a new
      and different way!
      
      * authorities must have authority discovery, but not necessarily overseer handlers
      
      * fix broken SpawnedSubsystem impls
      
      detailed logging determined that using the `Box::new` style of
      future generation, the `self.run` method was never being called,
      leading to dropped receivers / closed senders for those subsystems,
      causing the overseer to shut down immediately.
      
      This is not the final fix needed to get things working properly,
      but it's a good start.
      
      * use prometheus properly
      
      Prometheus lets us register simple counters, which aren't very
      interesting. It also allows us to register CounterVecs, which are.
      With a CounterVec, you can provide a set of labels, which can
      later be used to filter the counts.
      
      We were using them wrong, though. This pattern was repeated in a
      variety of places in the code:
      
      ```rust
      // panics with an cardinality mismatch
      let my_counter = register(CounterVec::new(opts, &["succeeded", "failed"])?, registry)?;
      my_counter.with_label_values(&["succeeded"]).inc()
      ```
      
      The problem is that the labels provided in the constructor are not
      the set of legal values which can be annotated, but a set of individual
      label names which can have individual, arbitrary values.
      
      This commit fixes that.
      
      * get av-store subsystem to actually run properly and not die on first signal
      
      * typo fix: incomming -> incoming
      
      * don't disable authority discovery in test nodes
      
      * Fix rococo-v1 missing session keys
      
      * Update node/core/av-store/Cargo.toml
      
      * try dummying out av-store on non-full-nodes
      
      * overseer and subsystems are required only for full nodes
      
      * Reduce the amount of warnings on browser target
      
      * Fix two more warnings
      
      * InclusionInherent should actually have an Inherent module on rococo
      
      * Ancestry: don't return genesis' parent hash
      
      * Update Cargo.lock
      
      * fix broken test
      
      * update test script: specify chainspec as script argument
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update node/service/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * node/service/src/lib: Return error via ? operator
      
      * post-merge blues
      
      * add is_collator flag
      
      * prevent occasional av-store test panic
      
      * simplify fix; expand application
      
      * run authority_discovery in Role::Discover when collating
      
      * distinguish between proposer closed channel errors
      
      * add IsCollator enum, remove is_collator CLI flag
      
      * improve formatting
      
      * remove nop loop
      
      * Fix some stuff
      
      * Adds test parachain adder collator
      
      * Add sudo to Rococo, change session length to 30 seconds and some renaming
      
      * Update to the latest changes on master
      
      * Some fixes
      
      * Fix compilation
      
      * Update parachain/test-parachains/adder/collator/src/lib.rs
      
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      
      * Review comments
      
      * Downgrade transaction version
      
      * Fixes
      
      * MOARE
      
      * Register notification protocols
      
      * utils: remove unused error
      
      * av-store: more resilient to some errors
      
      * address review nits
      
      * address more review nits
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      Co-authored-by: default avatarFedor Sakharov <[email protected]>
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarMax Inden <[email protected]>
      Co-authored-by: default avatarSergey Shulepov <[email protected]>
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      f82de7b9
  6. Aug 13, 2020
    • asynchronous rob's avatar
      Remove v0 parachains runtime (#1501) · 57aef8ee
      asynchronous rob authored
      * remove v0 parachains modules and switch to v1 primitives
      
      * get tests compiling for runtime-common
      
      * remove registrar module
      
      * Add a dummy module
      
      * remove runtime-parachains
      
      * mostly remove old parachains code from polkadot-runtime
      
      * remove slots::Trait implementation
      
      * remove sp_std prelude import
      
      * add a ZeroSizedTypeDifferentiator to dummy
      
      * finish porting over polkadot runtime
      
      * ZeroSizedTypeDifferentiator was actually unnecessary
      
      * westend
      
      * kusama
      
      * test-runtime (no dummy modules)
      
      * fix warning
      
      * fix chain-specs
      
      * fix test-service
      
      * test-client
      
      * remove dead import
      
      * remove unused needed_extrinsics parameter
      
      * runtimes compile
      
      * remove rococo-v0
      
      * remove remaining references to Rococo
      
      * bump versions
      57aef8ee
  7. Aug 04, 2020
    • Shawn Tabrizi's avatar
      Unalias Substrate Imports (#1530) · 73f09e51
      Shawn Tabrizi authored
      
      
      * cargo.toml updates
      
      * session and system
      
      * more
      
      * more
      
      * more
      
      * more
      
      * more
      
      * fix
      
      * compiles
      
      * fix tests
      
      * fix more tests
      
      * fix mock
      
      * fix deleted space
      
      * Update validation/Cargo.toml
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update Cargo.lock
      
      * update rococo
      
      * remove unused warning
      
      * update add benchmarks
      
      * rename weight file
      
      * forgot a file
      
      * Update chain_spec.rs
      
      * Revert "remove unused warning"
      
      This reverts commit 4227cd0d1525286fb466dccb817564c9b37f8645.
      
      * fix merge
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      73f09e51
    • Bastian Köcher's avatar
      Rewrite client handling (#1531) · c01aa8ba
      Bastian Köcher authored
      
      
      * Rewrite client handling
      
      We are supporting muliple polkadot-like chains and all have different
      client types. This pr reworks the client handling by having all of them
      in one enum combined. Besides that, there is added a special trait
      `ExecuteWithClient` to use the internal client.
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Up the versions
      
      * Fix Cargo.lock
      
      * Fix merge conflict
      
      * ......................
      
      * ....v2
      
      * yep
      
      * I'm dumb...
      
      * Browser lol
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      c01aa8ba
    • Bastian Köcher's avatar
      Add Rococo test network (#1363) · 5a4bca76
      Bastian Köcher authored
      
      
      * Add Rococo test network
      
      * Correct license header
      
      * Add bootNodes address
      
      * Fix compile errors
      
      * Change bootNodes
      
      * Change rococo bootNodes
      
      * Add new bootNodes
      
      * Fix bootNodes typo
      
      * Remove public telemetry
      
      * Add rococo-local chain spec
      
      * Remove staking
      
      * Remove staking from chain spec
      
      * use rococo-staging chain spec and preserve bootnodes
      
      * Same but with --raw
      
      * update chain name and remove telemetry
      
      * Empty commit to re-trigger CI
      
      * Fix revision (temp. until I merge master)
      
      * Revert to branch = master to avoid conflicts
      
      * Revert to branch = master to avoid conflicts
      
      * Disable test (temp)
      
      * Revert to branch = master to avoid conflicts
      
      * Revert to branch = master to avoid conflicts
      
      * Change bootNodes IPs for second rococo network
      
      * Revert "Disable test (temp)"
      
      This reverts commit a159f12e3131d1a25dabb1a4d2834642f2bcdc26.
      
      * Revert purchase
      
      * Update chain spec
      
      * FUUU
      
      * Update service/src/lib.rs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Update runtime/rococo/src/lib.rs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Fix compilation
      
      Co-authored-by: default avatarEvaldo <[email protected]>
      Co-authored-by: default avatarDavid Dorgan <[email protected]>
      Co-authored-by: default avatarCecile Tonglet <[email protected]>
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      5a4bca76
  8. Aug 02, 2020
  9. Jul 31, 2020
    • Fedor Sakharov's avatar
      Parachains-runtime (#1505) · 047e2fdb
      Fedor Sakharov authored
      * Initial commit
      
      * v0 to v1 primitives and remove attestations
      
      * Review fixes
      
      * implement candidate_events
      
      * remove dead code
      047e2fdb