- Nov 15, 2023
-
-
Dónal Murray authored
Add collectives and glutton parachain westend runtimes to prepare for #1737. The removal of system parachain native runtimes #1737 is blocked until chainspecs and runtime APIs can be dealt with cleanly (merge of #1256 and follow up PRs). In the meantime, these additions are ready to be merged to `master`, so I have separated them out into this PR. Also marked `bridge-hub-westend` as unimplemented in line with [this issue](https://github.com/paritytech/parity-bridges-common/issues/2602). TODO - [x] add to `command-bot` benchmarks - [x] add to `command-bot-scripts` benchmarks - [x] generate weights --------- Co-authored-by:
joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by:
Muharem <ismailov.m.h@gmail.com> Co-authored-by: command-bot <> Co-authored-by:
Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by:
Branislav Kontur <bkontur@gmail.com>
-
- Nov 02, 2023
-
-
Oliver Tale-Yazdi authored(imported from https://github.com/paritytech/cumulus/pull/2157) ## Changes This MR refactores the XCMP, Parachains System and DMP pallets to use the [MessageQueue](https://github.com/paritytech/substrate/pull/12485) for delayed execution of incoming messages. The DMP pallet is entirely replaced by the MQ and thereby removed. This allows for PoV-bounded execution and resolves a number of issues that stem from the current work-around. All System Parachains adopt this change. The most important changes are in `primitives/core/src/lib.rs`, `parachains/common/src/process_xcm_message.rs`, `pallets/parachain-system/src/lib.rs`, `pallets/xcmp-queue/src/lib.rs` and the runtime configs. ### DMP Queue Pallet The pallet got removed and its logic refactored into parachain-system. Overweight message management can be done directly through the MQ pallet. Final undeployment migrations are provided by `cumulus_pallet_dmp_queue::UndeployDmpQueue` and `DeleteDmpQueue` that can be configured with an aux config trait like: ```rust parameter_types! { pub const DmpQueuePalletName: &'static str = \"DmpQueue\" < CHANGE ME; pub const RelayOrigin: AggregateMessageOrigin = AggregateMessageOrigin::Parent; } impl cumulus_pallet_dmp_queue::MigrationConfig for Runtime { type PalletName = DmpQueuePalletName; type DmpHandler = frame_support::traits::EnqueueWithOrigin<MessageQueue, RelayOrigin>; type DbWeight = <Runtime as frame_system::Config>::DbWeight; } // And adding them to your Migrations tuple: pub type Migrations = ( ... cumulus_pallet_dmp_queue::UndeployDmpQueue<Runtime>, cumulus_pallet_dmp_queue::DeleteDmpQueue<Runtime>, ); ``` ### XCMP Queue pallet Removed all dispatch queue functionality. Incoming XCMP messages are now either: Immediately handled if they are Signals, enqueued into the MQ pallet otherwise. New config items for the XCMP queue pallet: ```rust /// The actual queue implementation that retains the messages for later processing. type XcmpQueue: EnqueueMessage<ParaId>; /// How a XCM over HRMP from a sibling parachain should be processed. type XcmpProcessor: ProcessMessage<Origin = ParaId>; /// The maximal number of suspended XCMP channels at the same time. #[pallet::constant] type MaxInboundSuspended: Get<u32>; ``` How to configure those: ```rust // Use the MessageQueue pallet to store messages for later processing. The `TransformOrigin` is needed since // the MQ pallet itself operators on `AggregateMessageOrigin` but we want to enqueue `ParaId`s. type XcmpQueue = TransformOrigin<MessageQueue, AggregateMessageOrigin, ParaId, ParaIdToSibling>; // Process XCMP messages from siblings. This is type-safe to only accept `ParaId`s. They will be dispatched // with origin `Junction::Sibling(…)`. type XcmpProcessor = ProcessFromSibling< ProcessXcmMessage< AggregateMessageOrigin, xcm_executor::XcmExecutor<xcm_config::XcmConfig>, RuntimeCall, >, >; // Not really important what to choose here. Just something larger than the maximal number of channels. type MaxInboundSuspended = sp_core::ConstU32<1_000>; ``` The `InboundXcmpStatus` storage item was replaced by `InboundXcmpSuspended` since it now only tracks inbound queue suspension and no message indices anymore. Now only sends the most recent channel `Signals`, as all prio ones are out-dated anyway. ### Parachain System pallet For `DMP` messages instead of forwarding them to the `DMP` pallet, it now pushes them to the configured `DmpQueue`. The message processing which was triggered in `set_validation_data` is now being done by the MQ pallet `on_initialize`. XCMP messages are still handed off to the `XcmpMessageHandler` (XCMP-Queue pallet) - no change here. New config items for the parachain system pallet: ```rust /// Queues inbound downward messages for delayed processing. /// /// Analogous to the `XcmpQueue` of the XCMP queue pallet. type DmpQueue: EnqueueMessage<AggregateMessageOrigin>; ``` How to configure: ```rust /// Use the MQ pallet to store DMP messages for delayed processing. type DmpQueue = MessageQueue; ``` ## Message Flow The flow of messages on the parachain side. Messages come in from the left via the `Validation Data` and finally end up at the `Xcm Executor` on the right.  ## Further changes - Bumped the default suspension, drop and resume thresholds in `QueueConfigData::default()`. - `XcmpQueue::{suspend_xcm_execution, resume_xcm_execution}` errors when they would be a noop. - Properly validate the `QueueConfigData` before setting it. - Marked weight files as auto-generated so they wont auto-expand in the MR files view. - Move the `hypothetical` asserts to `frame_support` under the name `experimental_hypothetically` Questions: - [ ] What about the ugly `#[cfg(feature = \"runtime-benchmarks\")]` in the runtimes? Not sure how to best fix. Just having them like this makes tests fail that rely on the real message processor when the feature is enabled. - [ ] Need a good weight for `MessageQueueServiceWeight`. The scheduler already takes 80% so I put it to 10% but that is quite low. TODO: - [x] Remove c&p code after https://github.com/paritytech/polkadot/pull/6271 - [x] Use `HandleMessage` once it is public in Substrate - [x] fix `runtime-benchmarks` feature https://github.com/paritytech/polkadot/pull/6966 - [x] Benchmarks - [x] Tests - [ ] Migrate `InboundXcmpStatus` to `InboundXcmpSuspended` - [x] Possibly cleanup Migrations (DMP+XCMP) - [x] optional: create `TransformProcessMessageOrigin` in Substrate and replace `ProcessFromSibling` - [ ] Rerun weights on ref HW --------- Signed-off-by:Liam Aharon <liam.aharon@hotmail.com> Co-authored-by:
Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: command-bot <>
-
- Oct 26, 2023
-
-
Alin Dima authored
the min slot duration should be 0 only if the `experimental` feature is enabled. otherwise, the runtime will panic on a division by 0.
-
- Oct 04, 2023
-
-
Bradley Olson authored
Applied changes from the [User Update Guide](https://docs.google.com/document/d/1WQijD3bZTCsudOyPcDvugv659nCa2hEp2b_8eRU0h-Q), diverging in the node side where service.rs is different for `polkadot-parachain` than in the parachain template.
-
- Sep 27, 2023
-
-
Michal Kucharczyk authoredThis PR implements [`GenesisBuilder` API](https://github.com/paritytech/polkadot-sdk/blob/a414ea75 /substrate/primitives/genesis-builder/src/lib.rs#L38) for all the runtimes in polkadot repo. Step towards: paritytech/polkadot-sdk#25 --------- Co-authored-by:
ordian <write@reusable.software>
-
- Sep 18, 2023
-
-
georgepisaltu authored
Partially fixes #103 This PR removes instances of "free for all" collation in the `glutton`, `shell`, and `seedling` runtimes and replaces them with Aura instances. Aura is configured without a session manager, so the initial authority set cannot be changed later on. --------- Signed-off-by:georgepisaltu <george.pisaltu@parity.io>
-
- Aug 30, 2023
-
-
Przemek Rzad authored* Add missing Cumulus licenses * Typo * Add missing Substrate licenses * Single job checking the sub-repos in steps * Remove dates * Remove dates * Add missing (C) * Update FRAME UI tests Signed-off-by:
-
- Aug 23, 2023
-
-
juangirini authored
* restructure macro related exports * restructure macro related exports * wip * wip * update cargo lock * refactor RuntimeDebug on unincluded segment * fmt * Companion: restructure `benchmarking` macro related exports (#3039) * wip * wip * restructure benchmarking macro related exports * add cargo lock --------- Co-authored-by: parity-processbot <>
-
- Aug 22, 2023
-
-
Egor_P authored
* Bump crate versions * Bump spec_version
-
- Aug 18, 2023
-
-
Chris Sosnin authored
* Update substrate & polkadot * min changes to make async backing compile * (async backing) parachain-system: track limitations for unincluded blocks (#2438) * unincluded segment draft * read para head from storage proof * read_para_head -> read_included_para_head * Provide pub interface * add errors * fix unincluded segment update * BlockTracker -> Ancestor * add a dmp limit * Read para head depending on the storage switch * doc comments * storage items docs * add a sanity check on block initialize * Check watermark * append to the segment on block finalize * Move segment update into set_validation_data * Resolve para head todo * option watermark * fix comment * Drop dmq check * fix weight * doc-comments on inherent invariant * Remove TODO * add todo * primitives tests * pallet tests * doc comments * refactor unincluded segment length into a ConsensusHook (#2501) * refactor unincluded segment length into a ConsensusHook * add docs * refactor bandwidth_out calculation Co-authored-by:
Chris Sosnin <48099298+slumber@users.noreply.github.com> * test for limits from impl * fmt * make tests compile * update comment * uncomment test * fix collator test by adding parent to state proof * patch HRMP watermark rules for unincluded segment * get consensus-common tests to pass, using unincluded segment * fix unincluded segment tests * get all tests passing * fmt * rustdoc CI * aura-ext: limit the number of authored blocks per slot (#2551) * aura_ext consensus hook * reverse dependency * include weight into hook * fix tests * remove stray println Co-authored-by:
Chris Sosnin <chris125_@live.com> * parachain-system: ignore go ahead signal once upgrade is processed (#2594) * handle goahead signal for unincluded segment * doc comment * add test * parachain-system: drop processed messages from inherent data (#2590) * implement `drop_processed_messages` * drop messages based on relay parent number * adjust tests * drop changes to mqc * fix comment * drop test * drop more dead code * clippy * aura-ext: check slot in consensus hook and remove all `CheckInherents` logic (#2658) * aura-ext: check slot in consensus hook * convert relay chain slot * Make relay chain slot duration generic * use fixed velocity hook for pallets with aura * purge timestamp inherent * fix warning * adjust runtime tests * fix slots in tests * Make `xcm-emulator` test pass for new consensus hook (#2722) * add pallets on_initialize * tests pass * add AuraExt on_init * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: command-bot <> --------- Co-authored-by:
Ignacio Palacios <ignacio.palacios.santos@gmail.com> * update polkadot git refs * CollationGenerationConfig closure is now optional (#2772) * CollationGenerationConfig closure is now optional * fix test * propagate network-protocol-staging feature (#2899) * Feature Flagging Consensus Hook Type Parameter (#2911) * First pass * fmt * Added as default feature in tomls * Changed to direct dependency feature * Dealing with clippy error * Update pallets/parachain-system/src/lib.rs Co-authored-by:
asynchronous rob <rphmeier@gmail.com> --------- Co-authored-by:
Marcin S. <marcin@bytedude.com> * (async backing) restore `CheckInherents` for backwards-compatibility (#2977) * bring back timestamp * Restore CheckInherents * revert to empty CheckInherents * make CheckInherents optional * attempt * properly end system blocks * add some more comments * ignore failing system parachain tests * update refs after main feature branch merge * comment out the offending tests because CI runs ignored tests * fix warnings * fmt * revert to polkadot master * cargo update -p polkadot-primitives -p sp-io --------- Co-authored-by:
Bradley Olson <34992650+BradleyOlson64@users.noreply.github.com> Co-authored-by:
eskimor <eskimor@users.noreply.github.com> Co-authored-by:
-
- Aug 16, 2023
-
-
Squirrel authored
* diff minimisation between runtimes * another nit * Update parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs Co-authored-by:
-
- Jul 14, 2023
-
-
juangirini authored
* replace Index for Nonce * update lockfile for {"substrate", "polkadot"} --------- Co-authored-by: parity-processbot <>
-
- Jul 13, 2023
-
-
gupnik authored
Moves `Block` to `frame_system` instead of `construct_runtime` and removes `Header` and `BlockNumber` (#2790) * Fixes * Removes unused import * Uses Block and removes BlockNumber/Header from Chain * Fixes bridges * Fixes * Removes unused import * Fixes build * Uses correct RelayBlock * Minor fix * Fixes glutton-kusama * Uses correct RelayBlock * Minor fix * Fixes benchmark for pallet-bridge-parachains * Adds appropriate constraints * Minor fixes * Removes unused import * Fixes integrity tests * Minor fixes * Updates trait bounds * Uses custom bound for AsPrimitive * Fixes trait bounds * Revert "Fixes trait bounds" This reverts commit 0b0f42f583f3a616a88afe45fcd06d31e7d9a06f. * Revert "Uses custom bound for AsPrimitive" This reverts commit 838e5281adf8b6e9632a2abb9cd550db4ae24126. * No AsPrimitive trait bound for now * Removes bounds on Number * update lockfile for {"substrate", "polkadot"} * Formatting * ".git/.scripts/commands/fmt/fmt.sh" * Minor fix --------- Co-authored-by: parity-processbot <>
-
- Jul 12, 2023
-
-
Michal Kucharczyk authored
* GenesisBuild<T,I> deprecated. BuildGenesisConfig added * ".git/.scripts/commands/fmt/fmt.sh" * integration-tests/emulated: ..Default::default added to genesis configs * Cargo.lock updated * Cargo.lock updated * update lockfile for {"polkadot", "substrate"} * clippy fixes * clippy fixes * clippy fixes again --------- Co-authored-by: command-bot <>
-
- Jun 23, 2023
-
-
Branislav Kontur authored
* Temporary fix for frame_system::set_code benchmark * Removed temprary fix * BenchmarkHelper for frame-system (TODO: add stuff for ParachainSystem OnSetCode) * BenchmarkHelper for frame-system (TODO: add stuff for ParachainSystem OnSetCode) * Glutton * Fix benchmarks for `set_code` * Changed dummy values to non-zero * update lockfile for {"polkadot", "substrate"} --------- Co-authored-by: parity-processbot <>
-
- Jun 08, 2023
-
-
Ignacio Palacios authored
-
- May 31, 2023
-
-
Ignacio Palacios authored
* add correct sign extensions * remove warnings
-
- May 23, 2023
-
-
Ignacio Palacios authored
* sudo + genesis for glutton * ".git/.scripts/commands/fmt/fmt.sh" * add AdminOrigin to glutton * ".git/.scripts/commands/fmt/fmt.sh" * update Cargo.lock --------- Co-authored-by: command-bot <>
-
- May 17, 2023
-
-
Sergej Sakac authored
* Glutton Parachain * implement collator stuff * add glutton * implement missing api calls * small changes * use shell-runtime as starting point * update docs * Glutton chain configurations * successfully build * add local chain config * chain spec * update Cargo.lock * Update parachains/runtimes/glutton/glutton-kusama/src/lib.rs Co-authored-by:
-
- May 06, 2023
-
-
Oliver Tale-Yazdi authored
* Import Clippy config from Polkadot Signed-off-by:
Bastian Köcher <git@kchr.de> * Update client/pov-recovery/src/lib.rs Co-authored-by:
Chevdor <chevdor@users.noreply.github.com> * Revert revert
💩 Should be fine to use matches! macro since it is an explicit whitelist, not wildcard matching. --------- Signed-off-by:alvicsam <alvicsam@gmail.com> Co-authored-by:
-
- Mar 15, 2023
-
-
Alexandru Vasile authored
* parachains: Adjust `sp_api::Metadata` to the new API Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io> * parachains: Implement new Metadata trait for bridge/polkadot Signed-off-by:
-
- Jan 11, 2023
-
-
s0me0ne-unkn0wn authored
* Use primitives reexported from `polkadot_primitives` crate root * restart CI * Fixes after merge * update lockfile for {"polkadot", "substrate"} Co-authored-by: parity-processbot <>
-
- Dec 08, 2022
-
-
Keith Yeung authored
* Replace WEIGHT_PER_* with WEIGHT_REF_TIME_PER_* * Fixes * Fixes * update lockfile for {"substrate", "polkadot"} Co-authored-by: parity-processbot <>
-
- Oct 05, 2022
-
-
Chevdor authored
-
- Oct 03, 2022
-
-
Alexander Theißen authored
* Remove contracts RPC * update lockfile for {"polkadot", "substrate"} * Remove unused imports * Properly set a max proof size for cumulus test runtime * Properly set a max proof size for common runtimes * Properly set the max proof size for all runtimes Co-authored-by: parity-processbot <> Co-authored-by:Keith Yeung <kungfukeith11@gmail.com>
-
- Sep 20, 2022
-
-
Sergej Sakac authored
* Rename Origin * more renaming * fixes * fix errors * last fix? * rename * Update mock.rs * update lockfile for {"polkadot", "substrate"} Co-authored-by:Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: parity-processbot <>
-
- Sep 14, 2022
-
-
Keith Yeung authored
* Remove CanAuthorWith trait CanAuthotWith trait removed. Also all dependencies, parameters, type paramers were removed. This is related to removal of native runtime. * Companion for paritytech/substrate#12219 * Fixes * polkadot-runtime-common updated cargo update -p polkadot-runtime-common * warning fixed * Update cid * update lockfile for {"polkadot", "substrate"} * Update substrate * update lockfile for {"polkadot", "substrate"} * Update polkadot * Fix tests *🤦 Co-authored-by:Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com> Co-authored-by: parity-processbot <> Co-authored-by:
Bastian Köcher <info@kchr.de>
-
- Sep 12, 2022
-
-
Sergej Sakac authored
* Companion for #11981 * rename * Event to RuntimeEvent in imports * missed rename * undo * revert * rename type Call & Event * commit * ... * fix * fix errors * fixes * fmt * fix imports * final fix? * fmt * fix? * fixes after merge * small fix * cargo update -p polkadot-runtime-common * cargo +nightly fmt * update lockfile for {"polkadot", "substrate"} * fix Co-authored-by:
-
- Sep 01, 2022
-
-
Shawn Tabrizi authored
* fixes * oopsie * [ci] Apply cargo-fmt * fixes * [ci] Apply cargo-fmt * fixes * fix cumulus template * fix merge * update lockfile for {"polkadot", "substrate"} Co-authored-by:paritytech-ci <paritytech-ci@parity.io> Co-authored-by: parity-processbot <>
-
- Aug 31, 2022
-
-
Shawn Tabrizi authored
* cargo test -p cumulus-primitives-utility * cargo test -p cumulus-pallet-xcmp-queue * cargo test -p cumulus-pallet-xcm * cargo test -p cumulus-pallet-dmp-queue * cargo test -p pallet-template * cargo test -p cumulus-test-runtime * fix weights * fix more weights * cargo test -p parachains-common * cargo test -p parachain-template-runtime * fix weights import * cargo test -p collectives-polkadot-runtime * cargo test -p contracts-rococo-runtime * more * unused * fixes * Update benchmarking.rs * Update lib.rs * Update lib.rs * fix * fix bug in conversion * update lockfile for {"polkadot", "substrate"} Co-authored-by: parity-processbot <>
-
- Aug 16, 2022
-
-
Branislav Kontur authored
* Clean misleading imports `rococo_parachain_runtime::{AccountId, AuraId}` * Remove dependance on `rococo_parachain_runtime` for unrelated stuff * fmt + rebase fix * Addressing review comments * Addressing review comments * Fix for `purge_chain_works` works now with `rococo-local` and purge command needs to allow `rococo-native`
-
- Jun 05, 2022
-
-
Bastian Köcher authored
* Ensure relay chain block number strictly increases This is a safeguard for when async backing is enabled on the relay chain and multiple parachain blocks per relay chain block are legal. We will need to later change this to support then multiple parachain blocks per relay chain block. * Make the check configurable * Fix compilation * Update pallets/parachain-system/src/lib.rs Co-authored-by:
André Silva <123550+andresilva@users.noreply.github.com> * Update pallets/parachain-system/src/lib.rs Co-authored-by:
-
- May 24, 2022
-
-
joe petrowski authored
* add docs to parachain runtimes * update and add top readme * clarify docs * review plus licenses * Update parachains/README.md * Update parachains/runtimes/assets/README.md Co-authored-by:
Bernhard Schuster <bernhard@ahoi.io> * Update parachains/runtimes/assets/README.md Co-authored-by:
-
- May 20, 2022
-
-
Squirrel authored
* rerame res to chain-specs * split polkadot-parachains dir * rename dir parachains-common to common Co-authored-by:
Wilfried Kopp <wilfried@parity.io> Co-authored-by:
-
- Mar 07, 2022
-
-
Gavin Wood authored
* Formatting * Add set_accept_ownership weight * Revert lock file * Fixes * Fixed * Revert lock * Fixes * Bump Substrate
-
- Feb 11, 2022
-
-
Keith Yeung authored
* Move XCM configurations out into its own module * Revert removal of the AccountNonceApi
-
- Jan 21, 2022
-
-
Keith Yeung authored
* Rename ParentIsDefault to ParentIsAllZeroes * Fixes * Create ParentAccounts for respective networks * Fixes * Use b"Parent" as the basis for generating parent AccountId * Fixes * Use preset parent account ID * update lockfile for {"polkadot"} Co-authored-by: parity-processbot <>
-
- Jan 14, 2022
-
-
Ignacio Palacios authored
* before adding seedling client side * seedling runtime compiles * create seedling spec script added * seedling node & BaseCallFilter fixes * update AllPalets * formatting * CallFilter + SignedExtra + AccountData fix * XCM removed * cleanup * solo-to-para pallet added & before testing * fix runtime upgrade method * soloToPara pallet + set header * clean up * clean up 2 * signed extension check sudo added * fmt + cleanup * Refac code and fixes * fmt * Update pallets/solo-to-para/src/lib.rs Co-authored-by:
Bastian Köcher <bkchr@users.noreply.github.com> * Update pallets/solo-to-para/src/lib.rs Co-authored-by:
Ricardo Rius <ricardo@parity.io> Co-authored-by:
Ricardo Rius <9488369+riusricardo@users.noreply.github.com> Co-authored-by:
-
- Jan 03, 2022
-
-
Bastian Köcher authored
* Adds an integration test for testing the migration * Fix the custom validation header use case
-
- Dec 24, 2021
-
-
cheme authored
* state-update4 branch * new ref * Update to latest. * update deps * switch to host state version * update * fmt * up * remove trie patch * remove patch * fmt * update * set state_versions in runtimes * state version from storage * state version from storage * seedling compat * restore lock * update lockfile for substrate * update lockfile for polkadot Co-authored-by: parity-processbot <>
-
