Skip to content
Unverified Commit efc2132f authored by Dastan's avatar Dastan Committed by GitHub
Browse files

migrations: `take()`should consume read and write operation weight (#4302)



#### Problem
`take()` consumes only 1 read worth of weight in
`single-block-migrations` example, while `take()`
[is](https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/support/src/storage/unhashed.rs#L63)
`get() + kill()`, i.e should be 1 read + 1 write. I think this could
mislead developers who follow this example to write their migrations

---------

Co-authored-by: default avatarBastian Köcher <[email protected]>
parent 5f31981d
Pipeline #474237 waiting for manual action with stages
in 1 hour, 11 minutes, and 4 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment