rpc: backpressured RPC server (bump jsonrpsee 0.20) (#1313)
This is a rather big change in jsonrpsee, the major things in this bump are: - Server backpressure (the subscription impls are modified to deal with that) - Allow custom error types / return types (remove jsonrpsee::core::Error and jsonrpee::core::CallError) - Bug fixes (graceful shutdown in particular not used by substrate anyway) - Less dependencies for the clients in particular - Return type requires Clone in method call responses - Moved to tokio channels - Async subscription API (not used in this PR) Major changes in this PR: - The subscriptions are now bounded and if subscription can't keep up with the server it is dropped - CLI: add parameter to configure the jsonrpc server bounded message buffer (default is 64) - Add our own subscription helper to deal with the unbounded streams in substrate The most important things in this PR to review is the added helpers functions in `substrate/client/rpc/src/utils.rs` and the rest is pretty much chore. Regarding the "bounded buffer limit" it may cause the server to handle the JSON-RPC calls slower than before. The message size limit is bounded by "--rpc-response-size" thus "by default 10MB * 64 = 640MB" but the subscription message size is not covered by this limit and could be capped as well. Hopefully the last release prior to 1.0, sorry in advance for a big PR Previous attempt: https://github.com/paritytech/substrate/pull/13992 Resolves https://github.com/paritytech/polkadot-sdk/issues/748, resolves https://github.com/paritytech/polkadot-sdk/issues/627
Showing
- Cargo.lock 98 additions, 65 deletionsCargo.lock
- cumulus/client/relay-chain-interface/Cargo.toml 1 addition, 1 deletioncumulus/client/relay-chain-interface/Cargo.toml
- cumulus/client/relay-chain-rpc-interface/Cargo.toml 1 addition, 1 deletioncumulus/client/relay-chain-rpc-interface/Cargo.toml
- cumulus/parachain-template/node/Cargo.toml 1 addition, 1 deletioncumulus/parachain-template/node/Cargo.toml
- cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs 4 additions, 10 deletions...chains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs
- cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs 4 additions, 10 deletions...hains/runtimes/assets/asset-hub-westend/src/xcm_config.rs
- cumulus/polkadot-parachain/Cargo.toml 1 addition, 1 deletioncumulus/polkadot-parachain/Cargo.toml
- cumulus/test/service/Cargo.toml 1 addition, 1 deletioncumulus/test/service/Cargo.toml
- cumulus/test/service/src/lib.rs 1 addition, 0 deletionscumulus/test/service/src/lib.rs
- docs/sdk/src/guides/your_first_pallet/mod.rs 1 addition, 1 deletiondocs/sdk/src/guides/your_first_pallet/mod.rs
- polkadot/node/test/service/src/lib.rs 1 addition, 0 deletionspolkadot/node/test/service/src/lib.rs
- polkadot/rpc/Cargo.toml 1 addition, 1 deletionpolkadot/rpc/Cargo.toml
- polkadot/xcm/procedural/src/v2.rs 1 addition, 1 deletionpolkadot/xcm/procedural/src/v2.rs
- polkadot/xcm/xcm-builder/src/matches_location.rs 3 additions, 10 deletionspolkadot/xcm/xcm-builder/src/matches_location.rs
- prdoc/pr_1313.prdoc 18 additions, 0 deletionsprdoc/pr_1313.prdoc
- substrate/bin/minimal/node/Cargo.toml 1 addition, 1 deletionsubstrate/bin/minimal/node/Cargo.toml
- substrate/bin/node-template/node/Cargo.toml 1 addition, 1 deletionsubstrate/bin/node-template/node/Cargo.toml
- substrate/bin/node/cli/Cargo.toml 1 addition, 1 deletionsubstrate/bin/node/cli/Cargo.toml
- substrate/bin/node/cli/benches/block_production.rs 1 addition, 0 deletionssubstrate/bin/node/cli/benches/block_production.rs
- substrate/bin/node/cli/benches/transaction_pool.rs 1 addition, 0 deletionssubstrate/bin/node/cli/benches/transaction_pool.rs
Please register or sign in to comment