Skip to content
Commit d48fc587 authored by Davide Galassi's avatar Davide Galassi Committed by GitHub
Browse files

Fix longest chain finalization target lookup (#13289)



* Finalization target should be chosed as some ancestor of SelectChain::best_chain

* More test assertions

* Improve docs

* Removed stale docs

* Rename 'target' to 'base' in lookup method

* Fix typo

* Apply suggestions from code review

Co-authored-by: default avatarAndré Silva <[email protected]>

* Rename 'target_hash' to 'base_hash' in 'SelectChain::finality_target()'

* Apply suggestions from code review

Co-authored-by: default avatarAnton <[email protected]>

* Docs improvement

* Doc fix

* Apply suggestions from code review

Co-authored-by: default avatarBastian Köcher <[email protected]>

* Apply more code suggestions

---------

Co-authored-by: default avatarAndré Silva <[email protected]>
Co-authored-by: default avatarAnton <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
parent 9a8bbbab
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment