Fix longest chain finalization target lookup (#13289)
* Finalization target should be chosed as some ancestor of SelectChain::best_chain * More test assertions * Improve docs * Removed stale docs * Rename 'target' to 'base' in lookup method * Fix typo * Apply suggestions from code review Co-authored-by:André Silva <123550+andresilva@users.noreply.github.com> * Rename 'target_hash' to 'base_hash' in 'SelectChain::finality_target()' * Apply suggestions from code review Co-authored-by:
Anton <anton.kalyaev@gmail.com> * Docs improvement * Doc fix * Apply suggestions from code review Co-authored-by:
Bastian Köcher <git@kchr.de> * Apply more code suggestions --------- Co-authored-by:
André Silva <123550+andresilva@users.noreply.github.com> Co-authored-by:
Anton <anton.kalyaev@gmail.com> Co-authored-by:
Bastian Köcher <git@kchr.de>
Showing
- substrate/client/consensus/common/src/longest_chain.rs 69 additions, 11 deletionssubstrate/client/consensus/common/src/longest_chain.rs
- substrate/client/finality-grandpa/src/tests.rs 1 addition, 1 deletionsubstrate/client/finality-grandpa/src/tests.rs
- substrate/client/service/test/src/client/mod.rs 153 additions, 64 deletionssubstrate/client/service/test/src/client/mod.rs
- substrate/primitives/blockchain/src/backend.rs 15 additions, 69 deletionssubstrate/primitives/blockchain/src/backend.rs
- substrate/primitives/consensus/common/src/select_chain.rs 4 additions, 4 deletionssubstrate/primitives/consensus/common/src/select_chain.rs
Please register or sign in to comment