Skip to content
Unverified Commit d1fafa85 authored by PG Herveou's avatar PG Herveou Committed by GitHub
Browse files

[pallet-revive] eth-prc fix geth diff (#6608)



* Add a bunch of differential tests to ensure that responses from
eth-rpc matches the one from `geth`
- These
[tests](https://github.com/paritytech/polkadot-sdk/blob/pg/fix-geth-diff/substrate/frame/revive/rpc/examples/js/src/geth-diff.test.ts)
are not run in CI for now but can be run locally with
```bash
cd revive/rpc/examples/js
bun test
```

* EVM RPC server will not fail gas_estimation if no gas is specified, I
updated pallet-revive to add an extra `skip_transfer` boolean check to
replicate this behavior in our pallet

* `eth_transact` and `bare_eth_transact` api have been updated to use
`GenericTransaction` directly as this is what is used by
`eth_estimateGas` and `eth_call`

## TODO

- [ ]  Add tests the new `skip_transfer` flag

---------

Co-authored-by: default avatarGitHub Action <[email protected]>
Co-authored-by: default avatarAlexander Theißen <[email protected]>
parent 5e0bcb0e
Pipeline #507732 waiting for manual action with stages
in 29 minutes and 43 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment