Skip to content
Snippets Groups Projects
Commit cddd5749 authored by Andrei Sandu's avatar Andrei Sandu Committed by GitHub
Browse files

Malus: improvements in `dispute ancestor` and `suggest garbage candidate` implementation (#5011)


* Implement fake validation results

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* refactor

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* cargo lock

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* spell check

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* spellcheck

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* typos

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Review feedback

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* move stuff around

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* chores

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Impl valid - still wip

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* fixes

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* fmt

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Pull Ladi's implementation:
https://github.com/paritytech/polkadot/pull/4711

Co-authored-by: default avatarLldenaurois <Ljdenaurois@gmail.com>
Co-authored-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Fix build

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Logs and comments

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* WIP: suggest garbage candidate + implement validation result caching

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* fix

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Do commitment hash checks in candidate validation

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Minor refactor in approval, backing, dispute-coord

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Working version of suggest garbage candidate

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Dedup

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* cleanup #1

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Fix tests

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* remove debug leftovers

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* fmt

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Accidentally commited some local test

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* spellcheck

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* some more fixes

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Refactor and fix it

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* review feedback

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* typo

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* tests review feedback

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* refactor disputer

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* fix tests

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Fix zombienet disputes test

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* spellcheck

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* fix

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Fix ui tests

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* fix typo

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

Co-authored-by: default avatarLldenaurois <Ljdenaurois@gmail.com>
parent a46237ce
Branches
No related merge requests found
Showing
with 890 additions and 470 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment