Malus: improvements in `dispute ancestor` and `suggest garbage candidate` implementation (#5011)

* Implement fake validation results

Signed-off-by: Andrei Sandu <[email protected]>

* refactor

Signed-off-by: Andrei Sandu <[email protected]>

* cargo lock

Signed-off-by: Andrei Sandu <[email protected]>

* spell check

Signed-off-by: Andrei Sandu <[email protected]>

* spellcheck

Signed-off-by: Andrei Sandu <[email protected]>

* typos

Signed-off-by: Andrei Sandu <[email protected]>

* Review feedback

Signed-off-by: Andrei Sandu <[email protected]>

* move stuff around

Signed-off-by: Andrei Sandu <[email protected]>

* chores

Signed-off-by: Andrei Sandu <[email protected]>

* Impl valid - still wip

Signed-off-by: Andrei Sandu <[email protected]>

* fixes

Signed-off-by: Andrei Sandu <[email protected]>

* fmt

Signed-off-by: Andrei Sandu <[email protected]>

* Pull Ladi's implementation:
https://github.com/paritytech/polkadot/pull/4711



Co-authored-by: Lldenaurois <[email protected]>
Co-authored-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>

* Fix build

Signed-off-by: Andrei Sandu <[email protected]>

* Logs and comments

Signed-off-by: Andrei Sandu <[email protected]>

* WIP: suggest garbage candidate + implement validation result caching

Signed-off-by: Andrei Sandu <[email protected]>

* fix

Signed-off-by: Andrei Sandu <[email protected]>

* Do commitment hash checks in candidate validation

Signed-off-by: Andrei Sandu <[email protected]>

* Minor refactor in approval, backing, dispute-coord

Signed-off-by: Andrei Sandu <[email protected]>

* Working version of suggest garbage candidate

Signed-off-by: Andrei Sandu <[email protected]>

* Dedup

Signed-off-by: Andrei Sandu <[email protected]>

* cleanup #1

Signed-off-by: Andrei Sandu <[email protected]>

* Fix tests

Signed-off-by: Andrei Sandu <[email protected]>

* remove debug leftovers

Signed-off-by: Andrei Sandu <[email protected]>

* fmt

Signed-off-by: Andrei Sandu <[email protected]>

* Accidentally commited some local test

Signed-off-by: Andrei Sandu <[email protected]>

* spellcheck

Signed-off-by: Andrei Sandu <[email protected]>

* some more fixes

Signed-off-by: Andrei Sandu <[email protected]>

* Refactor and fix it

Signed-off-by: Andrei Sandu <[email protected]>

* review feedback

Signed-off-by: Andrei Sandu <[email protected]>

* typo

Signed-off-by: Andrei Sandu <[email protected]>

* tests review feedback

Signed-off-by: Andrei Sandu <[email protected]>

* refactor disputer

Signed-off-by: Andrei Sandu <[email protected]>

* fix tests

Signed-off-by: Andrei Sandu <[email protected]>

* Fix zombienet disputes test

Signed-off-by: Andrei Sandu <[email protected]>

* spellcheck

Signed-off-by: Andrei Sandu <[email protected]>

* fix

Signed-off-by: Andrei Sandu <[email protected]>

* Fix ui tests

Signed-off-by: Andrei Sandu <[email protected]>

* fix typo

Signed-off-by: Andrei Sandu <[email protected]>

Co-authored-by: Lldenaurois <[email protected]>