Skip to content
Snippets Groups Projects
Unverified Commit bb792af2 authored by Gavin Wood's avatar Gavin Wood Committed by GitHub
Browse files

Preimage: Check that at least one is upgraded (#1648)

Sanity check.
parent 1517eb8d
No related merge requests found
Pipeline #392497 passed with stages
in 50 minutes and 14 seconds
......@@ -216,7 +216,7 @@ benchmarks! {
}
ensure_updated {
let n in 0..MAX_HASH_UPGRADE_BULK_COUNT;
let n in 1..MAX_HASH_UPGRADE_BULK_COUNT;
let caller = funded_account::<T>();
let hashes = (0..n).map(|i| insert_old_unrequested::<T>(i)).collect::<Vec<_>>();
......
......@@ -156,6 +156,8 @@ pub mod pallet {
NotRequested,
/// More than `MAX_HASH_UPGRADE_BULK_COUNT` hashes were requested to be upgraded at once.
TooMany,
/// Too few hashes were requested to be upgraded (i.e. zero).
TooFew,
}
/// A reason for this pallet placing a hold on funds.
......@@ -242,6 +244,7 @@ pub mod pallet {
hashes: Vec<T::Hash>,
) -> DispatchResultWithPostInfo {
ensure_signed(origin)?;
ensure!(hashes.len() > 0, Error::<T>::TooFew);
ensure!(hashes.len() <= MAX_HASH_UPGRADE_BULK_COUNT as usize, Error::<T>::TooMany);
let updated = hashes.iter().map(Self::do_ensure_updated).filter(|b| *b).count() as u32;
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment