Unverified Commit b4dfad83 authored by Andrei Sandu's avatar Andrei Sandu Committed by GitHub
Browse files

approval-distribution: aggresion must target unfinalized chain rather than unapproved chain (#2988)



Found the issue while investigating the recent finality stall on Westend
after upgrading to 1.6.0. Approval distribution aggression is supposed
to trade off bandwidth and re-send assignemnts/approvals until enough
approvals are be received by at least 2/3 validators. This is supposed
to be a catch all mechanism when network connectivity goes south or many
validators reboot at the same time.

This fix ensures that we always resend approvals starting with the first
unfinalized block even in the case when it appears approved from the
node's perspective.

TODO:
- [x] Versi test

---------

Signed-off-by: default avatarAndrei Sandu <[email protected]>
parent 8eeacff4
Pipeline #437401 failed with stages
in 1 hour, 1 minute, and 28 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment