Append overlay optimization. (#1223)
This branch propose to avoid clones in append by storing offset and size in previous overlay depth. That way on rollback we can just truncate and change size of existing value. To avoid copy it also means that : - append on new overlay layer if there is an existing value: create a new Append entry with previous offsets, and take memory of previous overlay value. - rollback on append: restore value by applying offsets and put it back in previous overlay value - commit on append: appended value overwrite previous value (is an empty vec as the memory was taken). offsets of commited layer are dropped, if there is offset in previous overlay layer they are maintained. - set value (or remove) when append offsets are present: current appended value is moved back to previous overlay value with offset applied and current empty entry is overwrite (no offsets kept). The modify mechanism is not needed anymore. This branch lacks testing and break some existing genericity (bit of duplicated code), but good to have to check direction. Generally I am not sure if it is worth or we just should favor differents directions (transients blob storage for instance), as the current append mechanism is a bit tricky (having a variable length in first position means we sometime need to insert in front of a vector). Fix #30. --------- Signed-off-by:Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by:
EgorPopelyaev <egor@parity.io> Co-authored-by:
Alexandru Vasile <60601340+lexnv@users.noreply.github.com> Co-authored-by:
Bastian Köcher <git@kchr.de> Co-authored-by:
Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by:
joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by:
Liam Aharon <liam.aharon@hotmail.com> Co-authored-by:
Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by:
Branislav Kontur <bkontur@gmail.com> Co-authored-by:
Bastian Köcher <info@kchr.de> Co-authored-by:
Sebastian Kunert <skunert49@gmail.com>
parent
96ab6869
Showing
- Cargo.lock 15 additions, 0 deletionsCargo.lock
- polkadot/node/core/pvf/common/src/executor_interface.rs 6 additions, 6 deletionspolkadot/node/core/pvf/common/src/executor_interface.rs
- prdoc/pr_1223.prdoc 13 additions, 0 deletionsprdoc/pr_1223.prdoc
- substrate/client/executor/src/integration_tests/mod.rs 4 additions, 4 deletionssubstrate/client/executor/src/integration_tests/mod.rs
- substrate/primitives/externalities/src/lib.rs 8 additions, 8 deletionssubstrate/primitives/externalities/src/lib.rs
- substrate/primitives/io/src/lib.rs 6 additions, 6 deletionssubstrate/primitives/io/src/lib.rs
- substrate/primitives/state-machine/Cargo.toml 3 additions, 0 deletionssubstrate/primitives/state-machine/Cargo.toml
- substrate/primitives/state-machine/fuzz/Cargo.toml 30 additions, 0 deletionssubstrate/primitives/state-machine/fuzz/Cargo.toml
- substrate/primitives/state-machine/fuzz/fuzz_targets/fuzz_append.rs 26 additions, 0 deletions...primitives/state-machine/fuzz/fuzz_targets/fuzz_append.rs
- substrate/primitives/state-machine/src/basic.rs 38 additions, 19 deletionssubstrate/primitives/state-machine/src/basic.rs
- substrate/primitives/state-machine/src/ext.rs 47 additions, 24 deletionssubstrate/primitives/state-machine/src/ext.rs
- substrate/primitives/state-machine/src/fuzzing.rs 319 additions, 0 deletionssubstrate/primitives/state-machine/src/fuzzing.rs
- substrate/primitives/state-machine/src/in_memory_backend.rs 1 addition, 0 deletionssubstrate/primitives/state-machine/src/in_memory_backend.rs
- substrate/primitives/state-machine/src/lib.rs 74 additions, 5 deletionssubstrate/primitives/state-machine/src/lib.rs
- substrate/primitives/state-machine/src/overlayed_changes/changeset.rs 658 additions, 86 deletions...imitives/state-machine/src/overlayed_changes/changeset.rs
- substrate/primitives/state-machine/src/overlayed_changes/mod.rs 78 additions, 52 deletions...ate/primitives/state-machine/src/overlayed_changes/mod.rs
- substrate/primitives/state-machine/src/overlayed_changes/offchain.rs 8 additions, 6 deletions...rimitives/state-machine/src/overlayed_changes/offchain.rs
- substrate/primitives/state-machine/src/read_only.rs 6 additions, 6 deletionssubstrate/primitives/state-machine/src/read_only.rs
- substrate/primitives/state-machine/src/testing.rs 10 additions, 6 deletionssubstrate/primitives/state-machine/src/testing.rs
- substrate/utils/frame/remote-externalities/src/lib.rs 2 additions, 2 deletionssubstrate/utils/frame/remote-externalities/src/lib.rs
Please register or sign in to comment