client/*: Treat protocol name as str and not [u8] (#6967)
* client/*: Treat protocol name as str and not [u8] Notification protocol names are in practice always valid utf8 strings. Instead of treating them as such in the type system, thus far they were casted to a [u8] at creation time. With this commit protocol names are instead treated as valid utf8 strings throughout the codebase and passed as `Cow<'static, str>` instead of `Cow<'static, [u8]>`. Among other things this eliminates the need for string casting when logging. * client/network: Don't allocate when protocol name is borrowed
Showing
- substrate/client/finality-grandpa/src/communication/mod.rs 1 addition, 1 deletionsubstrate/client/finality-grandpa/src/communication/mod.rs
- substrate/client/finality-grandpa/src/communication/tests.rs 1 addition, 1 deletionsubstrate/client/finality-grandpa/src/communication/tests.rs
- substrate/client/network-gossip/src/bridge.rs 5 additions, 5 deletionssubstrate/client/network-gossip/src/bridge.rs
- substrate/client/network-gossip/src/lib.rs 2 additions, 2 deletionssubstrate/client/network-gossip/src/lib.rs
- substrate/client/network-gossip/src/state_machine.rs 1 addition, 1 deletionsubstrate/client/network-gossip/src/state_machine.rs
- substrate/client/network/src/behaviour.rs 1 addition, 1 deletionsubstrate/client/network/src/behaviour.rs
- substrate/client/network/src/config.rs 1 addition, 1 deletionsubstrate/client/network/src/config.rs
- substrate/client/network/src/gossip/tests.rs 2 additions, 2 deletionssubstrate/client/network/src/gossip/tests.rs
- substrate/client/network/src/protocol.rs 17 additions, 15 deletionssubstrate/client/network/src/protocol.rs
- substrate/client/network/src/protocol/generic_proto/behaviour.rs 9 additions, 9 deletions...te/client/network/src/protocol/generic_proto/behaviour.rs
- substrate/client/network/src/protocol/generic_proto/handler/group.rs 10 additions, 10 deletions...lient/network/src/protocol/generic_proto/handler/group.rs
- substrate/client/network/src/protocol/generic_proto/handler/notif_in.rs 2 additions, 2 deletions...nt/network/src/protocol/generic_proto/handler/notif_in.rs
- substrate/client/network/src/protocol/generic_proto/handler/notif_out.rs 4 additions, 4 deletions...t/network/src/protocol/generic_proto/handler/notif_out.rs
- substrate/client/network/src/protocol/generic_proto/upgrade/notifications.rs 21 additions, 12 deletions...twork/src/protocol/generic_proto/upgrade/notifications.rs
- substrate/client/network/src/service.rs 6 additions, 6 deletionssubstrate/client/network/src/service.rs
- substrate/client/network/src/service/tests.rs 4 additions, 4 deletionssubstrate/client/network/src/service/tests.rs
Please register or sign in to comment