Split NetworkBridge and break cycles with Unbounded (#2736)
* overseer: pass messages directly between subsystems * test that message is held on to * Update node/overseer/src/lib.rs Co-authored-by:Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> * give every subsystem an unbounded sender too * remove metered_channel::name 1. we don't provide good names 2. these names are never used anywhere * unused mut * remove unnecessary &mut * subsystem unbounded_send * remove unused MaybeTimer We have channel size metrics that serve the same purpose better now and the implementation of message timing was pretty ugly. * remove comment * split up senders and receivers * update metrics * fix tests * fix test subsystem context * use SubsystemSender in jobs system now * refactor of awful jobs code * expose public `run` on JobSubsystem * update candidate backing to new jobs & use unbounded * bitfield signing * candidate-selection * provisioner * approval voting: send unbounded for assignment/approvals * async not needed * begin bridge split * split up network tasks into background worker * port over network bridge * Update node/network/bridge/src/lib.rs Co-authored-by:
Andronik Ordian <write@reusable.software> * rename ValidationWorkerNotifications Co-authored-by:
Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com> Co-authored-by:
Andronik Ordian <write@reusable.software>
Showing
- polkadot/Cargo.lock 3 additions, 0 deletionspolkadot/Cargo.lock
- polkadot/node/core/approval-voting/src/lib.rs 12 additions, 10 deletionspolkadot/node/core/approval-voting/src/lib.rs
- polkadot/node/core/backing/src/lib.rs 146 additions, 145 deletionspolkadot/node/core/backing/src/lib.rs
- polkadot/node/core/bitfield-signing/Cargo.toml 3 additions, 0 deletionspolkadot/node/core/bitfield-signing/Cargo.toml
- polkadot/node/core/bitfield-signing/src/lib.rs 35 additions, 34 deletionspolkadot/node/core/bitfield-signing/src/lib.rs
- polkadot/node/core/candidate-selection/Cargo.toml 1 addition, 0 deletionspolkadot/node/core/candidate-selection/Cargo.toml
- polkadot/node/core/candidate-selection/src/lib.rs 100 additions, 129 deletionspolkadot/node/core/candidate-selection/src/lib.rs
- polkadot/node/core/provisioner/Cargo.toml 1 addition, 0 deletionspolkadot/node/core/provisioner/Cargo.toml
- polkadot/node/core/provisioner/src/lib.rs 34 additions, 29 deletionspolkadot/node/core/provisioner/src/lib.rs
- polkadot/node/core/provisioner/src/tests.rs 17 additions, 34 deletionspolkadot/node/core/provisioner/src/tests.rs
- polkadot/node/network/bridge/Cargo.toml 1 addition, 1 deletionpolkadot/node/network/bridge/Cargo.toml
- polkadot/node/network/bridge/src/action.rs 0 additions, 223 deletionspolkadot/node/network/bridge/src/action.rs
- polkadot/node/network/bridge/src/lib.rs 574 additions, 344 deletionspolkadot/node/network/bridge/src/lib.rs
- polkadot/node/network/bridge/src/network.rs 1 addition, 1 deletionpolkadot/node/network/bridge/src/network.rs
- polkadot/node/subsystem-test-helpers/src/lib.rs 9 additions, 0 deletionspolkadot/node/subsystem-test-helpers/src/lib.rs
- polkadot/node/subsystem-util/src/lib.rs 218 additions, 360 deletionspolkadot/node/subsystem-util/src/lib.rs
Please register or sign in to comment