Skip to content
Snippets Groups Projects
Unverified Commit 8061c870 authored by Facundo Farall's avatar Facundo Farall Committed by GitHub
Browse files

fix: 🩹 Amend wasmtime precompiled PR review (#13)

* fix: :heavy_minus_sign: Remove use of `log` in favour of `tracing` in `sc-executor`

* fix: :rotating_light: Fix `node-cli` build for missing parameter added to `cmd.run()`

* fix: :adhesive_bandage: Fix doc for `wasmtime-precompiled` argument

* fix: :adhesive_bandage: Avoid looping through precompiles directory and search directly for filename

* docs: :bulb: Comment fixes and clarifying which WASM code is precompiled

* fix: :adhesive_bandage: Use configured hasher instead of blake2 always

* fix: :adhesive_bandage: Error out if chainspec does not contain `:code` storage element

* feat: :sparkles: Add parser to CLI path arguments to check that they are existing directories

* fix: :adhesive_bandage: Change `with_wasmtime_precompiled_path` to `with_optional_wasmtime_precompiled_path` to handle optional inside

* fix: :bulb: Improve doc comments

* fix: :adhesive_bandage: Write directly to file instead of creating it and then writing

* style: :art: Apply `cargo fmt`
parent 9e4abc7a
Branches
Showing
with 108 additions and 111 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment