Integrate litep2p into Polkadot SDK (#2944)
[litep2p](https://github.com/altonen/litep2p) is a libp2p-compatible P2P networking library. It supports all of the features of `rust-libp2p` that are currently being utilized by Polkadot SDK. Compared to `rust-libp2p`, `litep2p` has a quite different architecture which is why the new `litep2p` network backend is only able to use a little of the existing code in `sc-network`. The design has been mainly influenced by how we'd wish to structure our networking-related code in Polkadot SDK: independent higher-levels protocols directly communicating with the network over links that support bidirectional backpressure. A good example would be `NotificationHandle`/`RequestResponseHandle` abstractions which allow, e.g., `SyncingEngine` to directly communicate with peers to announce/request blocks. I've tried running `polkadot --network-backend litep2p` with a few different peer configurations and there is a noticeable reduction in networking CPU usage. For high load (`--out-peers 200`), networking CPU usage goes down from ~110% to ~30% (80 pp) and for normal load (`--out-peers 40`), the usage goes down from ~55% to ~18% (37 pp). These should not be taken as final numbers because: a) there are still some low-hanging optimization fruits, such as enabling [receive window auto-tuning](https://github.com/libp2p/rust-yamux/pull/176), integrating `Peerset` more closely with `litep2p` or improving memory usage of the WebSocket transport b) fixing bugs/instabilities that incorrectly cause `litep2p` to do less work will increase the networking CPU usage c) verification in a more diverse set of tests/conditions is needed Nevertheless, these numbers should give an early estimate for CPU usage of the new networking backend. This PR consists of three separate changes: * introduce a generic `PeerId` (wrapper around `Multihash`) so that we don't have use `NetworkService::PeerId` in every part of the code that uses a `PeerId` * introduce `NetworkBackend` trait, implement it for the libp2p network stack and make Polkadot SDK generic over `NetworkBackend` * implement `NetworkBackend` for litep2p The new library should be considered experimental which is why `rust-libp2p` will remain as the default option for the time being. This PR currently depends on the master branch of `litep2p` but I'll cut a new release for the library once all review comments have been addresses. --------- Signed-off-by:Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by:
Dmitry Markin <dmitry@markin.tech> Co-authored-by:
Alexandru Vasile <60601340+lexnv@users.noreply.github.com> Co-authored-by:
Alexandru Vasile <alexandru.vasile@parity.io>
Showing
- Cargo.lock 589 additions, 140 deletionsCargo.lock
- Cargo.toml 1 addition, 1 deletionCargo.toml
- cumulus/client/relay-chain-minimal-node/src/lib.rs 56 additions, 26 deletionscumulus/client/relay-chain-minimal-node/src/lib.rs
- cumulus/client/relay-chain-minimal-node/src/network.rs 34 additions, 37 deletionscumulus/client/relay-chain-minimal-node/src/network.rs
- cumulus/client/service/src/lib.rs 12 additions, 5 deletionscumulus/client/service/src/lib.rs
- cumulus/polkadot-parachain/src/command.rs 213 additions, 129 deletionscumulus/polkadot-parachain/src/command.rs
- cumulus/polkadot-parachain/src/service.rs 26 additions, 19 deletionscumulus/polkadot-parachain/src/service.rs
- cumulus/test/service/src/lib.rs 40 additions, 21 deletionscumulus/test/service/src/lib.rs
- cumulus/test/service/src/main.rs 38 additions, 12 deletionscumulus/test/service/src/main.rs
- polkadot/node/jaeger/Cargo.toml 1 addition, 0 deletionspolkadot/node/jaeger/Cargo.toml
- polkadot/node/jaeger/src/spans.rs 1 addition, 1 deletionpolkadot/node/jaeger/src/spans.rs
- polkadot/node/network/availability-distribution/src/tests/mod.rs 9 additions, 4 deletions...t/node/network/availability-distribution/src/tests/mod.rs
- polkadot/node/network/availability-distribution/src/tests/state.rs 1 addition, 1 deletion...node/network/availability-distribution/src/tests/state.rs
- polkadot/node/network/availability-recovery/src/tests.rs 5 additions, 2 deletionspolkadot/node/network/availability-recovery/src/tests.rs
- polkadot/node/network/bridge/src/network.rs 12 additions, 13 deletionspolkadot/node/network/bridge/src/network.rs
- polkadot/node/network/bridge/src/rx/tests.rs 2 additions, 2 deletionspolkadot/node/network/bridge/src/rx/tests.rs
- polkadot/node/network/collator-protocol/src/collator_side/tests/mod.rs 11 additions, 6 deletions.../network/collator-protocol/src/collator_side/tests/mod.rs
- polkadot/node/network/dispute-distribution/src/tests/mod.rs 6 additions, 3 deletionspolkadot/node/network/dispute-distribution/src/tests/mod.rs
- polkadot/node/network/protocol/Cargo.toml 2 additions, 0 deletionspolkadot/node/network/protocol/Cargo.toml
- polkadot/node/network/protocol/src/authority_discovery.rs 2 additions, 1 deletionpolkadot/node/network/protocol/src/authority_discovery.rs
Please register or sign in to comment