chainHead: Error on duplicate unpin hashes (#3313)
This PR addresses an issue where calling chainHead_unpin with duplicate hashes could lead to unintended side effects. This backports: https://github.com/paritytech/json-rpc-interface-spec/pull/135 While at it, have added a test to check that the global reference count is decremented only once on unpin. cc @paritytech/subxt-team --------- Signed-off-by:Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by:
Davide Galassi <davxy@datawok.net>
parent
5a50b8b8
Branches
Pipeline
#445075
failed
with stages
in
52 minutes and 9 seconds
Stage:
Stage:
Stage:
Stage:
Stage:
Stage:
Showing
- substrate/client/rpc-spec-v2/src/chain_head/chain_head.rs 2 additions, 0 deletionssubstrate/client/rpc-spec-v2/src/chain_head/chain_head.rs
- substrate/client/rpc-spec-v2/src/chain_head/error.rs 7 additions, 0 deletionssubstrate/client/rpc-spec-v2/src/chain_head/error.rs
- substrate/client/rpc-spec-v2/src/chain_head/subscription/error.rs 5 additions, 1 deletion...e/client/rpc-spec-v2/src/chain_head/subscription/error.rs
- substrate/client/rpc-spec-v2/src/chain_head/subscription/inner.rs 87 additions, 1 deletion...e/client/rpc-spec-v2/src/chain_head/subscription/inner.rs
- substrate/client/rpc-spec-v2/src/chain_head/tests.rs 102 additions, 0 deletionssubstrate/client/rpc-spec-v2/src/chain_head/tests.rs
Please register or sign in to comment