Skip to content
Snippets Groups Projects
Unverified Commit 7e7fe990 authored by Oliver Tale-Yazdi's avatar Oliver Tale-Yazdi Committed by GitHub
Browse files

[FRAME] Make MQ pallet re-entrancy safe (#2356) 


Closes https://github.com/paritytech/polkadot-sdk/issues/2319

Changes:
- Ensure that only `enqueue_message(s)` is callable from within the
message processor. This prevents messed up storage that can currently
happen when the pallet is called into recursively.
- Use `H256` instead of `[u8; 32]` for clearer API.

## Details

The re-entracy check is done with the `environmental` crate by adding a
`with_service_mutex(f)` function that runs the closure exclusively. This
works since the MQ pallet is not instantiable.

---------

Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: default avatarFrancisco Aguirre <franciscoaguirreperez@gmail.com>
parent 95c3ee10
Branches
No related merge requests found
Pipeline #423228 failed with stages
Stage:
    Stage:
      Stage:
        Stage:
          Stage:
            Stage:
              in 1 hour, 32 minutes, and 36 seconds
              Hide whitespace changes
              Inline Side-by-side
              Showing
              with 479 additions and 80 deletions
              0% or .
              You are about to add 0 people to the discussion. Proceed with caution.
              Finish editing this message first!
              Please register or to comment