Skip to content
Snippets Groups Projects
Unverified Commit 42e7d522 authored by paritytech-cmd-bot-polkadot-sdk[bot]'s avatar paritytech-cmd-bot-polkadot-sdk[bot] Committed by GitHub
Browse files

[stable2412] Backport #7504 (#7510)


Backport #7504 into `stable2412` from alexggh.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: default avatarAlexandru Gheorghe <49718502+alexggh@users.noreply.github.com>
parent fe83cac2
No related merge requests found
......@@ -18,7 +18,7 @@
pub use polkadot_node_primitives::NODE_VERSION;
use clap::Parser;
use clap::{ArgAction, Parser};
use std::path::PathBuf;
#[allow(missing_docs)]
......@@ -148,9 +148,9 @@ pub struct RunCmd {
/// Enable approval-voting message processing in parallel.
///
///**Dangerous!** This is an experimental feature and should not be used in production, unless
/// explicitly advised to.
#[arg(long)]
/// This is a flag used for gradually enabling approval-voting-parallel in production,
/// should not be used unless explicitly advised to. It will be removed in the future.
#[arg(long, default_value = "true", action=ArgAction::Set)]
pub enable_approval_voting_parallel: bool,
}
......
......@@ -759,13 +759,6 @@ pub fn new_full<
Some(backoff)
};
// Running approval voting in parallel is enabled by default on all networks except Polkadot
// unless explicitly enabled by the commandline option.
// This is meant to be temporary until we have enough confidence in the new system to enable it
// by default on all networks.
let enable_approval_voting_parallel =
!config.chain_spec.is_polkadot() || enable_approval_voting_parallel;
let disable_grandpa = config.disable_grandpa;
let name = config.network.node_name.clone();
......
title: Enable approval-voting-parallel by default on polkadot
doc:
- audience: Node Dev
description: |
Enable approval-voting-parallel by default on polkadot
crates:
- name: polkadot-service
bump: patch
- name: polkadot-cli
bump: patch
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment