fix regression in approval-voting introduced in #3747 (#3831)
Fixes #3826.
The docs on the `candidates` field of `BlockEntry` were incorrectly
stating that they are sorted by core index. The (incorrect) optimization
was introduced in #3747 based on this assumption. The actual ordering is
based on `CandidateIncluded` events ordering in the runtime. We revert
this optimization here.
- [x] verify the underlying issue
- [x] add a regression test
---------
Co-authored-by:
Bastian Köcher <git@kchr.de>
Showing
- polkadot/node/core/approval-voting/src/lib.rs 3 additions, 3 deletionspolkadot/node/core/approval-voting/src/lib.rs
- polkadot/node/core/approval-voting/src/persisted_entries.rs 1 addition, 1 deletionpolkadot/node/core/approval-voting/src/persisted_entries.rs
- polkadot/node/core/approval-voting/src/tests.rs 167 additions, 0 deletionspolkadot/node/core/approval-voting/src/tests.rs
Please register or sign in to comment