Skip to content
Unverified Commit 3fc5b826 authored by ordian's avatar ordian Committed by GitHub
Browse files

fix regression in approval-voting introduced in #3747 (#3831)



Fixes #3826.

The docs on the `candidates` field of `BlockEntry` were incorrectly
stating that they are sorted by core index. The (incorrect) optimization
was introduced in #3747 based on this assumption. The actual ordering is
based on `CandidateIncluded` events ordering in the runtime. We revert
this optimization here.

- [x] verify the underlying issue
- [x] add a regression test

---------

Co-authored-by: default avatarBastian Köcher <[email protected]>
parent ed907819
Pipeline #459484 passed with stages
in 36 minutes and 37 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment