Change assert(is_err()) to assert_noop to check state consistency on errors (#8587)
* Change is_err() asserts in tests to assert_noop to check state consistency fixes #8545 * Update frame/transaction-payment/src/lib.rs Co-authored-by:Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/contracts/src/exec.rs Co-authored-by:
Shawn Tabrizi <shawntabrizi@gmail.com> * Update frame/democracy/src/benchmarking.rs Co-authored-by:
Shawn Tabrizi <shawntabrizi@gmail.com> * Update frame/transaction-payment/src/lib.rs Co-authored-by:
Shawn Tabrizi <shawntabrizi@gmail.com> * Don't assert no-changing state. see: https://github.com/paritytech/substrate/pull/8587#issuecomment-817137906 * fix expected error * Fix non-extrinsic-call asserts Co-authored-by:
Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by:
Shawn Tabrizi <shawntabrizi@gmail.com>
parent
b9ed6e01
Showing
- substrate/frame/contracts/src/exec.rs 6 additions, 2 deletionssubstrate/frame/contracts/src/exec.rs
- substrate/frame/democracy/src/benchmarking.rs 16 additions, 7 deletionssubstrate/frame/democracy/src/benchmarking.rs
- substrate/frame/democracy/src/tests/decoders.rs 5 additions, 4 deletionssubstrate/frame/democracy/src/tests/decoders.rs
- substrate/frame/democracy/src/tests/external_proposing.rs 1 addition, 1 deletionsubstrate/frame/democracy/src/tests/external_proposing.rs
- substrate/frame/democracy/src/tests/public_proposals.rs 2 additions, 2 deletionssubstrate/frame/democracy/src/tests/public_proposals.rs
- substrate/frame/democracy/src/tests/voting.rs 2 additions, 2 deletionssubstrate/frame/democracy/src/tests/voting.rs
- substrate/frame/election-provider-multi-phase/src/unsigned.rs 7 additions, 7 deletions...trate/frame/election-provider-multi-phase/src/unsigned.rs
- substrate/frame/executive/src/lib.rs 4 additions, 2 deletionssubstrate/frame/executive/src/lib.rs
- substrate/frame/grandpa/src/tests.rs 34 additions, 13 deletionssubstrate/frame/grandpa/src/tests.rs
- substrate/frame/system/src/extensions/check_nonce.rs 16 additions, 6 deletionssubstrate/frame/system/src/extensions/check_nonce.rs
- substrate/frame/system/src/extensions/check_weight.rs 24 additions, 38 deletionssubstrate/frame/system/src/extensions/check_weight.rs
- substrate/frame/system/src/tests.rs 10 additions, 8 deletionssubstrate/frame/system/src/tests.rs
- substrate/frame/transaction-payment/src/lib.rs 15 additions, 23 deletionssubstrate/frame/transaction-payment/src/lib.rs
Please register or sign in to comment