Remove ValidateFromChainState (#5707)
# Description This PR removes the `CandidateValidationMessage::ValidateFromChainState`, which was previously used by backing, but is no longer relevant since initial async backing implementation https://github.com/paritytech/polkadot/pull/5557. Fixes https://github.com/paritytech/polkadot-sdk/issues/5643 ## Integration This change should not affect downstream projects since `ValidateFromChainState` was already unused. ## Review Notes - Removed all occurrences of `ValidateFromChainState`. - Moved utility functions, previously used in candidate validation tests and malus, exclusively to candidate validation tests as they are no longer used in malus. - Deleted the `polkadot_parachain_candidate_validation_validate_from_chain_state` metric from Prometheus. - Removed `Spawner` from `ReplaceValidationResult` in malus’ interceptors. - `fake_validation_error` was only used for `ValidateFromChainState` handling, while other cases directly used `InvalidCandidate::InvalidOutputs`. It has been replaced with `fake_validation_error`, with a fallback to `InvalidCandidate::InvalidOutputs`. - Updated overseer’s minimal example to replace `ValidateFromChainState` with `ValidateFromExhaustive`.
parent
8279d104
Branches
Pipeline
#499467
waiting for manual action
with stages
in
30 minutes and 24 seconds
Stage:
Stage:
Stage:
Stage:
Stage:
Stage:
Showing
- polkadot/node/core/candidate-validation/src/lib.rs 3 additions, 192 deletionspolkadot/node/core/candidate-validation/src/lib.rs
- polkadot/node/core/candidate-validation/src/metrics.rs 0 additions, 15 deletionspolkadot/node/core/candidate-validation/src/metrics.rs
- polkadot/node/core/candidate-validation/src/tests.rs 54 additions, 1 deletionpolkadot/node/core/candidate-validation/src/tests.rs
- polkadot/node/malus/src/variants/back_garbage_candidate.rs 0 additions, 2 deletionspolkadot/node/malus/src/variants/back_garbage_candidate.rs
- polkadot/node/malus/src/variants/common.rs 6 additions, 149 deletionspolkadot/node/malus/src/variants/common.rs
- polkadot/node/malus/src/variants/dispute_valid_candidates.rs 0 additions, 2 deletionspolkadot/node/malus/src/variants/dispute_valid_candidates.rs
- polkadot/node/malus/src/variants/suggest_garbage_candidate.rs 0 additions, 1 deletion...adot/node/malus/src/variants/suggest_garbage_candidate.rs
- polkadot/node/overseer/examples/minimal-example.rs 7 additions, 3 deletionspolkadot/node/overseer/examples/minimal-example.rs
- polkadot/node/overseer/src/tests.rs 8 additions, 4 deletionspolkadot/node/overseer/src/tests.rs
- polkadot/node/subsystem-types/src/messages.rs 0 additions, 22 deletionspolkadot/node/subsystem-types/src/messages.rs
- polkadot/roadmap/implementers-guide/src/types/overseer-protocol.md 0 additions, 16 deletions...roadmap/implementers-guide/src/types/overseer-protocol.md
- prdoc/pr_5707.prdoc 19 additions, 0 deletionsprdoc/pr_5707.prdoc
Please register or sign in to comment