remove Default from CandidateDescriptor (#4484)
* remove Default from CandidateHash * Apply suggestions from code review Co-authored-by:Andronik Ordian <write@reusable.software> * chore: fmt * remove backed candidate default * Partial migration away from CandidateReceipt::default * Remove more CandidateReceipt defaults * fmt * Mostly remove CommittedCandidateReceipt default usage * Remove CommittedCandidateReceipt * Remove more Defaults from polakdot primitives v1 + fmt * Remove more Default from polkadot primites v1 * WIP trying to get overseer example + tests to compile * feat: add primitives test helpers * reduce deps of helper * update primitive helpers * make candidate validation compile * fixup cargo lock * make av-store compile * fixup disputes coordinator tests * test: fixup backing * test: fixup approval voting * fixup bitfield signing * test: fixup runtime-api * test: fixup availability dist * foxi[ pverseer test] * remove some Defaults, remove bounds from `dummy` All `fn dummy` in primitives need to be removed anyways. This aids in the transition. * it's a test helper, so always use std * test: fixup parachains runtime tests Excluding benches. * fix keyring * fix paras runtime properly, no more default * Remove fn dummy() usage from approval voting * Move TestCandidateBuilder out of av store to test helpers * Make candidate validation tests pass * Make most dispute coirdinator tests pass * Make provisioner tests work * Make availability recovery tests work with test helpers * Update polkadot-collator-protocol tests * Update statement distribution tests * Update polkadot overseer examples and tests * Derive default for validation code so we don't break unrelated things * Make para runtime test pass (no bench) * Some more work * chore: cargo fmt * cargo fix * avoid some Default::default * fixup dispute coordinator test * remove unused crate deps * remove Default::default wherever possible, replace by dummy_* for the most part * chore: cargo fmt * Remove some warnings * Remove CommittedCandidateReceipt dummy * Remove CandidateReceipt dummy * Remove CandidateDescriptor dummy * Remove commented out code * Fix para runtime tests * chore: nightly * Some updates to the builder * Dynamically adjust mock head data size * Make dispute cooridinator tests work * Fix test candidate_backing_reorders_votes work * +nightly-2021-10-29 fmt * Spelling and remove a default use in builder * Various clean up * More small updates * fmt * More small updates * Doc comments for test helpers * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras_inherent.rs * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras_inherent.rs * Update lib.rs * review comments * fix warnings * fix test by using correct candidate receipt relay parent Co-authored-by:
Andronik Ordian <write@reusable.software> Co-authored-by:
emostov <32168567+emostov@users.noreply.github.com> Co-authored-by:
Parity Bot <admin@parity.io> Co-authored-by:
Gavin Wood <gavin@parity.io>
Showing
- polkadot/Cargo.lock 29 additions, 2 deletionspolkadot/Cargo.lock
- polkadot/Cargo.toml 1 addition, 0 deletionspolkadot/Cargo.toml
- polkadot/erasure-coding/fuzzer/src/round_trip.rs 1 addition, 1 deletionpolkadot/erasure-coding/fuzzer/src/round_trip.rs
- polkadot/erasure-coding/src/lib.rs 5 additions, 3 deletionspolkadot/erasure-coding/src/lib.rs
- polkadot/node/collation-generation/Cargo.toml 1 addition, 0 deletionspolkadot/node/collation-generation/Cargo.toml
- polkadot/node/collation-generation/src/tests.rs 13 additions, 12 deletionspolkadot/node/collation-generation/src/tests.rs
- polkadot/node/core/approval-voting/Cargo.toml 1 addition, 0 deletionspolkadot/node/core/approval-voting/Cargo.toml
- polkadot/node/core/approval-voting/src/approval_checking.rs 13 additions, 14 deletionspolkadot/node/core/approval-voting/src/approval_checking.rs
- polkadot/node/core/approval-voting/src/approval_db/v1/tests.rs 5 additions, 3 deletions...dot/node/core/approval-voting/src/approval_db/v1/tests.rs
- polkadot/node/core/approval-voting/src/criteria.rs 2 additions, 2 deletionspolkadot/node/core/approval-voting/src/criteria.rs
- polkadot/node/core/approval-voting/src/import.rs 6 additions, 5 deletionspolkadot/node/core/approval-voting/src/import.rs
- polkadot/node/core/approval-voting/src/tests.rs 15 additions, 12 deletionspolkadot/node/core/approval-voting/src/tests.rs
- polkadot/node/core/av-store/Cargo.toml 1 addition, 0 deletionspolkadot/node/core/av-store/Cargo.toml
- polkadot/node/core/av-store/src/tests.rs 3 additions, 24 deletionspolkadot/node/core/av-store/src/tests.rs
- polkadot/node/core/backing/Cargo.toml 1 addition, 0 deletionspolkadot/node/core/backing/Cargo.toml
- polkadot/node/core/backing/src/tests.rs 23 additions, 7 deletionspolkadot/node/core/backing/src/tests.rs
- polkadot/node/core/bitfield-signing/Cargo.toml 1 addition, 0 deletionspolkadot/node/core/bitfield-signing/Cargo.toml
- polkadot/node/core/bitfield-signing/src/tests.rs 2 additions, 1 deletionpolkadot/node/core/bitfield-signing/src/tests.rs
- polkadot/node/core/candidate-validation/Cargo.toml 1 addition, 0 deletionspolkadot/node/core/candidate-validation/Cargo.toml
- polkadot/node/core/candidate-validation/src/tests.rs 126 additions, 71 deletionspolkadot/node/core/candidate-validation/src/tests.rs
Please register or sign in to comment