Skip to content
Snippets Groups Projects
Commit 0e729f23 authored by Oliver Tale-Yazdi's avatar Oliver Tale-Yazdi Committed by GitHub
Browse files

Try-runtime CLI fix weight parsing (#12491)


Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
parent 532dd5ec
Branches
No related merge requests found
...@@ -11356,6 +11356,7 @@ dependencies = [ ...@@ -11356,6 +11356,7 @@ dependencies = [
"sp-runtime", "sp-runtime",
"sp-state-machine", "sp-state-machine",
"sp-version", "sp-version",
"sp-weights",
"tokio", "tokio",
"zstd", "zstd",
] ]
......
...@@ -31,6 +31,7 @@ sp-keystore = { version = "0.12.0", path = "../../../../primitives/keystore" } ...@@ -31,6 +31,7 @@ sp-keystore = { version = "0.12.0", path = "../../../../primitives/keystore" }
sp-runtime = { version = "6.0.0", path = "../../../../primitives/runtime" } sp-runtime = { version = "6.0.0", path = "../../../../primitives/runtime" }
sp-state-machine = { version = "0.12.0", path = "../../../../primitives/state-machine" } sp-state-machine = { version = "0.12.0", path = "../../../../primitives/state-machine" }
sp-version = { version = "5.0.0", path = "../../../../primitives/version" } sp-version = { version = "5.0.0", path = "../../../../primitives/version" }
sp-weights = { version = "4.0.0", path = "../../../../primitives/weights" }
frame-try-runtime = { path = "../../../../frame/try-runtime" } frame-try-runtime = { path = "../../../../frame/try-runtime" }
[dev-dependencies] [dev-dependencies]
......
...@@ -33,6 +33,7 @@ use sc_service::Configuration; ...@@ -33,6 +33,7 @@ use sc_service::Configuration;
use serde::de::DeserializeOwned; use serde::de::DeserializeOwned;
use sp_core::H256; use sp_core::H256;
use sp_runtime::traits::{Block as BlockT, Header as HeaderT, NumberFor}; use sp_runtime::traits::{Block as BlockT, Header as HeaderT, NumberFor};
use sp_weights::Weight;
use std::{collections::VecDeque, fmt::Debug, str::FromStr}; use std::{collections::VecDeque, fmt::Debug, str::FromStr};
const SUB: &str = "chain_subscribeFinalizedHeads"; const SUB: &str = "chain_subscribeFinalizedHeads";
...@@ -294,8 +295,8 @@ where ...@@ -294,8 +295,8 @@ where
full_extensions(), full_extensions(),
)?; )?;
let consumed_weight = <u64 as Decode>::decode(&mut &*encoded_result) let consumed_weight = <Weight as Decode>::decode(&mut &*encoded_result)
.map_err(|e| format!("failed to decode output: {:?}", e))?; .map_err(|e| format!("failed to decode weight: {:?}", e))?;
let storage_changes = changes let storage_changes = changes
.drain_storage_changes( .drain_storage_changes(
......
...@@ -21,6 +21,7 @@ use parity_scale_codec::Decode; ...@@ -21,6 +21,7 @@ use parity_scale_codec::Decode;
use sc_executor::NativeExecutionDispatch; use sc_executor::NativeExecutionDispatch;
use sc_service::Configuration; use sc_service::Configuration;
use sp_runtime::traits::{Block as BlockT, NumberFor}; use sp_runtime::traits::{Block as BlockT, NumberFor};
use sp_weights::Weight;
use crate::{ use crate::{
build_executor, ensure_matching_spec, extract_code, local_spec, state_machine_call_with_proof, build_executor, ensure_matching_spec, extract_code, local_spec, state_machine_call_with_proof,
...@@ -78,14 +79,15 @@ where ...@@ -78,14 +79,15 @@ where
Default::default(), // we don't really need any extensions here. Default::default(), // we don't really need any extensions here.
)?; )?;
let (weight, total_weight) = <(u64, u64) as Decode>::decode(&mut &*encoded_result) let (weight, total_weight) = <(Weight, Weight) as Decode>::decode(&mut &*encoded_result)
.map_err(|e| format!("failed to decode output: {:?}", e))?; .map_err(|e| format!("failed to decode weight: {:?}", e))?;
log::info!( log::info!(
target: LOG_TARGET, target: LOG_TARGET,
"TryRuntime_on_runtime_upgrade executed without errors. Consumed weight = {}, total weight = {} ({})", "TryRuntime_on_runtime_upgrade executed without errors. Consumed weight = ({} ps, {} byte), total weight = ({} ps, {} byte) ({:.2} %, {:.2} %).",
weight, weight.ref_time(), weight.proof_size(),
total_weight, total_weight.ref_time(), total_weight.proof_size(),
weight as f64 / total_weight.max(1) as f64 (weight.ref_time() as f64 / total_weight.ref_time().max(1) as f64) * 100.0,
(weight.proof_size() as f64 / total_weight.proof_size().max(1) as f64) * 100.0,
); );
Ok(()) Ok(())
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment