Storing multiple Justifications per block (#7640)
* primitives/runtime: initial changes on supporting multiple Justifications * primitives/runtime: make Justifications strongly typed * Encode/decode Justifications * primitives/runtime: add Justification type * backend: apply_finality and finalize_block takes a single Justification * manual-seal: create engine id and let rpc take encoded justification * backend: skeleton functions for appending justifications * backend: initial implementation append_justification Initial implementation of append_justification on the Backend trait, and also remove unused skeleton functions for append_justificaton on Finaziler trait. k * backend: guard against duplicate consensus engine id * client/db: add check for block finality * client/api: add append_justification to in_mem db * client/light: add no-op append_justification * network: fix decode call for Justification * network: only send a single Justification in BlockData * network: minor comment update * protocol: update field names to distinguish single justification * client: further field renames to plural * client: update function names to plural justifications * client/db: upgrade existing database for new format * network: remove dependency on grandpa crate * db: fix check for finalized block * grandpa: check for multiple grandpa justifications hwne importing * backend: update Finalizer trait to take multiple Justifications * db: remove debugging statements in migration code * manual-seal: update note about engine id * db: fix check for finalized block * client: update variable name to reflect it is now plural * grandpa: fix incorrect empty Justications in test * primitives: make Justifications opaque to avoid being empty * network: fix detecting empty Justification * runtime: doc strings for Justifications functions * runtime: add into_justifications * primitives: check for duplicates in when adding to Justifications * network/test: use real grandpa engine id in test * client: fix reviewer comments * primitives: rename Justifications::push to append * backend: revert changes to Finalizer trait * backend: revert mark_finalized * backend: revert changes to finalize_block * backend: revert finalized_blocks * db: add a quick early return for performance * client: minor reviewer comments * service/test: use local ConsensusEngineId * network: add link to issue for sending multiple Justifications * Apply suggestions from code review Co-authored-by:Pierre Krieger <pierre.krieger1708@gmail.com> * Apply suggestions from code review Co-authored-by:
Pierre Krieger <pierre.krieger1708@gmail.com> * network: tweaks to review suggestions * network: revert change to BlockData for backwards compatibility * Apply suggestion from code review Co-authored-by:
Pierre Krieger <pierre.krieger1708@gmail.com> * Apply suggestions from code review Co-authored-by:
André Silva <123550+andresilva@users.noreply.github.com> * primitives: update doc comment for Justifications * client/db/upgrade: avoid grandpa crate dependency * consensus: revert to single Justification for import_justification * primitives: improve justifications docs * style cleanups * use and_then * client: rename JUSTIFICATIONS db column * network: revert to using FRNK in network-test Co-authored-by:
Pierre Krieger <pierre.krieger1708@gmail.com> Co-authored-by:
André Silva <123550+andresilva@users.noreply.github.com> Co-authored-by:
André Silva <andrerfosilva@gmail.com>
Showing
- substrate/client/api/src/backend.rs 12 additions, 4 deletionssubstrate/client/api/src/backend.rs
- substrate/client/api/src/client.rs 3 additions, 3 deletionssubstrate/client/api/src/client.rs
- substrate/client/api/src/in_mem.rs 111 additions, 14 deletionssubstrate/client/api/src/in_mem.rs
- substrate/client/consensus/aura/src/import_queue.rs 3 additions, 3 deletionssubstrate/client/consensus/aura/src/import_queue.rs
- substrate/client/consensus/babe/src/lib.rs 5 additions, 5 deletionssubstrate/client/consensus/babe/src/lib.rs
- substrate/client/consensus/babe/src/tests.rs 2 additions, 2 deletionssubstrate/client/consensus/babe/src/tests.rs
- substrate/client/consensus/manual-seal/src/lib.rs 7 additions, 3 deletionssubstrate/client/consensus/manual-seal/src/lib.rs
- substrate/client/consensus/manual-seal/src/rpc.rs 4 additions, 4 deletionssubstrate/client/consensus/manual-seal/src/rpc.rs
- substrate/client/consensus/pow/src/lib.rs 3 additions, 3 deletionssubstrate/client/consensus/pow/src/lib.rs
- substrate/client/db/src/changes_tries_storage.rs 2 additions, 1 deletionsubstrate/client/db/src/changes_tries_storage.rs
- substrate/client/db/src/lib.rs 100 additions, 16 deletionssubstrate/client/db/src/lib.rs
- substrate/client/db/src/upgrade.rs 36 additions, 5 deletionssubstrate/client/db/src/upgrade.rs
- substrate/client/finality-grandpa-warp-sync/src/proof.rs 14 additions, 7 deletionssubstrate/client/finality-grandpa-warp-sync/src/proof.rs
- substrate/client/finality-grandpa/src/environment.rs 8 additions, 5 deletionssubstrate/client/finality-grandpa/src/environment.rs
- substrate/client/finality-grandpa/src/finality_proof.rs 41 additions, 52 deletionssubstrate/client/finality-grandpa/src/finality_proof.rs
- substrate/client/finality-grandpa/src/import.rs 14 additions, 5 deletionssubstrate/client/finality-grandpa/src/import.rs
- substrate/client/finality-grandpa/src/tests.rs 8 additions, 8 deletionssubstrate/client/finality-grandpa/src/tests.rs
- substrate/client/light/src/backend.rs 11 additions, 3 deletionssubstrate/client/light/src/backend.rs
- substrate/client/light/src/blockchain.rs 2 additions, 2 deletionssubstrate/client/light/src/blockchain.rs
- substrate/client/network/src/behaviour.rs 2 additions, 2 deletionssubstrate/client/network/src/behaviour.rs
Please register or sign in to comment