HoldReason: Improve usage (#13869)
* HoldReason: Improve usage `HoldReason` was switched recently to use the `composite_enum` attribute that will merge the enums from all pallets in the runtime to `RuntimeHoldReason`. `pallet-nis` was still requiring that the variant was passed as constant to call `hold`. The proper implementation is to use the `HoldReason` from inside the pallet directly when calling `hold`. This is done by adding a `RuntimeHoldReason` as type to the `Config` trait and requiring that `Currency` is using the same reason. Besides that the pr changes the name `HoldIdentifier` in `pallet_balances::Config` to `RuntimeHoldReason`. * Update frame/nis/src/lib.rs Co-authored-by:Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Review comment * Fixes --------- Co-authored-by:
Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Showing
- substrate/bin/node-template/runtime/src/lib.rs 1 addition, 1 deletionsubstrate/bin/node-template/runtime/src/lib.rs
- substrate/bin/node/runtime/src/lib.rs 3 additions, 17 deletionssubstrate/bin/node/runtime/src/lib.rs
- substrate/client/executor/benches/bench.rs 0 additions, 1 deletionsubstrate/client/executor/benches/bench.rs
- substrate/frame/alliance/src/mock.rs 1 addition, 1 deletionsubstrate/frame/alliance/src/mock.rs
- substrate/frame/asset-rate/src/mock.rs 1 addition, 1 deletionsubstrate/frame/asset-rate/src/mock.rs
- substrate/frame/assets/src/mock.rs 1 addition, 1 deletionsubstrate/frame/assets/src/mock.rs
- substrate/frame/atomic-swap/src/tests.rs 1 addition, 1 deletionsubstrate/frame/atomic-swap/src/tests.rs
- substrate/frame/babe/src/mock.rs 1 addition, 1 deletionsubstrate/frame/babe/src/mock.rs
- substrate/frame/balances/src/impl_fungible.rs 1 addition, 1 deletionsubstrate/frame/balances/src/impl_fungible.rs
- substrate/frame/balances/src/lib.rs 3 additions, 3 deletionssubstrate/frame/balances/src/lib.rs
- substrate/frame/balances/src/tests/mod.rs 1 addition, 1 deletionsubstrate/frame/balances/src/tests/mod.rs
- substrate/frame/beefy/src/mock.rs 1 addition, 1 deletionsubstrate/frame/beefy/src/mock.rs
- substrate/frame/bounties/src/tests.rs 1 addition, 1 deletionsubstrate/frame/bounties/src/tests.rs
- substrate/frame/child-bounties/src/tests.rs 1 addition, 1 deletionsubstrate/frame/child-bounties/src/tests.rs
- substrate/frame/contracts/src/tests.rs 1 addition, 1 deletionsubstrate/frame/contracts/src/tests.rs
- substrate/frame/conviction-voting/src/tests.rs 1 addition, 1 deletionsubstrate/frame/conviction-voting/src/tests.rs
- substrate/frame/democracy/src/tests.rs 1 addition, 1 deletionsubstrate/frame/democracy/src/tests.rs
- substrate/frame/election-provider-multi-phase/src/mock.rs 1 addition, 1 deletionsubstrate/frame/election-provider-multi-phase/src/mock.rs
- substrate/frame/election-provider-multi-phase/test-staking-e2e/src/mock.rs 1 addition, 1 deletion...lection-provider-multi-phase/test-staking-e2e/src/mock.rs
- substrate/frame/elections-phragmen/src/lib.rs 1 addition, 1 deletionsubstrate/frame/elections-phragmen/src/lib.rs
Please register or sign in to comment