pallet-migrations: fix index access for singluar migrations (#5695) (01364633) · Commits · parity / Mirrored projects / polkadot-sdk · GitLab

Snippets Groups Projects

Unverified Commit 01364633 authored 7 months ago by

Oliver Tale-Yazdi Committed by GitHub 7 months ago

pallet-migrations: fix index access for singluar migrations (#5695)


Discovered a bug in the migrations pallet while debugging
https://github.com/paritytech/try-runtime-cli/pull/90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>

parent b21da748

Branches gh-readonly-queue/master/pr-4304-d893cde2cfd1992a3e589614ae09088d92f28a59

Pipeline #496996 waiting for manual action with stages

in 42 minutes and 15 seconds

Hide whitespace changes

Inline Side-by-side

Showing with 50 additions and 6 deletions

Oliver Tale-Yazdi @ggwpez
mentioned in commit 8781c7ae
· 7 months ago

mentioned in commit 8781c7ae

mentioned in commit 8781c7ae69ab246a87bbfe09c6aea8945479bd94

Toggle commit list
Oliver Tale-Yazdi @ggwpez
mentioned in commit b539e903
· 7 months ago

mentioned in commit b539e903

mentioned in commit b539e903fc03323dfc9dc1732ee82010883ff07a

Toggle commit list

Please register or to comment