• Kian Paimani's avatar
    Revamp nomination pool reward scheme (#11669) · f8d4b999
    Kian Paimani authored
    
    
    * make pool roles optional
    
    * undo lock file changes?
    
    * add migration
    
    * add the ability for pools to chill themselves
    
    * boilerplate of tests
    
    * somewhat stable, but I think I found another bug as well
    
    * Fix it all
    
    * Add more more sophisticated test + capture one more bug.
    
    * Update frame/staking/src/lib.rs
    
    * reduce the diff a little bit
    
    * add some test for the slashing bug
    
    * cleanup
    
    * fix lock file?
    
    * Fix
    
    * fmt
    
    * Update frame/nomination-pools/src/lib.rs
    
    Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
    
    * Update frame/nomination-pools/src/lib.rs
    
    Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
    
    * Update frame/nomination-pools/src/lib.rs
    
    Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
    
    * Update frame/nomination-pools/src/mock.rs
    
    Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
    
    * Fix build
    
    * fix some fishy tests..
    
    * add one last integrity check for MinCreateBond
    
    * remove bad assertion -- needs to be dealt with later
    
    * nits
    
    * fix tests and add benchmarks for chill
    
    * remove stuff
    
    * fix benchmarks
    
    * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
    
    * remove defensive
    
    * first working version
    
    * bring back all tests
    
    * ALL new tests work now
    
    * cleanup
    
    * make sure benchmarks and all work
    
    * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
    
    * round of self-review, make arithmetic safe
    
    * fix warn
    
    * add migration code
    
    * Fix doc
    
    * add precision notes
    
    * make arithmetic fallible
    
    * fix node runtime
    
    * a lot of precision tests and notes and stuff
    
    * document MaxPOintsToBalance better
    
    * :round of self-review
    
    * fmt
    
    * fix some comments
    
    * Fix proportional slashing logic
    
    * Update frame/nomination-pools/src/tests.rs
    
    Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
    
    * Update frame/nomination-pools/src/tests.rs
    
    Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
    
    * Update frame/nomination-pools/src/lib.rs
    
    Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
    
    * track poinst in migration
    
    * fix
    
    * fmt
    
    * fix migration
    
    * remove event read
    
    * Apply suggestions from code review
    
    * Update frame/staking/src/lib.rs
    
    Co-authored-by: default avatarShawn Tabrizi <[email protected]>
    
    * Update frame/nomination-pools/src/lib.rs
    
    Co-authored-by: default avatarShawn Tabrizi <[email protected]>
    
    * Update frame/nomination-pools/src/lib.rs
    
    Co-authored-by: default avatarShawn Tabrizi <[email protected]>
    
    * update
    
    * fmt
    
    * fmt
    
    * add one last test
    
    * fmt
    
    Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
    Co-authored-by: default avatarShawn Tabrizi <[email protected]>
    Co-authored-by: default avatarParity Bot <[email protected]>
    f8d4b999