• Bastian Köcher's avatar
    validate-block: Fix `TrieCache` implementation (#2214) · 1bc08858
    Bastian Köcher authored
    The trie cache implementation was ignoring the `storage_root` when
    setting up the value cache. The problem with this is that the value
    cache works using `storage_keys` and these keys are not unique across
    different tries. A block can actually have different tries (main trie
    and multiple child tries). This pull request fixes the issue by not
    ignoring the `storage_root` and returning an unique `value_cache` per
    `storage_root`. It also adds a test for the seen bug and improves
    documentation that this doesn't happen again.
    1bc08858