Skip to content
Snippets Groups Projects
  • Alexandru Vasile's avatar
    rpc-v2/tx: Remove the broadcast event from `transaction_submitAndWatch` (#3321) · 1b624c50
    Alexandru Vasile authored
    
    This PR backports the changes from the rpc-v2 spec:
    https://github.com/paritytech/json-rpc-interface-spec/pull/134
    
    The `Broadcasted` event has been removed:
    - it is hard to enforce a `Dropped { broadcasted: bool }` event in cases
    of a load-balancer being placed in front of an RPC server
    - when the server exists, it is impossible to guarantee this field if
    the server did not previously send a `Broadcasted` event
    - the number of peers reported by this event does not guarantee that
    peers are unique
    - the same peer can disconnect and reconnect, increasing this metric
    number
    - the number of peers that receive this transaction offers no guarantee
    about the transaction being included in the chain at a later time
    
    
    cc @paritytech/subxt-team
    
    ---------
    
    Signed-off-by: default avatarAlexandru Vasile <alexandru.vasile@parity.io>
    Co-authored-by: default avatarJames Wilson <james@jsdw.me>
    Unverified
    1b624c50
Code owners
Assign users and groups as approvers for specific file changes. Learn more.