* generated_message_details() -> Simplifications

- avoid using a HashMap for `messages_to_refine`. It seems that a vec is
  enough
- minimize the number of conversions between `OutboundMessageDetails` and
  `MessageDetails`
- use references where possible in order to minimize the number of
  intermediary Vecs
- simplify `make_message_details_map()` logic, reduce its scope and rename
  it to `validate_out_msgs_details()`

Signed-off-by: Serban Iorga <[email protected]>

* Define typed_state_call()

Signed-off-by: Serban Iorga <[email protected]>

* Call To*InboundLaneApi::message_details() with single messages

Signed-off-by: Serban Iorga <[email protected]>

* Call To*InboundLaneApi::message_details() with batched messages

Signed-off-by: Serban Iorga <[email protected]>

* validate_out_msgs_details() -> change check

* Define split_msgs_to_refine()

Signed-off-by: Serban Iorga <[email protected]>

Signed-off-by: Serban Iorga <[email protected]>

* [Complex Relayers] Deduplicate l2r and r2l logic

Signed-off-by: Serban Iorga <[email protected]>

* Renamings

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

Serban Iorga authored Jul 28, 2022 and Serban Iorga committed Jul 28, 2022

Change Runtime APIs best_finalized() signature to return Option<HeaderId>

Signed-off-by: Serban Iorga <[email protected]>

Serban Iorga authored Jul 28, 2022 and Serban Iorga committed Jul 28, 2022

Signed-off-by: Serban Iorga <[email protected]>

Serban Iorga authored Jul 26, 2022 and Serban Iorga committed Jul 27, 2022

Log error when `best_parachain_block_at_target` can't be updated instead
of propagating it.

Signed-off-by: Serban Iorga <[email protected]>

Serban Iorga authored Jul 26, 2022 and Serban Iorga committed Jul 27, 2022

Signed-off-by: Serban Iorga <[email protected]>

Serban Iorga authored Jul 26, 2022 and Serban Iorga committed Jul 27, 2022

Signed-off-by: Serban Iorga <[email protected]>

Deduplicate the logic that validates the updated parachain heads.

Signed-off-by: Serban Iorga <[email protected]>

* Remove unused trait implementations

Signed-off-by: Serban Iorga <[email protected]>

* Define encoded_size_hint_u32()

Signed-off-by: Serban Iorga <[email protected]>

* Define TransactionEstimationParams trait

Signed-off-by: Serban Iorga <[email protected]>

* Rework TransactionEstimation

Signed-off-by: Serban Iorga <[email protected]>

* Docs + Renamings

Signed-off-by: Serban Iorga <[email protected]>

Define HeaderIdProvider trait

Signed-off-by: Serban Iorga <[email protected]>

* add another condition to the reject-obsolete-parachain-heads extension

* add tracing to obsolete-tx-extensions

* fix tests

* extension_rejects_header_from_new_relay_block_with_same_hash

* fmt

* fix benchmarks

* [CLI] Make bridge definitions more complete

* [CLI] Refactor relay_headers_and_messages

Signed-off-by: Serban Iorga <[email protected]>

* decrease parameters range in grandpa benchmarks

* fix messages benchmarks

* update all weights

* dealing with failed test (WiP)

* Revert "dealing with failed test (WiP)"

This reverts commit 0379d24b.

* proper tests fix

* remove Rococo<>Wococo bridge mentions

* remove Kusama <> Polkadot bridge mentions

* fmt

* remove unneeded mocked runtimes && trait impls for obsolete bridges

* remove unused deps

* draft: remove without_storage_info for messages pallet

* some cleanup

* parachain loop metrics

* some fixes

* mini refactoring

* add tests

Unify the operating mode for bridge pallets

- define the OperationMode trait and BasicOperatingMode enum
- use the OperationMode trait in all the bridge pallets
- use BasicOperatingMode instead of IsHalted for the Grandpa pallet
- use BasicOperatingMode as part of MessagesOperatingMode

Signed-off-by: Serban Iorga <[email protected]>

Serban Iorga authored Jun 24, 2022 and Serban Iorga committed Jun 27, 2022

Avoid duplicate function definitions for:
- ensure_owner_or_root()
- ensure_not_halted()
- set_owner()
- set_operating_mode() / set_operational()

Signed-off-by: Serban Iorga <[email protected]>

* store both block number and hash in BestFinalized

* also fix relay code

* spelling

* fix on-different-forks metrics during initialization

* "initialize" parachain finality pallet in on-demand parachains relay

* decrease converstion rate requests count

* more error logging

* fix compilation

* clippy

* separate accounts for different complex relay layers

* fix clippy issue

* cleanup + expose relay accounts balance metrics

* expose messages pallet owner balance metric

* use new metrics in maintenance dashboard

* tests + use separate accounts to sign RialtoHeaders -> Millau transactions in RialtoParachain<>Millau bridge

* clippy + fmt + spellcheck

* BridgeRejectObsoleteMessages

* add obsolete confirmations verification to the BridgeRejectObsoleteMessages

* move tests where they belong

* remove duplicate parachain heads exension

* fix benchmarks compilation

* actually fix it

* added parachains pallet benchmarks

* deduplicate insertion of bridged header

* pruning weight

* fixes

* fix compilation

* reintroduce From<SourceChain>InboundLaneApi

* impl From<Chain>InboundLaneApi for testnet runtimes

* use inboundlaneapi in relay

* remove unused OutboundXcmWeigher

* spelling

* added the only test to messages pallet

* fmt

* add RialtoParachain <> Millau bridge to test deployments

* flush (still not working, but possible fix in comments)

* proper fix

* fixed on-demand parachains relay case: if better relay header is delivered, then we must select para header that may be proved using this relay header

* dashboards

* fmt

* removing debugging code

* more cleanup

fixed on-demand parachains relay case: if better relay header is delivered, then we must select para header that may be proved using this relay header (#1419)

* complex parachain relay

* fix spelling

* switch to gav-xcm-v3 branch (wip)

* add comment

* play with CI

* keep playing with CI

* play with CI

* trigger CI

* Revert "trigger CI"

This reverts commit fc35ac64.

* introduce FinalityEngine in relay code

* add FinalityEngine to relay

* spelling

* fix test compilation

* Update relays/lib-substrate-relay/src/finality/source.rs

Co-authored-by: Adrian Catangiu <[email protected]>

Co-authored-by: Adrian Catangiu <[email protected]>

* fix typos

* clippy fixes

* cumulus: 4e952282914719fafd2df450993ccc2ce9395415
polkadot: 975e780ae0d988dc033f400ba822d14b326ee5b9
substrate: 89fcb3e4f62d221d4e161a437768e77d6265889e

* fix refs

* sync changes from https://github.com/paritytech/polkadot/pull/3828

* sync changes from https://github.com/paritytech/polkadot/pull/4387

* sync changes from https://github.com/paritytech/polkadot/pull/3940

* sync with changes from https://github.com/paritytech/polkadot/pull/4493

* sync with changes from https://github.com/paritytech/polkadot/pull/4958

* sync with changes from https://github.com/paritytech/polkadot/pull/3889

* sync with changes from https://github.com/paritytech/polkadot/pull/5033

* sync with changes from https://github.com/paritytech/polkadot/pull/5065

* compilation fixes

* fixed prometheus endpoint startup (it now requires to be spawned within tokio context)

* merge all similar update_conversion_rate functions

* stall timeout in conversion rate update loop

* fmt

* fix