Skip to content
  1. Apr 24, 2023
  3. Apr 21, 2023
  5. Apr 17, 2023
  7. Apr 14, 2023
  9. Apr 13, 2023
  11. Apr 11, 2023
  13. Mar 30, 2023
    • Niklas Adolfsson's avatar
      fix: tokio v1.27 (#1062) · 118acc39
      Niklas Adolfsson authored 
      * fix: tokio v1.27

* Update server/src/transport/ws.rs

* fix rustdoc

* Update server/src/transport/ws.rs

* Update server/src/transport/ws.rs

* no more futuredriver for incoming conns

* add comment for unclear code
      118acc39
  15. Mar 24, 2023
  17. Mar 23, 2023
    • Niklas Adolfsson's avatar
      rpc module: refactor subscriptions to return `impl IntoSubscriptionResponse` (#1034) · 7144be54
      Niklas Adolfsson authored 
      

* refactor subscription to return `Option<Result<>>`

* address grumbles: change to Result<(), Option<M>>

This changes the subscription API again to return `Result<(), Option<SubscriptionMessage>>`
to work a little smoother with the combinators and it introduces an extention trait
to make convert it `Result<T, Error>` to `Result<T, Option<SubscriptionMessage>>`

This trait is implemented for types where it is possible and for custom types and tricky situations the
user has to implement themselves.

For instance it's not possible to implement on `TrySendError` because that depends on the use-case
i.e. whether the channel is full should be regarded as an error or not.

* remove weird default errors

* fix tests

* revert weird trait

* introduce `IntoSubscriptionResult`

* refactor: introduce subscription mod

* impl StdError for subscription error types

* fix nits + tests

* fix doc tests

* remove deadcode

* Update server/src/tests/ws.rs

* cleanup to make review easier

* SubscriptionAcceptError -> PendingSubscriptionAcceptError

* make it clear that SubscriptionPermit is mocked

* remove deadcode

* fix doc links

* make register_subscription more readable

* remove Option impl for IntoSubscriptionCloseResponse

* fix tests

* add test for subscription return type

* fix nits

* impl `IntoSubscriptionCloseResponse` for ()

* remove useless ui test

* Update core/src/server/error.rs

* register_subscription: change order of parameters

* Update core/src/server/error.rs

* Update proc-macros/src/lib.rs

* fix doc link

* proc macro: compile test for !Result

* hacky solution

* add niklas ugly hack for providing default value

* fix hacks

* cargo fmt

* Update core/src/server/subscription.rs

Co-authored-by: default avatarJames Wilson <[email protected]>

* fix grumbles

* fix tests

* add test for null notification

* impl IntoSubscriptionResponse for Result<(), E>

* more descriptive error impls

* Update core/src/server/subscription.rs

Co-authored-by: default avatarJames Wilson <[email protected]>

* update docs: Subscription::next

* revert UI tests

* proc macro tests: add subscription -> ()

* remove unused tokio feature

* show failing test

* fix tests

* revert JSON str parsing

* add `SerializeAsStr` error

* show James

* push hack to show James what I mean

* SubscriptionResult = Result<(), StringError>

* fix tests

* address grumbles

* Update core/src/server/subscription.rs

* Update proc-macros/src/lib.rs

* Update proc-macros/src/lib.rs

* remove unused error variant SubscriptionCallbackError

---------

Co-authored-by: default avatarJames Wilson <[email protected]>
      7144be54
  19. Mar 21, 2023
  21. Mar 16, 2023
  23. Mar 14, 2023
  25. Mar 06, 2023
  27. Mar 01, 2023
  29. Feb 27, 2023
  31. Feb 24, 2023
  33. Feb 23, 2023
  35. Feb 22, 2023
  37. Feb 21, 2023
  39. Feb 20, 2023
  41. Feb 18, 2023
  43. Feb 17, 2023
  45. Feb 16, 2023
  47. Feb 15, 2023