* WIP: refactoring

* refactor http server

* fix tests

* Delete TODO.txt

* fix tests again

* add benches/src/lib.rs

* remove bench changes; fast less deps

* no more env_logger

* update examples

* ws server; expose headers in middleware

* add back uncommented code

* fix nits

* make the code more readable

* add back the tracing stuff

* simplify code but one extra clone

* fix tests again

* revert async accept API

* fix nits

* different traits for WS and HTTP middleware

* fix tests

* revert benchmark change

* Update core/src/server/helpers.rs

* Update ws-server/Cargo.toml

* add limit to batch responses as well

* pre-allocate string for batches

* small refactor

* Parse user defined client_bounds and server_bounds

Signed-off-by: Alexandru Vasile <[email protected]>

* Use custom user defined bounds if provided

Signed-off-by: Alexandru Vasile <[email protected]>

* Add provided where clause to the custom bounds

Signed-off-by: Alexandru Vasile <[email protected]>

* Add proc_macro with bounds example

Signed-off-by: Alexandru Vasile <[email protected]>

* Check against client_bounds wihtout client implementation

Signed-off-by: Alexandru Vasile <[email protected]>

* tests: Add ui test for empty bounds

Signed-off-by: Alexandru Vasile <[email protected]>

* tests: Add ui test to check bounds without implementation

Signed-off-by: Alexandru Vasile <[email protected]>

* Add bounds documentation

Signed-off-by: Alexandru Vasile <[email protected]>

* rpc_macro: Remove `WherePredicate` from parsing

Signed-off-by: Alexandru Vasile <[email protected]>

* ui: Add test that compiles

Signed-off-by: Alexandru Vasile <[email protected]>

* Rename rendered `T` to avoid collision with user provided generic

Signed-off-by: Alexandru Vasile <[email protected]>

* tests: Modify UI correct rpc_bounds test to call server's methods

Signed-off-by: Alexandru Vasile <[email protected]>

* subscription: Allow errors in subscription callbacks

Signed-off-by: Alexandru Vasile <[email protected]>

* subscription: Remove the need to own the error

Signed-off-by: Alexandru Vasile <[email protected]>

* error: Build `ErrorObject` from `CallError` for improved ergonomics

Signed-off-by: Alexandru Vasile <[email protected]>

* Update examples for the new subscription API

Signed-off-by: Alexandru Vasile <[email protected]>

* Add alias for subscription result

Signed-off-by: Alexandru Vasile <[email protected]>

* macros: Render server subscription method with `ResultSubscription`

Signed-off-by: Alexandru Vasile <[email protected]>

* Port `proc_macro` example to new API

Signed-off-by: Alexandru Vasile <[email protected]>

* Rename `ResultSubscription` to `ReturnTypeSubscription` to avoid confusion

Signed-off-by: Alexandru Vasile <[email protected]>

* Port all tests to new subscription API

Signed-off-by: Alexandru Vasile <[email protected]>

* Update documentation

Signed-off-by: Alexandru Vasile <[email protected]>

* Port benches

Signed-off-by: Alexandru Vasile <[email protected]>

* Replace tabs with spaces & add documentation

Signed-off-by: Alexandru Vasile <[email protected]>

* Add dummy error for subscriptions

Signed-off-by: Alexandru Vasile <[email protected]>

* Implement `From` for `SubscriptionError`

Signed-off-by: Alexandru Vasile <[email protected]>

* Return `SubscriptionError` when parsing params

Signed-off-by: Alexandru Vasile <[email protected]>

* Rename `SubscriptionError` to `SubscriptionEmptyError`

Signed-off-by: Alexandru Vasile <[email protected]>

* Change `accept` signature

Signed-off-by: Alexandru Vasile <[email protected]>

* Port tests to new `accept` api

Signed-off-by: Alexandru Vasile <[email protected]>

* Implement `pipe_from_try_stream` and `pipe_from_stream` for `PendingSubscription`

Signed-off-by: Alexandru Vasile <[email protected]>

* Modify examples to ilustrate new API

Signed-off-by: Alexandru Vasile <[email protected]>

* Fix docs tests

Signed-off-by: Alexandru Vasile <[email protected]>

* Rename previously `SubscriptionResult` -> `InnerSubscriptionResult`

Signed-off-by: Alexandru Vasile <[email protected]>

* Rename `ReturnTypeSubscription` -> `SubscriptionResult`

Signed-off-by: Alexandru Vasile <[email protected]>

* Remove documentation line

Signed-off-by: Alexandru Vasile <[email protected]>

* Implement `PipeFromStreamResult`

Signed-off-by: Alexandru Vasile <[email protected]>

* Add comment for empty error

Signed-off-by: Alexandru Vasile <[email protected]>

* Update proc-macros/src/lib.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* Update proc-macros/src/lib.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* Update proc-macros/src/lib.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* Change `ReturnTypeSubscription` -> `SubscriptionResult`

Signed-off-by: Alexandru Vasile <[email protected]>

* Add `ResultConsumed` for `PipeFromStreamResult`

Signed-off-by: Alexandru Vasile <[email protected]>

* Update examples to use `PipeFromStreamResult`

Signed-off-by: Alexandru Vasile <[email protected]>

* Replace ConsumedResult with Options

Signed-off-by: Alexandru Vasile <[email protected]>

* Log warning when subscription callback fails

Signed-off-by: Alexandru Vasile <[email protected]>

* Change ubuntu test names

Signed-off-by: Alexandru Vasile <[email protected]>

* server: Make `pipe` methods of `SubscriptionSink` private

Signed-off-by: Alexandru Vasile <[email protected]>

* server: Remove `pipe_from_stream` method of `SubscriptionSink`

Signed-off-by: Alexandru Vasile <[email protected]>

* server: Update PipeFromStreamResult documentation

Signed-off-by: Alexandru Vasile <[email protected]>

* Adjust tests to `SubscriptionSink::pipe_from_stream` private interface

Signed-off-by: Alexandru Vasile <[email protected]>

* Add `accept-reject` API on `SubscriptionSink`

Signed-off-by: Alexandru Vasile <[email protected]>

* Make `pipe_from_try_stream` public

Signed-off-by: Alexandru Vasile <[email protected]>

* Maybe accept the subscription

Signed-off-by: Alexandru Vasile <[email protected]>

* Revert "server: Remove `pipe_from_stream` method of `SubscriptionSink`"

This reverts commit d3c3ce9c

.

* Make `unsubscribe` channel optional on accepting the connection

Signed-off-by: Alexandru Vasile <[email protected]>

* Pass `SubscriptionSink` to subscription callbacks

Signed-off-by: Alexandru Vasile <[email protected]>

* Implement subscription sink state

Signed-off-by: Alexandru Vasile <[email protected]>

* Submit `InvalidParams` if sink was never accepted

Signed-off-by: Alexandru Vasile <[email protected]>

* Handle rejected sinks

Signed-off-by: Alexandru Vasile <[email protected]>

* Remove `PendingSubscription`

Signed-off-by: Alexandru Vasile <[email protected]>

* Fix doc tests

Signed-off-by: Alexandru Vasile <[email protected]>

* macro: Make subscription sink mutable

Signed-off-by: Alexandru Vasile <[email protected]>

* Fix tests and examples

Signed-off-by: Alexandru Vasile <[email protected]>

* macro: Return `sink.reject()` result

Signed-off-by: Alexandru Vasile <[email protected]>

* tests: Add test for `SubscriptionSinkState`

Signed-off-by: Alexandru Vasile <[email protected]>

* Test internal subscription sink state

Signed-off-by: Alexandru Vasile <[email protected]>

* Fix `send_error` to not always return `false`

Signed-off-by: Alexandru Vasile <[email protected]>

* Fix benches

Signed-off-by: Alexandru Vasile <[email protected]>

* Remove `PipeFromStreamResult`

Signed-off-by: Alexandru Vasile <[email protected]>

* Use valid Json-RPC return code for test errors

Signed-off-by: Alexandru Vasile <[email protected]>

* Remove `SubscriptionSinkState`"

* Remodel state machine using `Option`s for `SubscriptionSink`s

Signed-off-by: Alexandru Vasile <[email protected]>

* tests: Double accept / reject API for `SubscriptionSink`

Signed-off-by: Alexandru Vasile <[email protected]>

* Implement `SubscriptionAcceptRejectError` for error propagation

Signed-off-by: Alexandru Vasile <[email protected]>

* Remove `maybe_accept` wrapper

Signed-off-by: Alexandru Vasile <[email protected]>

* Update comments and documentation

Signed-off-by: Alexandru Vasile <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* rpc_server: Add type alias for unsubscription calls

Signed-off-by: Alexandru Vasile <[email protected]>

* rpc_server: Improve comment regarding dropped error

Signed-off-by: Alexandru Vasile <[email protected]>

* style: Single line return errors

Signed-off-by: Alexandru Vasile <[email protected]>

* Make comment more verbose

Co-authored-by: Niklas Adolfsson <[email protected]>
Co-authored-by: James Wilson <[email protected]>

Updates the requirements on [pprof](https://github.com/tikv/pprof-rs) to permit the latest version.
- [Release notes](https://github.com/tikv/pprof-rs/releases)
- [Changelog](https://github.com/tikv/pprof-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tikv/pprof-rs/compare/v0.9.1...v0.10.0

)

---
updated-dependencies:
- dependency-name: pprof
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Just a small readme tweak

* Remove `deny_unknown_fields`

* Update invalid request tests

* Remove `is_not_request_object` field from req in test

* Remove `deny_unknown_fields` from `Response`

* Add test to verify unknown field results in valid request

Signed-off-by: Alexandru Vasile <[email protected]>

To include the bugfix for `tracing::enabled!` when `log` is enabled.
Follow up on #722

* feat(clients): add explicit unsubscribe API

* add tests for unsubscribe

* rephrase bad english

* less verbose logging + tracing based on method name

* add tracing per rpc call

* fix nits

* remove unsed feature

* fix build

* http make logging more human friendly

* unify logging format

* deps: make tracing hard dependency

* fix tests

* fix nit

* fix build

* fix nits

* Update core/src/client/async_client/mod.rs

* Update core/Cargo.toml

* Update core/src/lib.rs

* ws-server: Fix copyright for tests

Signed-off-by: Alexandru Vasile <[email protected]>

* rpc_module: Return a resource builder when subscribing

Registering a subscription returns the subscription'
callback wrapped into a `MethodResourcesBuilder` for resource
limiting purposes.

Signed-off-by: Alexandru Vasile <[email protected]>

* tests: Fix `register_subscription` tests

Signed-off-by: Alexandru Vasile <[email protected]>

* server: Drop `ResourceGuard` with `SubscriptionSink` for resource limit

Signed-off-by: Alexandru Vasile <[email protected]>

* tests: Check resource limits for subscription

Signed-off-by: Alexandru Vasile <[email protected]>

* proc-macros: Render resource limits for subscription macro

Signed-off-by: Alexandru Vasile <[email protected]>

* tests: Extend subscription limiting test via macro generation

Signed-off-by: Alexandru Vasile <[email protected]>

* core: Check if the `unsubscribe` method was already inserted

Signed-off-by: Alexandru Vasile <[email protected]>

* tests: Fix unsupported fields for subscriptions

Signed-off-by: Alexandru Vasile <[email protected]>

* server: Verify subscription methods before registering them

Signed-off-by: Alexandru Vasile <[email protected]>

* Update test comment for subscription limiting

Signed-off-by: Alexandru Vasile <[email protected]>

* Modify tests comments

Signed-off-by: Alexandru Vasile <[email protected]>

* chore(release): v0.14.0

* Update CHANGELOG.md

* Update CHANGELOG.md

* fix(servers): more descriptive errors calls fail

Closing #775

* fix tests

* rename constants

* address grumbles

* initial rewrite to re-use HTTP access control

* clean things up

* Update core/src/error.rs

* Update core/src/error.rs

* allow origin: add back removed Display impl

* cleanup again

* Update http-server/src/lib.rs

* Update examples/examples/cors_server.rs

* Update core/src/server/access_control/mod.rs

Co-authored-by: Tarik Gul <[email protected]>

* Update http-server/src/server.rs

Co-authored-by: Tarik Gul <[email protected]>

* fix bad comment

* remove todo

* fix grumbles

* more grumbles

* rename and document a bit

* remove `Access-Control-Allow-Origin` in whitelist

* fix nit: pub(super)

* fix bad naming

Co-authored-by: Tarik Gul <[email protected]>

* ws-server: Submit ping regardless of WS messages

Signed-off-by: Alexandru Vasile <[email protected]>

* use tokio_stream::IntervalStream for less boxing

Co-authored-by: Niklas Adolfsson <[email protected]>

* ws: Implement ping for `TransportSenderT` trait

Signed-off-by: Alexandru Vasile <[email protected]>

* ws/client: Receive pong frames

Signed-off-by: Alexandru Vasile <[email protected]>

* core/client: Use `select!` macro for the background task

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Propagate ping interval to background task

Signed-off-by: Alexandru Vasile <[email protected]>

* async_client: Submit ping requests

Signed-off-by: Alexandru Vasile <[email protected]>

* async_client: Handle pong replies

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Handle frontend messages to dedicated fn

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Handle backend messages in dedicated fn

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Add terminated fuse for opt-out pings

Signed-off-by: Alexandru Vasile <[email protected]>

* Set opt-out behavior for client pings

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Move imports

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Handle handle_frontend_messages errors

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Add custom error related to byteslice conversions

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Modify `send_ping` to send empty slices

Signed-off-by: Alexandru Vasile <[email protected]>

* Fix `cargo hack check` and use `select_biased`

Signed-off-by: Alexandru Vasile <[email protected]>

* Handle sending pings with lowest priority

Signed-off-by: Alexandru Vasile <[email protected]>

* core: Add proper number of params to `background_task`

Signed-off-by: Alexandru Vasile <[email protected]>

* Fix wasm client

Signed-off-by: Alexandru Vasile <[email protected]>

* Handle raw bytes and string received messages

Signed-off-by: Alexandru Vasile <[email protected]>

* Fix Cargo.toml feature

Signed-off-by: Alexandru Vasile <[email protected]>

* Panic when empty slice does not fit into `ByteSlice125`

Signed-off-by: Alexandru Vasile <[email protected]>

* wasm: Add operation not supported for pings

Signed-off-by: Alexandru Vasile <[email protected]>

* Rename `ReceivedMessage` from Data to Text

Signed-off-by: Alexandru Vasile <[email protected]>

* Rename test variable

Signed-off-by: Alexandru Vasile <[email protected]>

* Add documentation

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Use `future::select` for  cancel safety

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Remove `pong` handling logic

Signed-off-by: Alexandru Vasile <[email protected]>

* client: Update ping documentation

Signed-off-by: Alexandru Vasile <[email protected]>

* Update core/src/client/async_client/mod.rs

Co-authored-by: Tarik Gul <[email protected]>

* Update core/src/client/async_client/mod.rs

Co-authored-by: Tarik Gul <[email protected]>

* Update core/src/client/async_client/mod.rs

Co-authored-by: Tarik Gul <[email protected]>

* Update core/src/client/async_client/mod.rs

Co-authored-by: Tarik Gul <[email protected]>

* Update core/src/client/async_client/mod.rs

Co-authored-by: Tarik Gul <[email protected]>

* Update core/Cargo.toml

Co-authored-by: Niklas Adolfsson <[email protected]>

* Update core/Cargo.toml

Co-authored-by: Niklas Adolfsson <[email protected]>

* logs: Keep debug log for submitting `Ping` frames

Signed-off-by: Alexandru Vasile <[email protected]>

* Print debug logs when receiving `Pong` frames

Signed-off-by: Alexandru Vasile <[email protected]>

* Update core/src/client/async_client/mod.rs

Co-authored-by: Tarik Gul <[email protected]>
Co-authored-by: Niklas Adolfsson <[email protected]>

* fix(http server): omit jsonrpc details health API

Closing https://github.com/paritytech/jsonrpsee/issues/784
Ordinary GET requests doesn't expect the body the be formatted as
`JSON-RPC` responses which this fixes.

* address grumbles

* Update http-server/src/server.rs

* cargo fmt

* ws-server: Implement `ping-ping`

Signed-off-by: Alexandru Vasile <[email protected]>

* ws-server: Set builder's ping_interval

Signed-off-by: Alexandru Vasile <[email protected]>

* ws-server: Handle just `ping` frames

Signed-off-by: Alexandru Vasile <[email protected]>

* ws-server: Simplify `select`

Signed-off-by: Alexandru Vasile <[email protected]>

* Use `futures_util::select` instead of `select!` macro

Signed-off-by: Alexandru Vasile <[email protected]>

* ws-server: Avoid pinning the delay

Signed-off-by: Alexandru Vasile <[email protected]>

* ws-server: Log when a `Pong` frame is received

Signed-off-by: Alexandru Vasile <[email protected]>

* ws-server: Use tokio for submitting pings

Signed-off-by: Alexandru Vasile <[email protected]>

Bumps [Swatinem/rust-cache](https://github.com/Swatinem/rust-cache) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/Swatinem/rust-cache/releases)
- [Changelog](https://github.com/Swatinem/rust-cache/blob/v1/CHANGELOG.md)
- [Commits](https://github.com/Swatinem/rust-cache/compare/v1.3.0...v1.4.0

)

---
updated-dependencies:
- dependency-name: Swatinem/rust-cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 2.4.0 to 3.0.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2.4.0...v3.0.2

)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: bring back daily benchmarks

* remove ugly spaces

* Move examples under dedicated folder to simplify `Cargo.toml`

Signed-off-by: Alexandru Vasile <[email protected]>

* Fix readme links for examples

Signed-off-by: Alexandru Vasile <[email protected]>

* Fix deadlinks

Signed-off-by: Alexandru Vasile <[email protected]>

* chore(release): v0.13.1

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Tarik Gul <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Tarik Gul <[email protected]>

* fix: generate docs for all features

* ci: check for --cfg docsrs

* fix nit: rustdoc::broken_intra_doc_links

Updates the requirements on [pprof](https://github.com/tikv/pprof-rs) to permit the latest version.
- [Release notes](https://github.com/tikv/pprof-rs/releases)
- [Changelog](https://github.com/tikv/pprof-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tikv/pprof-rs/commits

)

---
updated-dependencies:
- dependency-name: pprof
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(release): v0.13.0

* Update CHANGELOG.md

* feat: add http health API

* Update http-server/src/server.rs

* remove needless change

* fix middleware nits

* fix: generate docs behind features

* address grumbles

* feat: limit the number of subscriptions

Closing #729

* fix nit

* Update core/src/server/helpers.rs

* add integration tests + some fixes so it works

* cargo fmt

* fix doc links

* Unsubscribe calls should avoid subscription limits

Point to Tokio 1.16 (we use a method from it), and a little special treatment for unsubscribe methods

* No resource limiting for Unsubscribe calls

* Test that we can still unsubscribe after hitting a limit

* Fix a comment typo

Co-authored-by: Alexandru Vasile <[email protected]>

* Update core/src/server/rpc_module.rs

* Update core/src/server/rpc_module.rs

Co-authored-by: James Wilson <[email protected]>
Co-authored-by: Alexandru Vasile <[email protected]>

* fix: use https conn for https

* enable integration tests for https and wss

* remove socket options of http client

fix(rpc module): close subscription task when a subscription is `unsubscribed` via the `unsubscribe call` (#743)

* refactor: remove SubscriptionSink::inner_send

* fix: close running task if unsubscribed

* Update core/src/server/rpc_module.rs

* Update core/src/server/rpc_module.rs

* fix nits

* Update core/src/server/rpc_module.rs

* add test for canceling subscriptions

* print subscription info; once per minute

* revert closure stuff

* Revert "print subscription info; once per minute"

This reverts commit 366176a8

.

* use tokio::sync::watch instead of oneshot

The receiver is clonable and it's possible to check whether the sender is still alive

* Update tests/tests/helpers.rs

Co-authored-by: David <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: David <[email protected]>

* grumbles: use unwrap in tests

* add test for reuse pipe_from_stream

Co-authored-by: David <[email protected]>