Unverified Commit c4f0f497 authored by James Wilson's avatar James Wilson Committed by GitHub
Browse files

Make comment more verbose

parent 997706a3
Pipeline #200815 passed with stages
in 5 minutes and 37 seconds
......@@ -1049,7 +1049,10 @@ impl SubscriptionSink {
impl Drop for SubscriptionSink {
fn drop(&mut self) {
if let Some(id) = self.id.take() {
// Subscription was never accepted / rejected.
// Subscription was never accepted / rejected. As such,
// we default to assuming that the params were invalid,
// because that's how the previous PendingSubscription logic
// worked.
self.inner.send_error(id, ErrorCode::InvalidParams.into());
} else if self.is_active_subscription() {
self.subscribers.lock().remove(&self.uniq_sub);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment