Skip to content
  1. Jan 08, 2019
  2. Jan 07, 2019
    • Luke Schoen's avatar
      refactor: Remove menubar demo and dependency · 7b0873bd
      Luke Schoen authored
      7b0873bd
    • Luke Schoen's avatar
      refactor: Integrate menubar. Separate logic for taskbar app. See commit details · 4763ac05
      Luke Schoen authored
      * Readme updated with environment variable prefix `TASKBAR=false` to disable taskbar.
      Use existing "electron" and "start" scripts in package.json.
      Configure taskbar to be enabled by default (i.e. `withTaskbar = true`)
      
      * Integrate menubar functionality including for taskbar including:
          * electron dependencies: `Tray`
          * electron-positioner: `Positioner`
      
      * Separate logic in `FetherApp` component dependending on whether `withTaskbar` is enabled,
      but shared functionality in `finalise()` function
      
      * Incorporate relevant Pino logs throughout to improve developer experience
      
      * Move options into FetherAppOptions class and move configuration config for options into
      a config subfolder within the module.
      
      * Use `extends` library to overwrite `DEFAULT_OPTIONS` options properties with those in `TASKBAR_OPTIONS`
      if `withTaskbar` is enabled
      
      * Add ability to pass `customOptions` to further overwrite the values in the config directory, and add option setter and getters
      
      * Move taskbar icons into app/options/config subdirectory.
      Use different logic to set the path of the icons directory depending on whether it was run
      using the "electron" or the "start" script in package.json. Leverage the fact that when
      "electron" is run the environment variable `SKIP_PREFLIGHT_CHECK=true` is set
      
      * Set the Electron option `webPreferences.devTools` depending on whether we are in production or not
      particularly for security reasons
      
      * Fix `activate` event listener to cater for `withTaskbar` enabled or disabled usage
      
      * BUG: When running with `withTaskbar` enabled we are setting the option `show: false`
      because it opens the window in the center of the screen instead of positioned right under the
      taskbar icon at the top of the screen.
      When you click the icon in the taskbar it toggles the window open/close correctly positioned
      since it takes into consideration the `bounds` value in `FetherApp.clickedTray`.
      To fix the bug we need to reuse the same approach.
      
      * BUG: Additional `EventEmitter` does not appear to be working correctly or is not required.
      Investigate if can remove
      4763ac05
  3. Jan 06, 2019
  4. Dec 20, 2018
  5. Dec 18, 2018
  6. Dec 14, 2018
  7. Dec 12, 2018
  8. Dec 10, 2018
  9. Nov 20, 2018
  10. Nov 16, 2018
  11. Nov 14, 2018
  12. Nov 09, 2018
  13. Nov 08, 2018
  14. Nov 07, 2018
  15. Oct 29, 2018
  16. Oct 27, 2018
  17. Oct 25, 2018
  18. Sep 17, 2018
  19. Sep 07, 2018
  20. Aug 31, 2018
  21. Aug 23, 2018
  22. Aug 22, 2018
  23. Aug 21, 2018
  24. Aug 20, 2018
  25. Aug 17, 2018
  26. Aug 13, 2018
  27. Aug 06, 2018
  28. Aug 02, 2018
  29. Jul 23, 2018
  30. Jul 18, 2018
  31. Jul 11, 2018
  32. Jul 10, 2018