Skip to content
  1. Jan 07, 2019
    • Luke Schoen's avatar
      refactor: Integrate menubar. Separate logic for taskbar app. See commit details · 4763ac05
      Luke Schoen authored
      * Readme updated with environment variable prefix `TASKBAR=false` to disable taskbar.
      Use existing "electron" and "start" scripts in package.json.
      Configure taskbar to be enabled by default (i.e. `withTaskbar = true`)
      
      * Integrate menubar functionality including for taskbar including:
          * electron dependencies: `Tray`
          * electron-positioner: `Positioner`
      
      * Separate logic in `FetherApp` component dependending on whether `withTaskbar` is enabled,
      but shared functionality in `finalise()` function
      
      * Incorporate relevant Pino logs throughout to improve developer experience
      
      * Move options into FetherAppOptions class and move configuration config for options into
      a config subfolder within the module.
      
      * Use `extends` library to overwrite `DEFAULT_OPTIONS` options properties with those in `TASKBAR_OPTIONS`
      if `withTaskbar` is enabled
      
      * Add ability to pass `customOptions` to further overwrite the values in the config directory, and add option setter and getters
      
      * Move taskbar icons into app/options/config subdirectory.
      Use different logic to set the path of the icons directory depending on whether it was run
      using the "electron" or the "start" script in package.json. Leverage the fact that when
      "electron" is run the environment variable `SKIP_PREFLIGHT_CHECK=true` is set
      
      * Set the Electron option `webPreferences.devTools` depending on whether we are in production or not
      particularly for security reasons
      
      * Fix `activate` event listener to cater for `withTaskbar` enabled or disabled usage
      
      * BUG: When running with `withTaskbar` enabled we are setting the option `show: false`
      because it opens the window in the center of the screen instead of positioned right under the
      taskbar icon at the top of the screen.
      When you click the icon in the taskbar it toggles the window open/close correctly positioned
      since it takes into consideration the `bounds` value in `FetherApp.clickedTray`.
      To fix the bug we need to reuse the same approach.
      
      * BUG: Additional `EventEmitter` does not appear to be working correctly or is not required.
      Investigate if can remove
      4763ac05
  2. Jan 06, 2019
  3. Jan 05, 2019
    • Luke Schoen's avatar
      fix: Add white background body element so Onboarding background consistent in taskbar app · 64f65f47
      Luke Schoen authored
      * Note: To quickly see the changes force the Onboarding component (displaying Terms & Conditions screen) to appear by changing
      `if (isFirstRun) {` to `if (true) {` in `fether-react/src/App/App.js. The screen should be consistent when you run `yarn taskbar` and `yarn start`
      
      * Add eggshell background colour to `body` element  otherwise `yarn taskbar` app has grey background (even though
      running as normal `yarn start` or `yarn electron` app has white background from manifest)
      64f65f47
    • Luke Schoen's avatar
      fix: Update Onboarding component and make Terms & Conditions consistent on taskbar app · b2a4092c
      Luke Schoen authored
      * Note: To quickly see the changes force the Onboarding component (displaying Terms & Conditions screen) to appear by changing
      `if (isFirstRun) {` to `if (true) {` in `fether-react/src/App/App.js. The screen should be consistent when you run `yarn taskbar` and `yarn start`
      
      * Terms & Conditions updates for consistency and compatibility with taskbar app
      
      	* Add extra side padding `-padded-extra` to Terms & Conditions so consistent with rest of site and in taskbar app
      
      	* Wrap with `.terms-and-conditions-wrapper` to add box shadow around both the
      	'Please read carefully' label and associated Terms & Conditions
      
      	* Adjust height of `.terms-and-conditions` down to 16rem otherwise with more side padding it causes
      	overflow to occur with vertical scrollbar appearing (checked that it works on both taskbar app
      	i.e. `yarn taskbar` and normal app `yarn electron` or `yarn start`)
      
      	* Hide `overflow-x` in Terms and Conditions as caused horizontal scroll on taskbar app
      
      	* Add top margin to Terms and Conditions so extra gap from its 'Please read carefully' label
      
      	* Only left padding in Terms and Conditions
      b2a4092c
  4. Jan 04, 2019
  5. Jan 03, 2019
  6. Jan 02, 2019