Grumbles

packages/fether-react/src/App/App.js

@@ -91,7 +91,7 @@ class App extends Component {
   };
 
   openNewReleaseUrl = () => {
-    window.open(this.state.newRelease.url);
+    window.open(this.state.newRelease.url, '_blank', 'noopener noreferrer');
   };
 
   /**
@@ -103,6 +103,8 @@ class App extends Component {
       parityStore: { api }
     } = this.props;
 
+    const { newRelease } = this.state;
+
     if (isFirstRun) {
       return (
         <div className='window'>
@@ -135,9 +137,8 @@ class App extends Component {
           <div className='window'>
             <Modal
               title='New version available'
-              description={`${this.state.newRelease.name &&
-                this.state.newRelease.name} was released!`}
-              visible={this.state.newRelease && !this.state.newRelease.ignore}
+              description={`${newRelease && newRelease.name} was released!`}
+              visible={newRelease && !newRelease.ignore}
               buttons={this.renderModalLinks()}
             >
               <Router>

packages/fether-react/src/assets/sass/components/_alert-screen.scss

@@ -30,7 +30,6 @@
 }
 
 .alert-screen-content {
-
   width: 75%;
 
   .alert-screen_image {

packages/fether-ui/src/Modal/Modal.js

@@ -8,12 +8,12 @@ import PropTypes from 'prop-types';
 import { Image as SUIImage, Modal as SUIModal } from 'semantic-ui-react';
 
 export const Modal = ({
+  buttons,
   children,
   description,
   fullscreen,
-  link,
   icon,
-  buttons,
+  link,
   title,
   visible
 }) => (
@@ -26,11 +26,11 @@ export const Modal = ({
         <SUIModal.Content image className='alert-screen-content'>
           {icon && (
             <SUIImage
-              wrapped
               alt='loading'
+              className='alert-screen_image'
               size='medium'
               src={icon}
-              className='alert-screen_image'
+              wrapped
             />
           )}
           <SUIModal.Description className='alert-screen_text'>
@@ -47,12 +47,12 @@ export const Modal = ({
 );
 
 Modal.propTypes = {
+  buttons: PropTypes.node,
   children: PropTypes.node,
   description: PropTypes.oneOfType([PropTypes.node, PropTypes.string]),
   fullscreen: PropTypes.bool,
+  icon: PropTypes.string,
   link: PropTypes.node,
-  icon: PropTypes.any,
-  buttons: PropTypes.node,
   title: PropTypes.oneOfType([PropTypes.node, PropTypes.string]),
   visible: PropTypes.bool
 };