Skip to content
  1. Oct 08, 2020
  2. Sep 29, 2020
  3. Sep 25, 2020
  4. Sep 22, 2020
  5. Sep 15, 2020
  6. Sep 10, 2020
  7. Sep 08, 2020
  8. Aug 24, 2020
  9. Aug 23, 2020
  10. Aug 22, 2020
  11. Aug 20, 2020
    • Web3 Philosopher's avatar
      Merge Subkey into sc-cli (#4954) · 6e098a10
      Web3 Philosopher authored
      * draft
      
      * revert
      
      * WIP
      
      * all that remains is tests
      
      * update Cargo.lock
      
      * tests WIP
      
      * WIP refactor node-template-runtime and node-runtime
      
      * implments sc_cli::RuntimeAdapter for node_template_runtime::Runtime
      
      * final draft
      
      * fix update_config for subcommands
      
      * proper AccountId decoding
      
      * test-runtime tests
      
      * revert
      
      * move RuntimeAdapter to cli-utils
      
      * use &'static str for TryFrom::<&'a str>::Error for Ss58AddressFormat
      
      * tests
      
      * add frame-system to sc-cli dev-dependencies
      
      * add frame-system to sc-cli dev-dependencies
      
      * fix ui test
      
      * wip
      
      * fixed inspect test
      
      * bump impl version
      
      * bump impl version, fixx spaces remove todos
      
      * pallet-balances-cli, rustc for some reason cannot resolve pallet_balances_cli in node-cli 😩
      
      * wip
      
      * Subcommand::run takes &self
      
      * can't believe i missed that 🤦🏾‍♂️
      
      * bump wasm-bindgen for some reason
      
      * adds key subcommand, rename generate-node-key to generate-node-id
      
      * cargo update and crossed fingers 🤞🏽
      
      
      
      * update ui test
      
      * update more ui tests
      
      * should be all good now
      
      * revert subkey change
      
      * revert subkey change
      
      * adds frame-utilities-cli
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      
      * removes frame from sc-cli, fix license
      
      * my editor and ci disagrees on line width
      
      * bump spec version
      
      * turn off default features for parity-scale-codec
      
      * enable full_crypto feature for sp-core in cli-utils
      
      * merge frame-utilities-cli with pallet-balances-cli
      
      * remove full_crypto feature from sp_core in cli-utils
      
      * bump Cargo.lock
      
      * cli-utils -> frame-utils
      
      * rename BlockNumber to GenericNumber, fix spaces
      
      * fix spaces
      
      * construct additional_signed manually
      
      * sign test
      
      * remove unused vars
      
      * implement subkey with frame-utilities-cli and sc_cli
      
      * fix moduleid test
      
      * CI and clion disagree on line widths
      
      * adds associated Params type to SignedExtensionProvider
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      
      * move some code around
      
      * removes unneccesary generic params
      
      * moves module_id back to frame_utilities_cli
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * remove print_ext
      
      * remove MaybeDisplay from pallet_balances::Trait::Balance
      
      * a lot of stuff tbh
      
      * adds ExtrasParamsBuilder
      
      * remove tests for ModuleIdCmd
      
      * address comments from PR
      
      * bump Cargo.lock
      
      * manually insert key into keystore
      
      * remove unnecessary SharedParams
      
      * add validation to vanity pattern, remove unused arg
      
      * remove SharedParams from Sign, Vanity, Verify
      
      * remove SharedParams from ModuleIdCmd, remove expect from Verify, new line to Cargo.toml
      
      * remove SharedParams from InsertCmd
      
      * 🤦🏾
      
      ‍♂️
      
      * deleted prometheus.yml
      
      * move a few things around
      
      * fix vanity test
      
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      6e098a10
  12. Aug 12, 2020
  13. Aug 11, 2020
  14. Aug 03, 2020
  15. Jul 30, 2020
    • Aten's avatar
      support custom ss58addressformat in from_ss58check_with_version (#5526) · 293bcd60
      Aten authored
      
      
      * support custom ss58addressformat in from_ss58check_with_version
      
      * fix str parse
      
      1. if can parse with u8, use u8 into.
      2. if u8 can't parse, convert to str then parse
      
      * add a test
      
      * typo
      
      * add error description in test
      
      * fix the `TryFrom<u8>` for `Ss58AddressFormat`
      
      change check logic in TryFrom<u8> to replace modified code in `from_ss58check_with_version`
      
      * use Ss58AddressFormat::default() replace DEFAULT_VERSION
      
      * Apply suggestions from code review
      
      * Update primitives/core/src/crypto.rs
      
      * Update primitives/core/src/crypto.rs
      
      * Update primitives/core/src/crypto.rs
      
      * Update primitives/core/src/crypto.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      293bcd60
  16. Jul 26, 2020
  17. Jul 23, 2020
  18. Jul 21, 2020
  19. Jul 20, 2020
  20. Jul 10, 2020
  21. Jul 09, 2020
  22. Jul 04, 2020
    • André Silva's avatar
      babe: report equivocations (#6362) · 18334ee1
      André Silva authored
      * slots: create primitives crate for consensus slots
      
      * offences: add method to check if an offence is unknown
      
      * babe: initial equivocation reporting implementation
      
      * babe: organize imports
      
      * babe: working equivocation reporting
      
      * babe: add slot number to equivocation proof
      
      * session: move duplicate traits to session primitives
      
      * babe: move equivocation stuff to its own file
      
      * offences: fix test
      
      * session: don't have primitives depend on frame_support
      
      * babe: use opaque type for key owner proof
      
      * babe: cleanup client equivocation reporting
      
      * babe: cleanup equivocation code in pallet
      
      * babe: allow sending signed equivocation reports
      
      * node: fix compilation
      
      * fix test compilation
      
      * babe: return bool on check_equivocation_proof
      
      * babe: add test for equivocation reporting
      
      * babe: add more tests
      
      * babe: add test for validate unsigned
      
      * babe: take slot number in generate_key_ownership_proof API
      
      * babe: add benchmark for equivocation proof checking
      
      * session: add benchmark for membership proof checking
      
      * offences: fix babe benchmark
      
      * babe: add weights based on benchmark results
      
      * babe: adjust weights after benchmarking on reference hardware
      
      * babe: reorder checks in check_and_report_equivocation
      18334ee1
  23. Jul 01, 2020
    • cheme's avatar
      Restrict `Protected` to some heap types. (#6471) · 8ef1ac0e
      cheme authored
      * Restrict `Protected` to some heap types.
      
      * Comment abut Protected usage.
      
      * Remove Protected from crypto, use secrecy crate for existing uses.
      
      * use a parse function
      
      * fix error convert
      
      * Rename and move secretY string function.
      
      * std result
      8ef1ac0e
    • David's avatar
      Fix mocking multiple http calls in the same function call (#6510) · d855a5e9
      David authored
      
      
      * Fix mocking multiple http calls in the same function call
      
      Fixes an issue where a function call would perform more than one http request and wait for each to complete before proceeding. The `RequestId` comes from the length of the `requests` collection in the `OffchainState` and if a request is completed before the next one starts it will be removed and the "next expected" will be off by one. This PR tries to fix that by using a request counter that tracks how many requests have been performed so that we can `remove()` items from the `expected_requests` at the right index.
      
      I suspect that this is a sub-optimal soluton and perhaps requests and their mocks should live side by side in the same collection, e.g. in a tuple of `(PendingRequest, Option<ExpectedRequest>)`.
      
      * Update primitives/core/src/offchain/testing.rs
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      
      * Update primitives/core/src/offchain/testing.rs
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      
      * Panic on overflow
      
      * Update primitives/core/src/offchain/testing.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Use a Deque and push/pop expected requests
      
      * fix test
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      d855a5e9
  24. Jun 30, 2020
  25. Jun 18, 2020
    • Rakan Alhneiti's avatar
      Babe VRF Signing in keystore (#6225) · 9b08492e
      Rakan Alhneiti authored
      * Introduce trait
      
      * Implement VRFSigner in keystore
      
      * Use vrf_sign from keystore
      
      * Convert output to VRFInOut
      
      * Simplify conversion
      
      * vrf_sign secondary slot using keystore
      
      * Fix RPC call to claim_slot
      
      * Use Public instead of Pair
      
      * Check primary threshold in signer
      
      * Fix interface to return error
      
      * Move vrf_sign to BareCryptoStore
      
      * Fix authorship_works test
      
      * Fix BABE logic leaks
      
      * Acquire a read lock once
      
      * Also fix RPC acquiring the read lock once
      
      * Implement a generic way to construct VRF Transcript
      
      * Use make_transcript_data to call sr25519_vrf_sign
      
      * Make sure VRFTranscriptData is serializable
      
      * Cleanup
      
      * Move VRF to it's own module
      
      * Implement & test VRF signing in testing module
      
      * Remove leftover
      
      * Fix feature requirements
      
      * Revert removing vec macro
      
      * Drop keystore pointer to prevent deadlock
      
      * Nitpicks
      
      * Add test to make sure make_transcript works
      
      * Fix mismatch in VRF transcript
      
      * Add a test to verify transcripts match in babe
      
      * Return VRFOutput and VRFProof from keystore
      9b08492e
  26. Jun 16, 2020
    • Ashley's avatar
      Split the service initialisation up into seperate functions (#6332) · 6199d86c
      Ashley authored
      * Seperate out the complexity in ServiceBuilder::build_common into seperate functions
      
      * Fix line widths
      
      * Move some functions to their respective crates
      6199d86c
    • Bernhard Schuster's avatar
      historical slashing w ocw w adhoc tree creation (#6220) · 10959200
      Bernhard Schuster authored
      
      
      * draft
      
      * steps
      
      * chore: fmt
      
      * step by step
      
      * more details
      
      * make test public
      
      * refactor: split into on and offchain
      
      * test stab
      
      * tabs my friend
      
      * offchain overlay: split key into prefix and true key
      
      Simplifies inspection and makes key actually unique.
      
      * test: share state
      
      * fix & test
      
      * docs improv
      
      * address review comments
      
      * cleanup test chore
      
      * refactor, abbrev link text
      
      * chore: linewidth
      
      * fix prefix key split fallout
      
      * minor fallout
      
      * minor changes
      
      * addresses review comments
      
      * rename historical.rs -> historical/mod.rs
      
      * avoid shared::* wildcard import
      
      * fix: add missing call to store_session_validator_set_to_offchain
      
      * fix/compile: missing shared:: prefix
      
      * fix/test: flow
      
      * fix/review: Apply suggestions from code review
      
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      
      * fix/review: more review comment fixes
      
      * fix/review: make ValidatorSet private
      
      * fix/include: core -> sp_core
      
      * fix/review: fallout
      
      * fix/visbility: make them public API
      
      Ref #6358
      
      * fix/review: review changes fallout - again
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      10959200
  27. Jun 14, 2020
  28. Jun 12, 2020
    • André Silva's avatar
      client: use appropriate ExecutionContext for initial sync / regular import (#6180) · 0dc66347
      André Silva authored
      * client: use appropriate ExecutionContext for sync/import
      
      * client: remove dead code
      
      * client: ExecutionContext: distinguish between own and foreign imports
      
      * client: fix cli parameter doc
      
      * Revert "client: ExecutionContext: distinguish between own and foreign imports"
      
      This reverts commit 0fac1152.
      
      * primitives: add docs for ExecutionContext
      
      * cli: execution strategy docs
      
      * cli: use different execution context for importing block on validator
      
      * cli: remove defaults from execution context flags
      0dc66347
  29. Jun 11, 2020
  30. May 28, 2020
    • Bernhard Schuster's avatar
      offchain storage lock (#6010) · d65e6443
      Bernhard Schuster authored
      
      
      * feat/offchain/storage: add remove interface method
      
      * feat/offchain/storeage: add remote to StorageValueRef
      
      * feat/offchain/storage: add storage lock
      
      * fix/review: Apply suggestions from code review
      
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * refactor/offchain/storage/lock: introduce `Lockable` trait part 1 of 2
      
      * chore/offchain/rename: _remove -> clean
      
      * feat/offchain/storage/lock: add TimeAndBlock based part 2 of 2
      
      * fix/offchain/storage/lock: block and time expiry must be && not ||
      
      * chore/offchain/storage: minor fmt doc comments
      
      * doc/comment: prefer markdown emphasis over CAPS
      
      * doc/comment: rewrap multiline module level docs
      
      * doc/comment: rephrase
      
      * impl sleep_until and use the actual time for the test env
      
      * feat/test: add more tests, ignore some sample impl doctests
      
      * fix/review: Apply suggestions from code review
      
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      
      * doc/comment: better description
      
      * fix/review: Apply suggestions from code review
      
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      
      * chore/storage: lifetime cleanup
      
      * fix/cleanup: trait bounds, cargo-spellcheck + extra explanations
      
      * fix/doc: periods +-
      
      * fix/review: Apply suggestions from code review
      
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      
      * cleanup: remove explicit lifetime bound, copy -> clone
      
      * fix/review: make trait Lockable contain only static, try_lock should not return Err(Option<L>),
      
      * chore/lifetimes: remove a couple of lifetime bounds which the compiler can figure out
      
      * refactor: migrate to an instant based
      
      * fix/feedback: fix, reduce, rename, docs update pending
      
      * docs/reword: adjust to changed code
      
      * fix/offchain/testing: timestamp and sleep_until shall not block
      
      * chore/lines: lines must < 100 chars
      
      * fix/docs: add missing pub field doc comments
      
      * refactor/x: try_lock does not need to return an Option<_>
      
      * refactor/simplify: a better way of waiting for a lock to resolve
      
      * docs: consistency
      
      * fix/line: < 100
      
      * fix/doctest/use: avoid crate::
      
      * fix/doctest: *
      
      * fix/review: remove unused trait bound
      
      * fix/review: pretty by const fn
      
      * fix/review: reduce default timeout to 20s
      
      * docs: grammar
      
      * fix/review: add with_block_deadline
      
      * doc: revamp BlockNumberProvider documentation to be less frame centric
      
      * chore: fmt
      
      * docs: add missing doc comment
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      d65e6443
  31. May 21, 2020
  32. May 15, 2020
    • satellitex's avatar
      Added RuntimePublic for ecdsa public key. (#6029) · 61a72486
      satellitex authored
      * add generate ecdsa, etc to keystore
      
      * impl ecdsa needed traits
      
      * add ecdsa to sr_io
      
      * add ecdsa to application-crypto
      
      * add ecdsa to test-utils
      
      * add ecdsa debug derive
      
      * fix ecdsa public
      61a72486
    • Rakan Alhneiti's avatar
      Use `sign_with` in consensus (#6008) · 82ec8edf
      Rakan Alhneiti authored
      * Add derive_more to sp_core
      
      * Convert Vec to Signature
      
      * Use sign_with in AURA and BABE
      
      * Signing errors
      
      * Update slots to return consensus result
      
      * Fix use
      
      * Clone public key
      
      * Match block_params
      
      * WIP
      
      * Use to_public_crypto_pair
      
      * Pass public key only to block import params
      
      * Address PR review
      
      * Fix consensus RPC
      
      * Fix babe tests
      
      * adjust uses
      
      * Fix line widths
      82ec8edf
    • Benjamin Kampmann's avatar
      dbf21632
  33. May 13, 2020