Skip to content

Pure Electron MVP

Ghost User requested to merge am-pure-electron into next

Same as #7, besides the fact that this version only works with Electron.

Advantage compared to #7:

Parity doesn't need to serve on :8180 anymore (cleaner UI/core split)

Usage

  • Run parity --ws-origins parity://*.wallet.parity
  • Dev: npm start in one terminal and npm run electron:dev in another
  • Prod: npm run electron

Note: If you run npm start, it's still possible to dev in browser environment like before. Only built app is not browser-compatible.

How it works

  • Electron can now take arguments --ws-interface, --ws-port (exactly like parity).
  • Removed all uiUrl, uiApi, httpProvider, :8180... from SecureApi.
  • UI calls http://127.0.0.1:8546/api/ping for isNodeUp (instead of :8180 before)
  • UI doesn't do any HTTP fetch on 127.0.0.1:8180/rpc to get parity_wsUrl and parity_dappsUrl. Instead, it takes those two parameters from --flags passed into Electron, or the default ones.

Known bugs

  • DappIcons don't show (easily fixable)
  • Cmd+V doesn't work on Mac.

Merge request reports