Unverified Commit 4eaea348 authored by Bastian Köcher's avatar Bastian Köcher Committed by GitHub

Fix tx-pool returning the same transaction multiple times (#6535)

* Fix tx-pool returning the same transaction multiple times

This fixes a bug that lead to returning the same transaction multiple
times when iterating the `ready` iterator. Internally the transaction
was kept in the `best` list and could be duplicated in that list be
re-inserting it again. This `best` list is using a `TransactionRef`
which internally uses a `insertion_id`. This `insertion_id` could lead
to the same transaction being inserted multiple times into the `best`
list.

* Update client/transaction-pool/src/testing/pool.rs
Co-authored-by: Nikolay Volf's avatarNikolay Volf <nikvolf@gmail.com>
Co-authored-by: Nikolay Volf's avatarNikolay Volf <nikvolf@gmail.com>
parent 0d0a84db
Pipeline #98733 failed with stages
in 39 minutes and 57 seconds