1. 26 May, 2023 4 commits
  2. 25 May, 2023 6 commits
  3. 24 May, 2023 7 commits
  4. 23 May, 2023 3 commits
  5. 22 May, 2023 2 commits
  6. 21 May, 2023 3 commits
  7. 20 May, 2023 1 commit
  8. 19 May, 2023 1 commit
  9. 17 May, 2023 4 commits
  10. 16 May, 2023 3 commits
    • Marcin S's avatar
      PVF: Vote invalid on panics in execution thread (after a retry) (#7155) · 9420d7dc
      Marcin S authored
      * PVF: Remove `rayon` and some uses of `tokio`
      1. We were using `rayon` to spawn a superfluous thread to do execution, so it was removed.
      2. We were using `rayon` to set a threadpool-specific thread stack size, and AFAIK we couldn't do that with `tokio` (it's possible [per-runtime](https://docs.rs/tokio/latest/tokio/runtime/struct.Builder.html#method.thread_stack_size) but not per-thread). Since we want to remove `tokio` from the workers [anyway](https://github.com/paritytech/polkadot/issues/7117), I changed it to spawn threads with the `std::thread` API instead of `tokio`.[^1]
      [^1]: NOTE: This PR does not totally remove the `tokio` dependency just yet.
      3. Since `std::thread` API is not async, we could no longer `select!` on the threads as futures, so the `select!` was changed to a naive loop.
      4. The order of thread selection was flipped to make (3) sound (see note in code).
      I left some TODO's related to panics which I'm going to address soon as part of https://github.com/paritytech/polkadot/issues/7045.
      * PVF: Vote invalid on panics in execution thread (after a retry)
      Also make sure we kill the worker process on panic errors and internal errors to
      potentially clear any error states independent of the candidate.
      * Address a couple of TODOs
      Addresses a couple of follow-up TODOs from
      * Add some documentation to implementer's guide
      * Fix compile error
      * Fix compile errors
      * Fix compile error
      * Update roadmap/implementers-guide/src/node/utility/candidate-validation.md
      Co-authored-by: default avatarAndrei Sandu <54316454+sandreim@users.noreply.github.com>
      * Address comments + couple other changes (see message)
      - Measure the CPU time in the prepare thread, so the observed time is not
        affected by any delays in joining on the thread.
      - Measure the full CPU time in the execute thread.
      * Implement proper thread synchronization
      Use condvars i.e. `Arc::new((Mutex::new(true), Condvar::new()))` as per the std
      Considered also using a condvar to signal the CPU thread to end, in place of an
      mpsc channel. This was not done because `Condvar::wait_timeout_while` is
      documented as being imprecise, and `mpsc::Receiver::recv_timeout` is not
      documented as such. Also, we would need a separate condvar, to avoid this case:
      the worker thread finishes its job, notifies the condvar, the CPU thread returns
      first, and we join on it and not the worker thread. So it was simpler to leave
      this part as is.
      * Catch panics in threads so we always notify condvar
      * Use `WaitOutcome` enum instead of bool condition variable
      * Fix retry timeouts to depend on exec timeout kind
      * Address review comments
      * Make the API for condvars in workers nicer
      * Add a doc
      * Use condvar for memory stats thread
      * Small refactor
      * Enumerate internal validation errors in an enum
      * Fix comment
      * Add a log
      * Fix test
      * Update variant naming
      * Address a missed TODO
      Co-authored-by: default avatarAndrei Sandu <54316454+sandreim@users.noreply.github.com>
    • Marcin S's avatar
    • Branislav Kontur's avatar
      [xcm] Foreign global consensus parachain LocationToAccountId converter (#7016) · 19fdd197
      Branislav Kontur authored
      * **Foreign** global consensus parachain LocationToAccount converter
      * Review fix
      * Added `UniversalLocation` + `ensure_is_remote` handling
      * Added unique id to encoding
      * Update xcm/xcm-builder/src/location_conversion.rs
      Co-authored-by: default avatarGavin Wood <gavin@parity.io>
      * Re-export `ensure_is_remote`
      * Test
      * fmt
      * Update xcm/xcm-builder/src/location_conversion.rs
      * Update xcm/xcm-builder/src/universal_exports.rs
      Co-authored-by: default avatarGavin Wood <gavin@parity.io>
      Co-authored-by: parity-processbot <>
      Co-authored-by: default avatarGavin Wood <gavin@parity.io>
  11. 15 May, 2023 3 commits
  12. 13 May, 2023 1 commit
  13. 12 May, 2023 2 commits