1. 06 Oct, 2021 1 commit
    • Bernhard Schuster's avatar
      collect included disputes from on-chain (#3924) · b74335ac
      Bernhard Schuster authored
      
      
      * dummy: impl another runtime API
      
      * query the on chain disputes, and inform self
      
      * make use of the refactor
      
      * minro
      
      * SPLIT ME
      
      * write dispute values
      
      * wip
      
      * impl for all runtimes
      
      * chore: fmt
      
      * [] -> get
      
      * fixup mock runtime
      
      * fixup
      
      * fixup discovery for overseer init
      
      * chore: fmt
      
      * spellcheck
      
      * rename imported_on_chain_disputes -> on_chain_votes
      
      * reduction
      
      * make it mockable
      
      * rename and refactor
      
      * don't query on chain info if it's not needed
      
      * yikes
      
      * fmt
      
      * fix test
      
      * minimal fix for existing tests
      
      * attempt to fetch the session info from the rolling window before falling back
      
      * moved
      
      * comments
      
      * comments
      
      * test for backing votes
      
      * rename
      
      * Update runtime/polkadot/src/lib.rs
      
      * chore: spellcheck + dict
      
      * chore: fmt
      
      * fixup cache size
      
      * add warning
      
      * logging, rationale, less defense
      
      * introduce new unchecked, that still checks in debug builds
      
      * fix
      
      * draft alt approach
      
      * fix unused imports
      
      * include the session
      
      * Update node/core/dispute-coordinator/src/real/mod.rs
      
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      
      * provide where possible
      
      * expand comment
      
      * fixin
      
      * fixup
      
      * ValidityVote <-> ValidityAttestation <-> CompactStatement has a 1:1 representation
      
      * mark TODO
      
      * Update primitives/src/v1/mod.rs
      
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      
      * address review comments
      
      * update docs
      
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      b74335ac
  2. 04 Oct, 2021 1 commit
    • asynchronous rob's avatar
      Make candidate validation timeouts configurable (#4001) · 8962e040
      asynchronous rob authored
      * pvf: make execution timeout configurable
      
      * guide: add timeouts to candidate validation params
      
      * add timeouts to candidate validation messages
      
      * fmt
      
      * port backing to use the backing pvf timeout
      
      * port approval-voting to use the execution timeout
      
      * port dispute participation to use the correct timeout
      
      * fmt
      
      * address grumbles & test failure
      8962e040
  3. 01 Oct, 2021 1 commit
  4. 30 Sep, 2021 1 commit
  5. 29 Sep, 2021 1 commit
    • Bernhard Schuster's avatar
      remove `AllSubsystems` and `AllSubsystemsGen` types (#3874) · e721a5aa
      Bernhard Schuster authored
      
      
      * introduce the OverseerConnector, use it
      
      * introduce is_relay_chain to RelayChainSelection
      
      * Update node/service/src/lib.rs
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      
      * avoid the deferred setting of `is_relay_chain` in `RelayChainSelection`
      
      * positive assertion is not mandated, only the negative one, to avoid a stall
      
      * cleanup: overseer residue
      
      * spellcheck
      
      * fixin
      
      * groundwork to obsolete Overseer::new and AllSubsystemsGen proc-macro
      
      * Now all malus & tests can be ported to the builder pattern.
      
      Obsoletes `Overseer::new`, `AllSubsystemsGen` derive macro, `AllSubsystems`.
      
      * spellcheck
      
      * adjust tests, minor fixes
      
      * remove derive macro AllSubsystemsGen
      
      * add forgotten file dummy.rs
      
      * remove residue
      
      * good news everyone!
      
      * spellcheck
      
      * address review comments
      
      * fixup imports
      
      * make it conditional
      
      * fixup docs
      
      * reduce import
      
      * chore: fmt
      
      * chore: fmt
      
      * chore: spellcheck / nlprules
      
      * fixup malus variant-a
      
      * fmt
      
      * fix
      
      * fixins
      
      * pfmt
      
      * fixins
      
      * chore: fmt
      
      * remove expanded overseer generation
      
      * tracing version
      
      * Update node/network/statement-distribution/src/lib.rs
      
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      
      * use future::ready instead
      
      * silence warning
      
      * chore: fmt
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      e721a5aa
  6. 27 Sep, 2021 1 commit
    • Robert Klotzner's avatar
      Log info about low connectivity and unreachable validators (#3916) · 0c2a0fd9
      Robert Klotzner authored
      * Attempt to add log stats to gossip-support.
      
      * WIP: Keep track of connected validators.
      
      * Clarify metric.
      
      * WIP: Make gossip support report connectivity.
      
      * WIP: Fixing tests.
      
      * Fix network bridge + integrate in overseer.
      
      * Consistent naming.
      
      * Fix logic error
      
      * cargo fmt
      
      * Pretty logs.
      
      * cargo fmt
      
      * Use `Delay` to trigger periodic checks.
      
      * fmt
      
      * Fix warning for authority set size of 1.
      
      * More correct ratio report if there are no resolved validators.
      
      * Prettier rendering of empty set.
      
      * Fix typo.
      
      * Another typo.
      
      * Don't check on every leaf update.
      
      * Make compatible with older rustc.
      
      * Fix tests.
      
      * Demote warning.
      0c2a0fd9
  7. 04 Sep, 2021 1 commit
  8. 01 Sep, 2021 1 commit
  9. 30 Aug, 2021 1 commit
  10. 26 Aug, 2021 1 commit
  11. 19 Aug, 2021 1 commit
  12. 12 Aug, 2021 1 commit
    • Robert Klotzner's avatar
      Remove request multiplexer (#3624) · 117466aa
      Robert Klotzner authored
      * WIP: Get rid of request multiplexer.
      
      * WIP
      
      * Receiver for handling of incoming requests.
      
      * Get rid of useless `Fault` abstraction.
      
      The things the type system let us do are not worth getting abstracted in
      its own type. Instead error handling is going to be merely a pattern.
      
      * Make most things compile again.
      
      * Port availability distribution away from request multiplexer.
      
      * Formatting.
      
      * Port dispute distribution over.
      
      * Fixup statement distribution.
      
      * Handle request directly in collator protocol.
      
      + Only allow fatal errors at top level.
      
      * Use direct request channel for availability recovery.
      
      * Finally get rid of request multiplexer
      
      Fixes #2842 and paves the way for more back pressure possibilities.
      
      * Fix overseer and statement distribution tests.
      
      * Fix collator protocol and network bridge tests.
      
      * Fix tests in availability recovery.
      
      * Fix availability distribution tests.
      
      * Fix dispute distribution tests.
      
      * Add missing dependency
      
      * Typos.
      
      * Review remarks.
      
      * More remarks.
      117466aa
  13. 07 Aug, 2021 1 commit
  14. 06 Aug, 2021 1 commit
  15. 05 Aug, 2021 1 commit
  16. 02 Aug, 2021 1 commit
  17. 27 Jul, 2021 1 commit
  18. 26 Jul, 2021 1 commit
    • Bernhard Schuster's avatar
      integrate dispute finality (#3484) · 7aed7a2e
      Bernhard Schuster authored
      
      
      * finality_target adjustments
      
      * fn finality_target
      
      * partially address review comments
      
      * fixins
      
      * more rustic if condition
      
      * fix tests
      
      * fixins
      
      * Update node/core/approval-voting/src/lib.rs
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      
      * Update node/core/approval-voting/src/lib.rs
      
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      
      * review comments part one
      
      * rename candidates -> block_descriptions
      
      * testing outline (incomplete, WIP)
      
      * test foo
      
      * split RelayChainSelection into RelayChainSelection{,WithFallback}, introduce HeaderProvider{,Provider}
      
      * make some stuff public (revert this soon™)
      
      * some test improvements
      
      * slips of pens
      
      * test fixins
      
      * add another trait abstraction
      
      * pending edge case tests + warnings fixes
      
      * more test cases
      
      * fin
      
      * chore fmt
      
      * fix cargo.lock
      
      * Undo obsolete changes
      
      * // comments
      
      * make mod pub(crate)
      
      * fix
      
      * minimize static bounds
      
      * resolve number() as before
      
      * fmt
      
      * post merge fix
      
      * address some nits
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      7aed7a2e
  19. 14 Jul, 2021 1 commit
    • Denis_P's avatar
      WIP: CI: add spellcheck (#3421) · 8a6af441
      Denis_P authored
      
      
      * CI: add spellcheck
      
      * revert me
      
      * CI: explicit command for spellchecker
      
      * spellcheck: edit misspells
      
      * CI: run spellcheck on diff
      
      * spellcheck: edits
      
      * spellcheck: edit misspells
      
      * spellcheck: add rules
      
      * spellcheck: mv configs
      
      * spellcheck: more edits
      
      * spellcheck: chore
      
      * spellcheck: one more thing
      
      * spellcheck: and another one
      
      * spellcheck: seems like it doesn't get to an end
      
      * spellcheck: new words after rebase
      
      * spellcheck: new words appearing out of nowhere
      
      * chore
      
      * review edits
      
      * more review edits
      
      * more edits
      
      * wonky behavior
      
      * wonky behavior 2
      
      * wonky behavior 3
      
      * change git behavior
      
      * spellcheck: another bunch of new edits
      
      * spellcheck: new words are koming out of nowhere
      
      * CI: finding the master
      
      * CI: fetching master implicitly
      
      * CI: undebug
      
      * new errors
      
      * a bunch of new edits
      
      * and some more
      
      * Update node/core/approval-voting/src/approval_db/v1/mod.rs
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      
      * Update xcm/xcm-executor/src/assets.rs
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      
      * Apply suggestions from code review
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      
      * Suggestions from the code review
      
      * CI: scan only changed files
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      8a6af441
  20. 13 Jul, 2021 1 commit
    • Lldenaurois's avatar
      Dispute Coordinator: Batch queries (#3459) · 6d7f7cc4
      Lldenaurois authored
      * disputes: Allow batch queries in dispute-coordinator
      
      This commit moves to batch queries when responding to QueryCandidateVotes
      messages. This simplifies the code in the provisioner and dispute-coordinator
      by no longer requiring to make use of a FuturesOrdered when awaiting multiple
      quries. Instead, the provisioner need only request the batch itself.
      
      * node/approval-voting: Address Feedback to fail on query element missing.
      
      * Address feedback
      
      * Fix implementer's guide
      6d7f7cc4
  21. 09 Jul, 2021 2 commits
    • asynchronous rob's avatar
      Wire up candidate backing, approval-voting to disputes (#3348) · 567cfb99
      asynchronous rob authored
      * add a from_backing_statement to SignedDisputeStatement
      
      * inform dispute coordinator of all backing statements
      
      * add dispute coordinator message to backing tests
      
      * send positive dispute statement with every approval
      
      * issue disputes when encountering invalid candidates.
      
      * try to fix flaky test for CI (passed locally)
      
      * guide: keep track of concluded-positive disputes until pruned
      
      * guide: block implications
      
      * guide: new dispute inherent flow
      
      * mostly implement recency changes for dispute coordinator
      
      * add a clock to dispute coordinator
      
      * adjust DB tests
      
      * fix and add new dispute coordinator tests
      
      * provisioner: select disputes
      
      * import all validators' approvals
      
      * address nit: refactor backing statement submission
      
      * gracefully handle disconnected dispute coordinator
      
      * remove `review` comment
      
      * fix up old_tests
      
      * fix approval-voting compilation
      
      * fix backing compilation
      
      * use known-leaves in WaitForActivation
      
      * follow-up test fixing
      
      * add back allow(dead_code)
      567cfb99
    • Robert Klotzner's avatar
      Dispute distribution implementation (#3282) · f9d71f8c
      Robert Klotzner authored
      * Dispute protocol.
      
      * Dispute distribution protocol.
      
      * Get network requests routed.
      
      * WIP: Basic dispute sender logic.
      
      * Basic validator determination logic.
      
      * WIP: Getting things to typecheck.
      
      * Slightly larger timeout.
      
      * More typechecking stuff.
      
      * Cleanup.
      
      * Finished most of the sending logic.
      
      * Handle active leaves updates
      
      - Cleanup dead disputes
      - Update sends for new sessions
      - Retry on errors
      
      * Pass sessions in already.
      
      * Startup dispute sending.
      
      * Provide incoming decoding facilities
      
      and use them in statement-distribution.
      
      * Relaxed runtime util requirements.
      
      We only need a `SubsystemSender` not a full `SubsystemContext`.
      
      * Better usability of incoming requests.
      
      Make it possible to consume stuff without clones.
      
      * Add basic receiver functionality.
      
      * Cleanup + fixes for sender.
      
      * One more sender fix.
      
      * Start receiver.
      
      * Make sure to send responses back.
      
      * WIP: Exposed authority discovery
      
      * Make tests pass.
      
      * Fully featured receiver.
      
      * Decrease cost of `NotAValidator`.
      
      * Make `RuntimeInfo` LRU cache size configurable.
      
      * Cache more sessions.
      
      * Fix collator protocol.
      
      * Disable metrics for now.
      
      * Make dispute-distribution a proper subsystem.
      
      * Fix naming.
      
      * Code style fixes.
      
      * Factored out 4x copied mock function.
      
      * WIP: Tests.
      
      * Whitespace cleanup.
      
      * Accessor functions.
      
      * More testing.
      
      * More Debug instances.
      
      * Fix busy loop.
      
      * Working tests.
      
      * More tests.
      
      * Cleanup.
      
      * Fix build.
      
      * Basic receiving test.
      
      * Non validator message gets dropped.
      
      * More receiving tests.
      
      * Test nested and subsequent imports.
      
      * Fix spaces.
      
      * Better formatted imports.
      
      * Import cleanup.
      
      * Metrics.
      
      * Message -> MuxedMessage
      
      * Message -> MuxedMessage
      
      * More review remarks.
      
      * Add missing metrics.rs.
      
      * Fix flaky test.
      
      * Dispute coordinator - deliver confirmations.
      
      * Send out `DisputeMessage` on issue local statement.
      
      * Unwire dispute distribution.
      
      * Review remarks.
      
      * Review remarks.
      
      * Better docs.
      f9d71f8c
  22. 08 Jul, 2021 1 commit