1. 16 Sep, 2021 1 commit
  2. 08 Sep, 2021 1 commit
  3. 01 Sep, 2021 1 commit
  4. 19 Aug, 2021 1 commit
  5. 06 Aug, 2021 1 commit
  6. 05 Aug, 2021 1 commit
  7. 02 Aug, 2021 1 commit
  8. 26 Jul, 2021 1 commit
    • Bernhard Schuster's avatar
      integrate dispute finality (#3484) · 7aed7a2e
      Bernhard Schuster authored
      * finality_target adjustments
      * fn finality_target
      * partially address review comments
      * fixins
      * more rustic if condition
      * fix tests
      * fixins
      * Update node/core/approval-voting/src/lib.rs
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      * Update node/core/approval-voting/src/lib.rs
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      * review comments part one
      * rename candidates -> block_descriptions
      * testing outline (incomplete, WIP)
      * test foo
      * split RelayChainSelection into RelayChainSelection{,WithFallback}, introduce HeaderProvider{,Provider}
      * make some stuff public (revert this soon™)
      * some test improvements
      * slips of pens
      * test fixins
      * add another trait abstraction
      * pending edge case tests + warnings fixes
      * more test cases
      * fin
      * chore fmt
      * fix cargo.lock
      * Undo obsolete changes
      * // comments
      * make mod pub(crate)
      * fix
      * minimize static bounds
      * resolve number() as before
      * fmt
      * post merge fix
      * address some nits
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
  9. 21 Jul, 2021 1 commit
    • Lldenaurois's avatar
      Dispute coordinator - Recover disputes on startup (#3481) · cc6ef8cb
      Lldenaurois authored
      * node/dispute-coordinator: Introduce resume capability
      This commit introduces a resume capability for the
      dispute coordinator subsystem. Specifically, this will allow
      to recover data for disputes for which we have no local statements.
      * node/dispute-coordinator: Add resume function to TestState and modify Harness
      This commit modifies the TestHarness to return a TestState. We subsequently
      define a resume function on TestState that allows to interrupt the test and
      test specifically for behavior on startup of the subsystem.
      * node/dispute-coordinator: Implement resume functionality
      This commit implements the resume functionality for the subsystem.
      In addition, we will forward any DisputeParticipation::Participate
      message in order to ensure that disputes for which we do not have
      local statements may be recovered in due time.
      * Address Feedback
      * Modify to run handle_leaf on first import
      * Modify missing_local_statement logic
      * node/dispute-coordinator: Add simple test to ensure we adequately
      handle local_statements that are not missing.
      * Add missing keystore tests
  10. 14 Jul, 2021 1 commit
    • Denis_P's avatar
      WIP: CI: add spellcheck (#3421) · 8a6af441
      Denis_P authored
      * CI: add spellcheck
      * revert me
      * CI: explicit command for spellchecker
      * spellcheck: edit misspells
      * CI: run spellcheck on diff
      * spellcheck: edits
      * spellcheck: edit misspells
      * spellcheck: add rules
      * spellcheck: mv configs
      * spellcheck: more edits
      * spellcheck: chore
      * spellcheck: one more thing
      * spellcheck: and another one
      * spellcheck: seems like it doesn't get to an end
      * spellcheck: new words after rebase
      * spellcheck: new words appearing out of nowhere
      * chore
      * review edits
      * more review edits
      * more edits
      * wonky behavior
      * wonky behavior 2
      * wonky behavior 3
      * change git behavior
      * spellcheck: another bunch of new edits
      * spellcheck: new words are koming out of nowhere
      * CI: finding the master
      * CI: fetching master implicitly
      * CI: undebug
      * new errors
      * a bunch of new edits
      * and some more
      * Update node/core/approval-voting/src/approval_db/v1/mod.rs
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      * Update xcm/xcm-executor/src/assets.rs
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      * Apply suggestions from code review
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      * Suggestions from the code review
      * CI: scan only changed files
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
  11. 13 Jul, 2021 2 commits
    • Lldenaurois's avatar
      Dispute coordinator overlay (#3462) · a08a663e
      Lldenaurois authored
      * node/dispute-coordinator: Modify db to return SubsystemResult.
      In preparation of moving to the overlayed backend pattern, this commit
      moves the db to return SubsystemResult values.
      * node/dispute-coordinator: Add the Backend and OverlayedBackend.
      This commit adds the backend and overlayed backend structs to the
      dispute-coordinator subsystem.
      * node/dispute-coordinator: Implement backend and overlayed-backend.
      This commit finalizes the move from the previous transactional model
      to the common overlay pattern in subsystem persistency. This can be
      observed in the ApprovalVoting and ChainSelection subsystems.
      * Add module docs + license
      * Touchup merge
    • Lldenaurois's avatar
      Dispute Coordinator: Batch queries (#3459) · 6d7f7cc4
      Lldenaurois authored
      * disputes: Allow batch queries in dispute-coordinator
      This commit moves to batch queries when responding to QueryCandidateVotes
      messages. This simplifies the code in the provisioner and dispute-coordinator
      by no longer requiring to make use of a FuturesOrdered when awaiting multiple
      quries. Instead, the provisioner need only request the batch itself.
      * node/approval-voting: Address Feedback to fail on query element missing.
      * Address feedback
      * Fix implementer's guide
  12. 09 Jul, 2021 2 commits
    • asynchronous rob's avatar
      Wire up candidate backing, approval-voting to disputes (#3348) · 567cfb99
      asynchronous rob authored
      * add a from_backing_statement to SignedDisputeStatement
      * inform dispute coordinator of all backing statements
      * add dispute coordinator message to backing tests
      * send positive dispute statement with every approval
      * issue disputes when encountering invalid candidates.
      * try to fix flaky test for CI (passed locally)
      * guide: keep track of concluded-positive disputes until pruned
      * guide: block implications
      * guide: new dispute inherent flow
      * mostly implement recency changes for dispute coordinator
      * add a clock to dispute coordinator
      * adjust DB tests
      * fix and add new dispute coordinator tests
      * provisioner: select disputes
      * import all validators' approvals
      * address nit: refactor backing statement submission
      * gracefully handle disconnected dispute coordinator
      * remove `review` comment
      * fix up old_tests
      * fix approval-voting compilation
      * fix backing compilation
      * use known-leaves in WaitForActivation
      * follow-up test fixing
      * add back allow(dead_code)
    • Robert Klotzner's avatar
      Dispute distribution implementation (#3282) · f9d71f8c
      Robert Klotzner authored
      * Dispute protocol.
      * Dispute distribution protocol.
      * Get network requests routed.
      * WIP: Basic dispute sender logic.
      * Basic validator determination logic.
      * WIP: Getting things to typecheck.
      * Slightly larger timeout.
      * More typechecking stuff.
      * Cleanup.
      * Finished most of the sending logic.
      * Handle active leaves updates
      - Cleanup dead disputes
      - Update sends for new sessions
      - Retry on errors
      * Pass sessions in already.
      * Startup dispute sending.
      * Provide incoming decoding facilities
      and use them in statement-distribution.
      * Relaxed runtime util requirements.
      We only need a `SubsystemSender` not a full `SubsystemContext`.
      * Better usability of incoming requests.
      Make it possible to consume stuff without clones.
      * Add basic receiver functionality.
      * Cleanup + fixes for sender.
      * One more sender fix.
      * Start receiver.
      * Make sure to send responses back.
      * WIP: Exposed authority discovery
      * Make tests pass.
      * Fully featured receiver.
      * Decrease cost of `NotAValidator`.
      * Make `RuntimeInfo` LRU cache size configurable.
      * Cache more sessions.
      * Fix collator protocol.
      * Disable metrics for now.
      * Make dispute-distribution a proper subsystem.
      * Fix naming.
      * Code style fixes.
      * Factored out 4x copied mock function.
      * WIP: Tests.
      * Whitespace cleanup.
      * Accessor functions.
      * More testing.
      * More Debug instances.
      * Fix busy loop.
      * Working tests.
      * More tests.
      * Cleanup.
      * Fix build.
      * Basic receiving test.
      * Non validator message gets dropped.
      * More receiving tests.
      * Test nested and subsequent imports.
      * Fix spaces.
      * Better formatted imports.
      * Import cleanup.
      * Metrics.
      * Message -> MuxedMessage
      * Message -> MuxedMessage
      * More review remarks.
      * Add missing metrics.rs.
      * Fix flaky test.
      * Dispute coordinator - deliver confirmations.
      * Send out `DisputeMessage` on issue local statement.
      * Unwire dispute distribution.
      * Review remarks.
      * Review remarks.
      * Better docs.
  13. 08 Jul, 2021 1 commit
  14. 14 Jun, 2021 1 commit
  15. 13 Jun, 2021 1 commit
    • asynchronous rob's avatar
      Dispute Coordinator Subsystem (#3150) · 19c1d29d
      asynchronous rob authored
      * skeleton for dispute-coordinator
      * add coordinator and participation message types
      * begin dispute-coordinator DB
      * functions for loading
      * implement strongly-typed DB transaction
      * add some tests for DB transaction
      * core logic for pruning
      * guide: update candidate-votes key for coordinator
      * update candidate-votes key
      * use big-endian encoding for session, and implement upper bound generator
      * finish implementing pruning
      * add a test for note_current_session
      * define state of the subsystem itself
      * barebones subsystem definition
      * control flow
      * more control flow
      * implement session-updating logic
      * trace
      * control flow for message handling
      * Update node/core/dispute-coordinator/src/lib.rs
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      * Update node/subsystem/src/messages.rs
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      * some more control flow
      * guide: remove overlay
      * more control flow
      * implement some DB getters
      * make progress on importing statements
      * add SignedDisputeStatement struct
      * move ApprovalVote to shared primitives
      * add a signing-payload API to explicit dispute statements
      * add signing-payload to CompactStatement
      * add relay-parent hash to seconded/valid dispute variatns
      * correct import
      * type-safe wrapper around dispute statements
      * use checked dispute statement in message type
      * extract rolling session window cache to subsystem-util
      * extract session window tests
      * approval-voting: use rolling session info cache
      * reduce dispute window to match runtime in practice
      * add byzantine_threshold and supermajority_threshold utilities to primitives
      * integrate rolling session window
      * Add PartialOrd to CandidateHash
      * add Ord to CandidateHash
      * implement active dispute update
      * add dispute messages to AllMessages
      * add dispute stubs to overseer
      * inform dispute participation to participate
      * implement issue_local_statement
      * implement `determine_undisputed_chain`
      * fix warnings
      * test harness for dispute coordinator tests
      * add more helpers to test harness
      * add some more helpers
      * some tests for dispute coordinator
      * ignore wrong validator indices
      * test finality voting rule constraint
      * add more tests
      * add variants to network bridge
      * fix test compilation
      * remove most dispute coordinator functionality
      as of #3222 we can do most of the work within the approval voting subsystem
      * Revert "remove most dispute coordinator functionality"
      This reverts commit 9cd615e8
      * Use thiserror
      Co-authored-by: default avatarBernhard Schuster <bernhard@ahoi.io>
      * Update node/core/dispute-coordinator/src/lib.rs
      Co-authored-by: default avatarBernhard Schuster <bernhard@ahoi.io>
      * extract tests to separate module
      * address nit
      * adjust run_iteration API
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      Co-authored-by: default avatarBernhard Schuster <bernhard@ahoi.io>