1. 19 Jun, 2021 4 commits
    • Andronik Ordian's avatar
      network-bridge: remove action_sink abstraction (#3308) · 5fae68e6
      Andronik Ordian authored
      * network-bridge: remove action_sink abstraction
      
      * another wtf
      
      * filter out event stream
      
      * Revert "filter out event stream"
      
      This reverts commit 63bd8f5d.
      
      * retain cleanup though
      5fae68e6
    • asynchronous rob's avatar
      Block weight ChainAPI (#3301) · 122734f1
      asynchronous rob authored
      
      
      * guide: ChainApiMessage::BlockWeight
      
      * node: BlockWeight ChainAPI
      
      * fix compile issue
      
      * implement ChainApi::BlockWeight
      
      * add test for ChainApi::BlockWeight
      
      * update substrate
      
      Co-authored-by: default avatarAndré Silva <andrerfosilva@gmail.com>
      122734f1
    • Andreas Doerr's avatar
      Bump BEEFY (#3302) · 7ab51d45
      Andreas Doerr authored
      7ab51d45
    • Lldenaurois's avatar
      Follow-up PR: Count no-shows (#3309) · 06040c81
      Lldenaurois authored
      * node/approval-voting: test for invalid validator index in assignments
      
      This commit adds a unit test to show that, currently, validator indexes
      greater than n_validators (or the length of the approvals bitvector) are
      counted in n_assignments. In the subsequent commit we will correct this
      behavior.
      
      * node/approval-voting: ignore invalid validator indexes in n_assignments
      
      This commit ignores any validator assignments whose index is beyond
      n_validators. Without this check, an improperly crafted assignment would
      be counted towards the approval.
      
      It still remains that n_assignments and count_no_shows inspect the
      number of validators and approvals, respectively. Ideally we would
      add greater safety around ensuring these two values cannot differ.
      06040c81
  2. 18 Jun, 2021 2 commits
  3. 17 Jun, 2021 3 commits
    • Lldenaurois's avatar
      Extract and test count_no_shows method for approval voting (#3264) · a968261a
      Lldenaurois authored
      * node/approval-voting: extract and test count_no_shows method
      
      This commit extracts no_show computation into a pure function so that it can be
      extensively unit tested.
      
      * node/approval-voting: ignore invalid validator indexes in count_no_show
      
      Previously indexes that were past the length of the approvals bitvector
      would contribute to the no_show count or the next_no_show value. This
      commit changes the behavior to ignore garbage values.
      
      * node/approval-voting: add comment for next_no_show adding clock_drift
      a968261a
    • Andronik Ordian's avatar
      cleanup more tests and spaces (#3288) · 8b7862b4
      Andronik Ordian authored
      * cleanup more tests and spaces
      
      * oops
      8b7862b4
    • Zeke Mostov's avatar
      Companion #9019 (max rpc payload override) (#3276) · 36d30d0f
      Zeke Mostov authored
      * Companion #9019 (max rpc payload override)
      
      * update Substrate
      
      Co-authored-by: parity-processbot <>
      36d30d0f
  4. 16 Jun, 2021 3 commits
    • asynchronous rob's avatar
      extract determine_new_blocks into a separate utility (#3261) · c3da55c8
      asynchronous rob authored
      * extract determine_new_blocks into a separate utility
      
      * rework docs
      c3da55c8
    • Lldenaurois's avatar
      Approval checking unit tests (#3252) · dd2e858b
      Lldenaurois authored
      * node/approval_checking: break out filled_tranch_iterator method
      
      In the subsequent commit, we will begin to test this method in
      isolation.
      
      * node/approval-voting: fix tranche back-filling algorithm
      
      Previously, this algorithm would generate duplicate, empty entries for
      tranches (1..pre_end). This is caused because the initial value (0) for
      gap_end is treated as the end of a prior tranche that wasn't actually
      processed. The first pass thus would add (1..tranche) empty entries, in
      addition to the (0..pre_end) empty entries chained at the end of the
      method.
      
      This is fixed by using the current tranche as the gap_start for the
      first iteration, ensuring that the approval_entries_filled only produces
      entries in the range (pre_end..post_start).
      
      * Address feedback
      dd2e858b
    • Bernhard Schuster's avatar
      malus - mockable overseer mvp (#3224) · 395324a5
      Bernhard Schuster authored
      395324a5
  5. 15 Jun, 2021 2 commits
  6. 14 Jun, 2021 4 commits
  7. 13 Jun, 2021 4 commits
    • Andronik Ordian's avatar
      approval votes checking logs (#3233) · dd26f19e
      Andronik Ordian authored
      * approval-voting: logs for invalid votes
      
      * proper errors for assignment checks
      
      * proper errors for approval checks
      dd26f19e
    • asynchronous rob's avatar
      6d2d80d9
    • asynchronous rob's avatar
      ef0fdf42
    • asynchronous rob's avatar
      Dispute Coordinator Subsystem (#3150) · 19c1d29d
      asynchronous rob authored
      
      
      * skeleton for dispute-coordinator
      
      * add coordinator and participation message types
      
      * begin dispute-coordinator DB
      
      * functions for loading
      
      * implement strongly-typed DB transaction
      
      * add some tests for DB transaction
      
      * core logic for pruning
      
      * guide: update candidate-votes key for coordinator
      
      * update candidate-votes key
      
      * use big-endian encoding for session, and implement upper bound generator
      
      * finish implementing pruning
      
      * add a test for note_current_session
      
      * define state of the subsystem itself
      
      * barebones subsystem definition
      
      * control flow
      
      * more control flow
      
      * implement session-updating logic
      
      * trace
      
      * control flow for message handling
      
      * Update node/core/dispute-coordinator/src/lib.rs
      
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      
      * Update node/subsystem/src/messages.rs
      
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      
      * some more control flow
      
      * guide: remove overlay
      
      * more control flow
      
      * implement some DB getters
      
      * make progress on importing statements
      
      * add SignedDisputeStatement struct
      
      * move ApprovalVote to shared primitives
      
      * add a signing-payload API to explicit dispute statements
      
      * add signing-payload to CompactStatement
      
      * add relay-parent hash to seconded/valid dispute variatns
      
      * correct import
      
      * type-safe wrapper around dispute statements
      
      * use checked dispute statement in message type
      
      * extract rolling session window cache to subsystem-util
      
      * extract session window tests
      
      * approval-voting: use rolling session info cache
      
      * reduce dispute window to match runtime in practice
      
      * add byzantine_threshold and supermajority_threshold utilities to primitives
      
      * integrate rolling session window
      
      * Add PartialOrd to CandidateHash
      
      * add Ord to CandidateHash
      
      * implement active dispute update
      
      * add dispute messages to AllMessages
      
      * add dispute stubs to overseer
      
      * inform dispute participation to participate
      
      * implement issue_local_statement
      
      * implement `determine_undisputed_chain`
      
      * fix warnings
      
      * test harness for dispute coordinator tests
      
      * add more helpers to test harness
      
      * add some more helpers
      
      * some tests for dispute coordinator
      
      * ignore wrong validator indices
      
      * test finality voting rule constraint
      
      * add more tests
      
      * add variants to network bridge
      
      * fix test compilation
      
      * remove most dispute coordinator functionality
      
      as of #3222 we can do most of the work within the approval voting subsystem
      
      * Revert "remove most dispute coordinator functionality"
      
      This reverts commit 9cd615e8
      
      .
      
      * Use thiserror
      
      Co-authored-by: default avatarBernhard Schuster <bernhard@ahoi.io>
      
      * Update node/core/dispute-coordinator/src/lib.rs
      
      Co-authored-by: default avatarBernhard Schuster <bernhard@ahoi.io>
      
      * extract tests to separate module
      
      * address nit
      
      * adjust run_iteration API
      
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      Co-authored-by: default avatarBernhard Schuster <bernhard@ahoi.io>
      19c1d29d
  8. 12 Jun, 2021 4 commits
  9. 11 Jun, 2021 5 commits
  10. 09 Jun, 2021 4 commits
  11. 08 Jun, 2021 3 commits
    • Bastian Köcher's avatar
      polkadot-service: Make native runtime configurable (#3189) · f5971628
      Bastian Köcher authored
      * polkadot-service: Make native runtime configurable
      
      This pull requests adds support for configuring the native runtimes used
      by polkadot-service. While this whole pr doesn't change that much for
      polkadot, besides not having the light-node enabled for the default
      polkadot binary. However, downstream projects (parachains) will have a
      much better compile time. In cumulus for example the `cargo test --all
      --release` is about 4m faster to compile.
      
      * Fixes
      
      * Fix
      
      * Enable rococo-native
      
      * Fix light client
      
      * 🤦
      
      * Fixes
      f5971628
    • Lldenaurois's avatar
      Remove candidate selection (#3148) · a4dfdf16
      Lldenaurois authored
      * Create validator_side module
      
      * Subsume Candidate Selection
      
      * Add test to ensure candidate backing logic is correct
      
      * Ensure secondings are adequately cleaned up and address test flakyness
      
      * Address Feedback
      a4dfdf16
    • Niklas Adolfsson's avatar
      Companion for #9036 (#3191) · a81f78f4
      Niklas Adolfsson authored
      * deps: cargo update -p rustls
      
      * fix build
      
      * update Substrate
      
      Co-authored-by: parity-processbot <>
      a81f78f4
  12. 07 Jun, 2021 1 commit
  13. 04 Jun, 2021 1 commit