1. 26 Aug, 2021 1 commit
  2. 25 Aug, 2021 1 commit
  3. 24 Aug, 2021 2 commits
  4. 20 Aug, 2021 2 commits
  5. 19 Aug, 2021 3 commits
  6. 16 Aug, 2021 1 commit
  7. 13 Aug, 2021 2 commits
  8. 08 Aug, 2021 1 commit
  9. 07 Aug, 2021 2 commits
  10. 06 Aug, 2021 2 commits
  11. 05 Aug, 2021 1 commit
  12. 04 Aug, 2021 1 commit
    • Lldenaurois's avatar
      node/approval-voting: Continue to migrate tests to subsystem tests (#3471) · b900c5a8
      Lldenaurois authored
      * node/approval-voting: Continue to migrate tests to subsystem tests
      
      * node/approval-voting: Continue to implement subsystem tests.
      
      * Add more tests
      
      * node/approval-voting: Add more tests
      
      * node/approval-voting: Difficuly determining the proper test scenario for threshold tests
      
      * node/approval-voting: Introduce should_trigger_assignment tests
      
      * node/approval-voting: Finalize threshold tests
      
      * node/approval-voting: Address Feedback and add comments
      
      * node/approval-voting: Tidy up approval tests
      
      * Tidy up tests
      
      * Fix rustfmt
      b900c5a8
  13. 02 Aug, 2021 2 commits
  14. 27 Jul, 2021 1 commit
  15. 26 Jul, 2021 2 commits
    • Bernhard Schuster's avatar
      integrate dispute finality (#3484) · 7aed7a2e
      Bernhard Schuster authored
      
      
      * finality_target adjustments
      
      * fn finality_target
      
      * partially address review comments
      
      * fixins
      
      * more rustic if condition
      
      * fix tests
      
      * fixins
      
      * Update node/core/approval-voting/src/lib.rs
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      
      * Update node/core/approval-voting/src/lib.rs
      
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      
      * review comments part one
      
      * rename candidates -> block_descriptions
      
      * testing outline (incomplete, WIP)
      
      * test foo
      
      * split RelayChainSelection into RelayChainSelection{,WithFallback}, introduce HeaderProvider{,Provider}
      
      * make some stuff public (revert this soon™)
      
      * some test improvements
      
      * slips of pens
      
      * test fixins
      
      * add another trait abstraction
      
      * pending edge case tests + warnings fixes
      
      * more test cases
      
      * fin
      
      * chore fmt
      
      * fix cargo.lock
      
      * Undo obsolete changes
      
      * // comments
      
      * make mod pub(crate)
      
      * fix
      
      * minimize static bounds
      
      * resolve number() as before
      
      * fmt
      
      * post merge fix
      
      * address some nits
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      7aed7a2e
    • Andronik Ordian's avatar
      enable disputes (#3478) · 2d197804
      Andronik Ordian authored
      
      
      * initial integration and migration code
      
      * fix tests
      
      * fix counting test
      
      * assume the current version on missing file
      
      * use SelectRelayChain
      
      * remove duplicate metric
      
      * Update node/service/src/lib.rs
      
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      
      * remove ApprovalCheckingVotingRule
      
      * address my concern
      
      * never mode for StagnantCheckInterval
      
      * REVERTME: some logs
      
      * w00t
      
      * it's ugly but it works
      
      * Revert "REVERTME: some logs"
      
      This reverts commit e210505a
      
      .
      
      * it's handle, not handler
      
      * fix a few typos
      
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      2d197804
  16. 21 Jul, 2021 1 commit
    • Lldenaurois's avatar
      Dispute coordinator - Recover disputes on startup (#3481) · cc6ef8cb
      Lldenaurois authored
      * node/dispute-coordinator: Introduce resume capability
      
      This commit introduces a resume capability for the
      dispute coordinator subsystem. Specifically, this will allow
      to recover data for disputes for which we have no local statements.
      
      * node/dispute-coordinator: Add resume function to TestState and modify Harness
      
      This commit modifies the TestHarness to return a TestState. We subsequently
      define a resume function on TestState that allows to interrupt the test and
      test specifically for behavior on startup of the subsystem.
      
      * node/dispute-coordinator: Implement resume functionality
      
      This commit implements the resume functionality for the subsystem.
      In addition, we will forward any DisputeParticipation::Participate
      message in order to ensure that disputes for which we do not have
      local statements may be recovered in due time.
      
      * Address Feedback
      
      * Modify to run handle_leaf on first import
      
      * Modify missing_local_statement logic
      
      * node/dispute-coordinator: Add simple test to ensure we adequately
      handle local_statements that are not missing.
      
      * Add missing keystore tests
      cc6ef8cb
  17. 19 Jul, 2021 2 commits
  18. 14 Jul, 2021 1 commit
    • Denis_P's avatar
      WIP: CI: add spellcheck (#3421) · 8a6af441
      Denis_P authored
      
      
      * CI: add spellcheck
      
      * revert me
      
      * CI: explicit command for spellchecker
      
      * spellcheck: edit misspells
      
      * CI: run spellcheck on diff
      
      * spellcheck: edits
      
      * spellcheck: edit misspells
      
      * spellcheck: add rules
      
      * spellcheck: mv configs
      
      * spellcheck: more edits
      
      * spellcheck: chore
      
      * spellcheck: one more thing
      
      * spellcheck: and another one
      
      * spellcheck: seems like it doesn't get to an end
      
      * spellcheck: new words after rebase
      
      * spellcheck: new words appearing out of nowhere
      
      * chore
      
      * review edits
      
      * more review edits
      
      * more edits
      
      * wonky behavior
      
      * wonky behavior 2
      
      * wonky behavior 3
      
      * change git behavior
      
      * spellcheck: another bunch of new edits
      
      * spellcheck: new words are koming out of nowhere
      
      * CI: finding the master
      
      * CI: fetching master implicitly
      
      * CI: undebug
      
      * new errors
      
      * a bunch of new edits
      
      * and some more
      
      * Update node/core/approval-voting/src/approval_db/v1/mod.rs
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      
      * Update xcm/xcm-executor/src/assets.rs
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      
      * Apply suggestions from code review
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      
      * Suggestions from the code review
      
      * CI: scan only changed files
      
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      8a6af441
  19. 13 Jul, 2021 2 commits
    • Lldenaurois's avatar
      Dispute coordinator overlay (#3462) · a08a663e
      Lldenaurois authored
      * node/dispute-coordinator: Modify db to return SubsystemResult.
      
      In preparation of moving to the overlayed backend pattern, this commit
      moves the db to return SubsystemResult values.
      
      * node/dispute-coordinator: Add the Backend and OverlayedBackend.
      
      This commit adds the backend and overlayed backend structs to the
      dispute-coordinator subsystem.
      
      * node/dispute-coordinator: Implement backend and overlayed-backend.
      
      This commit finalizes the move from the previous transactional model
      to the common overlay pattern in subsystem persistency. This can be
      observed in the ApprovalVoting and ChainSelection subsystems.
      
      * Add module docs + license
      
      * Touchup merge
      a08a663e
    • Lldenaurois's avatar
      Dispute Coordinator: Batch queries (#3459) · 6d7f7cc4
      Lldenaurois authored
      * disputes: Allow batch queries in dispute-coordinator
      
      This commit moves to batch queries when responding to QueryCandidateVotes
      messages. This simplifies the code in the provisioner and dispute-coordinator
      by no longer requiring to make use of a FuturesOrdered when awaiting multiple
      quries. Instead, the provisioner need only request the batch itself.
      
      * node/approval-voting: Address Feedback to fail on query element missing.
      
      * Address feedback
      
      * Fix implementer's guide
      6d7f7cc4
  20. 12 Jul, 2021 1 commit
  21. 09 Jul, 2021 3 commits
    • asynchronous rob's avatar
      Wire up candidate backing, approval-voting to disputes (#3348) · 567cfb99
      asynchronous rob authored
      * add a from_backing_statement to SignedDisputeStatement
      
      * inform dispute coordinator of all backing statements
      
      * add dispute coordinator message to backing tests
      
      * send positive dispute statement with every approval
      
      * issue disputes when encountering invalid candidates.
      
      * try to fix flaky test for CI (passed locally)
      
      * guide: keep track of concluded-positive disputes until pruned
      
      * guide: block implications
      
      * guide: new dispute inherent flow
      
      * mostly implement recency changes for dispute coordinator
      
      * add a clock to dispute coordinator
      
      * adjust DB tests
      
      * fix and add new dispute coordinator tests
      
      * provisioner: select disputes
      
      * import all validators' approvals
      
      * address nit: refactor backing statement submission
      
      * gracefully handle disconnected dispute coordinator
      
      * remove `review` comment
      
      * fix up old_tests
      
      * fix approval-voting compilation
      
      * fix backing compilation
      
      * use known-leaves in WaitForActivation
      
      * follow-up test fixing
      
      * add back allow(dead_code)
      567cfb99
    • Bernhard Schuster's avatar
      thiserror annotations + spelling (#3452) · e82782c6
      Bernhard Schuster authored
      * remove duplicate thiserror annotations
      
      * chore: cargo spellcheck
      e82782c6
    • Robert Klotzner's avatar
      Dispute distribution implementation (#3282) · f9d71f8c
      Robert Klotzner authored
      * Dispute protocol.
      
      * Dispute distribution protocol.
      
      * Get network requests routed.
      
      * WIP: Basic dispute sender logic.
      
      * Basic validator determination logic.
      
      * WIP: Getting things to typecheck.
      
      * Slightly larger timeout.
      
      * More typechecking stuff.
      
      * Cleanup.
      
      * Finished most of the sending logic.
      
      * Handle active leaves updates
      
      - Cleanup dead disputes
      - Update sends for new sessions
      - Retry on errors
      
      * Pass sessions in already.
      
      * Startup dispute sending.
      
      * Provide incoming decoding facilities
      
      and use them in statement-distribution.
      
      * Relaxed runtime util requirements.
      
      We only need a `SubsystemSender` not a full `SubsystemContext`.
      
      * Better usability of incoming requests.
      
      Make it possible to consume stuff without clones.
      
      * Add basic receiver functionality.
      
      * Cleanup + fixes for sender.
      
      * One more sender fix.
      
      * Start receiver.
      
      * Make sure to send responses back.
      
      * WIP: Exposed authority discovery
      
      * Make tests pass.
      
      * Fully featured receiver.
      
      * Decrease cost of `NotAValidator`.
      
      * Make `RuntimeInfo` LRU cache size configurable.
      
      * Cache more sessions.
      
      * Fix collator protocol.
      
      * Disable metrics for now.
      
      * Make dispute-distribution a proper subsystem.
      
      * Fix naming.
      
      * Code style fixes.
      
      * Factored out 4x copied mock function.
      
      * WIP: Tests.
      
      * Whitespace cleanup.
      
      * Accessor functions.
      
      * More testing.
      
      * More Debug instances.
      
      * Fix busy loop.
      
      * Working tests.
      
      * More tests.
      
      * Cleanup.
      
      * Fix build.
      
      * Basic receiving test.
      
      * Non validator message gets dropped.
      
      * More receiving tests.
      
      * Test nested and subsequent imports.
      
      * Fix spaces.
      
      * Better formatted imports.
      
      * Import cleanup.
      
      * Metrics.
      
      * Message -> MuxedMessage
      
      * Message -> MuxedMessage
      
      * More review remarks.
      
      * Add missing metrics.rs.
      
      * Fix flaky test.
      
      * Dispute coordinator - deliver confirmations.
      
      * Send out `DisputeMessage` on issue local statement.
      
      * Unwire dispute distribution.
      
      * Review remarks.
      
      * Review remarks.
      
      * Better docs.
      f9d71f8c
  22. 08 Jul, 2021 3 commits
    • Bernhard Schuster's avatar
    • Lldenaurois's avatar
      Approval voting full subsystem tests (#3391) · d80f8489
      Lldenaurois authored
      * node/approval-voting: Introduce Backend trait and Overlaybackend
      
      This commit introduces a Backend trait and attempts to move away
      from the Action model via an OverlayBackend as in the ChainSelection
      subsystem.
      
      * node/approval-voting: Add WriteOps for StoredBlockRange and BlocksAtHeight
      
      * node/approval-voting: Add load_all_blocks to overlay
      
      * node/approval-voting: Get all module tests to pass.
      
      This commit modifies all tests to ensure tests are passing.
      
      * node/approval-voting: Address oversights in the previous commit
      
      This commit addresses some oversights in the prior commit.
      
      1. Inner errors in backend.write were swallowed
      2. One-off write functions removed to avoid useless abstraction
      3. Touch-ups in general
      
      * node/approval-voting: Move from TestDB to dyn KeyValueDB
      
      This commit removes the TestDB from tests.rs and replaces it with
      an in-memory kvdb.
      
      * node/approval-voting: Address feedback
      
      * node/approval-voting: Add license to ops.rs
      
      * node/approval-voting: Address second-pass feedback
      
      * Add TODO
      
      * node/approval-voting: Bump spec_version
      
      * node/approval-voting: Address final comments.
      
      * node/approval-voting: Introduce framework for full subsystem tests
      
      * node/approval-voting: Introduce basic tests to attempt to provide
      coverage via full subsystem tests
      
      * node/approval-voting: Introduce Chainbuilder
      d80f8489
    • Lldenaurois's avatar
      Approval voting overlay db (#3366) · 69c860d7
      Lldenaurois authored
      * node/approval-voting: Introduce Backend trait and Overlaybackend
      
      This commit introduces a Backend trait and attempts to move away
      from the Action model via an OverlayBackend as in the ChainSelection
      subsystem.
      
      * node/approval-voting: Add WriteOps for StoredBlockRange and BlocksAtHeight
      
      * node/approval-voting: Add load_all_blocks to overlay
      
      * node/approval-voting: Get all module tests to pass.
      
      This commit modifies all tests to ensure tests are passing.
      
      * node/approval-voting: Address oversights in the previous commit
      
      This commit addresses some oversights in the prior commit.
      
      1. Inner errors in backend.write were swallowed
      2. One-off write functions removed to avoid useless abstraction
      3. Touch-ups in general
      
      * node/approval-voting: Move from TestDB to dyn KeyValueDB
      
      This commit removes the TestDB from tests.rs and replaces it with
      an in-memory kvdb.
      
      * node/approval-voting: Address feedback
      
      * node/approval-voting: Add license to ops.rs
      
      * node/approval-voting: Address second-pass feedback
      
      * Add TODO
      
      * node/approval-voting: Bump spec_version
      
      * node/approval-voting: Address final comments.
      69c860d7
  23. 07 Jul, 2021 3 commits