1. 26 Nov, 2021 2 commits
    • Sergey Pepyakin's avatar
      Impose new restrictions on paras init and cleanup (#4360) · 62915a68
      Sergey Pepyakin authored
      * Impose new restrictions on paras init and cleanup
      
      For upcoming PVF pre-checking feature we will need to impose a couple of
      new restrictions for:
      
      - `schedule_para_initialize`.
      - `schedule_para_cleanup`.
      
      Specifically, for the former we do not want to allow registration of
      wasm blob that is empty, i.e. 0 bytes. While that currently already
      does not make a lot of sense, it allows us to simplify the PVF
      pre-checking logic: if this PR is deployed before the following changes
      for PVF prechecking then we can be sure that no paras onboarding have to
      have to go through the PVF pre-checking. In case, we deploy it
      altogether this property will allow us to distingush paras that came in
      before PVF pre-checking.
      
      For `schedule_para_cleanup` we do not want to allow offboarding of paras
      that are undergoing the upgrade process. While this is not a harsh
      restriction this change allows us to avoid making the PVF prechecking
      more complicated than it has to be.
      
      * Add a test for schedule_para_initialize
      
      * Link to `ParaLifecycle::is_stable` in docs.
      
      * `schedule_para_{init,cleanup}` docs
      
      Now they link to their original declarations in the pallet for more
      details.
      62915a68
    • Keith Yeung's avatar
      Update W3F URL links (#4376) · e90ee611
      Keith Yeung authored
      e90ee611
  2. 25 Nov, 2021 1 commit
  3. 24 Nov, 2021 2 commits
    • asynchronous rob's avatar
      add disputes to Kusama runtime (#4356) · f6b62504
      asynchronous rob authored
      
      
      * add disputes to Kusama runtime
      
      * Update DisputesHandler
      
      * fmt
      
      * add the benchmarks
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_disputes.rs
      Co-authored-by: Shawn Tabrizi's avatarShawn Tabrizi <shawntabrizi@gmail.com>
      Co-authored-by: default avatarParity Bot <admin@parity.io>
      f6b62504
    • Bernhard Schuster's avatar
      add additional assurances to `create_inherent` (#4349) · 0609dc74
      Bernhard Schuster authored
      
      
      * minor: move checks into separate fn
      
      * add additional validity checks
      
      * simplify shuffling
      
      * Closes potential OOB weight
      
      * improve docs
      
      * fooo
      
      * remove obsolete comment
      
      * move filtering into the rollback-transaction
      
      Technically this is not necessary but avoids future footguns.
      
      * move check up and avoid duplicate checks
      
      * refactor: make sure backed candidates are sane, even more
      
      * doc wording
      Co-authored-by: default avatarZeke Mostov <z.mostov@gmail.com>
      
      * refactor: avoid const generics for sake of wasm size
      
      `true` -> `FullCheck::Skip`, `false` -> `FullCheck::Yes`.
      
      * chore: unify `CandidateCheckContext` instance names
      
      * refactor: introduce `IndexedRetain` for `Vec<T>`
      
      * chore: make tests prefix free
      
      * doc: re-introduce removed comment
      
      * refactor: remove another const generic to save some wasm size
      Co-authored-by: default avatarZeke Mostov <z.mostov@gmail.com>
      0609dc74
  4. 23 Nov, 2021 1 commit
    • Zeke Mostov's avatar
      Inherent filtering follow up (#4305) · 89529740
      Zeke Mostov authored
      
      
      * Add feature more feature gating for benchmarking + tests
      
      * New line
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras_inherent.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras_inherent.rs
      
      * Do not assume we use max validators per core
      
      * Use kusama weights for rococo (hopefully temp)
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras_inherent.rs
      
      * Add more validity votes when neccesary
      
      * Some fixes for the last commit
      
      * Restore westend weights
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras_inherent.rs
      
      * Revert bad westend weights write
      
      * Make sure to update val idx before skipping
      
      * Fix validity vote range to max at group size'
      
      * Temp setup for rococo
      
      * cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras_inherent.rs --header=./file_header.txt
      
      * Augment generated Rococo weights
      
      * Make it compile
      
      * Revert range for enter_backed_candidates_variable
      
      * Delete runtime/kusama/src/weights/runtime_paras_paras_inherent.rs
      Co-authored-by: default avatarParity Bot <admin@parity.io>
      89529740
  5. 22 Nov, 2021 1 commit
  6. 19 Nov, 2021 3 commits
  7. 18 Nov, 2021 3 commits
  8. 17 Nov, 2021 2 commits
  9. 16 Nov, 2021 2 commits
    • Bernhard Schuster's avatar
      move paras inherent filtering to runtime (#4028) · c198d26d
      Bernhard Schuster authored
      
      
      * move things around, add filter methods
      
      * validator keys, modify availability bitfields according to disputes
      
      * simplify, keep the filter -> sanitize generic for both usecases
      
      * minor
      
      * assure tests still work, reduce changeset
      
      * integration
      
      * start entropy passing
      
      * fixins
      
      * compile, 1 failing test
      
      * filter with coverage
      
      * fixins
      
      * Update runtime/parachains/src/paras_inherent.rs
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      
      * slip of the pen
      
      * improve test cases
      
      * misc
      
      * fix
      
      * fixins
      
      * test avoid extra into() calls in assert_noop!
      
      * chores
      
      * ff
      
      * test fixup superfluous into call
      
      * chore: pfmt
      
      * improve apply_block_weight_limit to try to maximize the number of sufficiently backed
      
      blocks and add extra bitfields in a round-robin fashion
      
      * new code treats the lack of backed candidates as ok
      
      * Use vrf based entropy
      
      * fixup vrf random
      
      * add warn
      
      * slip of the pen
      
      * fixup
      
      * assure ordering
      
      * rethink apply_weights
      
      * mock
      
      * use a closure as predicate check
      
      * extract and use DisputedBitfield
      
      * chore: simplify
      
      * remove stray dbg
      
      * chore: fmt
      
      * address feedback
      
      * fix test, halfway there
      
      * stage1
      
      * dbg stuff
      
      * make group selection align
      
      * fix session index
      
      * fix wrongly returned candidates
      
      * cleanup
      
      * chore fmt
      
      * fix ensure check
      
      * make good case test work
      
      * more tests for bitfields
      
      * create sanitize_backed_candidates
      
      * fixup tests
      
      * update guide
      
      * add check referenced in the guide
      
      * improve weights code
      
      * fmt
      
      * fixins
      
      * Update roadmap/implementers-guide/src/runtime/inclusion.md
      Co-authored-by: default avatarZeke Mostov <32168567+emostov@users.noreply.github.com>
      
      * compiling + address review
      
      * add comments
      
      * fix weight calc
      
      * address review comments and test failure
      
      * fix
      
      * fix: condition
      
      * Fix random_sel function
      
      * Fix overlength block check
      
      * Zeke + Ladi commit for disputes filtering + integration test builder + runtime benchmarks + integration tests
      
      * Add benchmarks for code upgrades
      
      * Code upgrade bench; Feature gate TestWeightInfo
      
      * Try and make CI happier
      
      * Feature gate enter test to not(benchmarks)
      
      * Make sure no unused imports/fn
      
      * refactor, re-use, the beginning
      
      * Fix issue with frame benchmarking dep compilation
      
      * More precise feature gating for some derives
      
      * integrate piece-wise
      
      * foo
      
      * fixins
      
      * chore fmt
      
      * fixins
      
      * rename const generic
      
      * Update runtime/parachains/src/paras_inherent.rs
      Co-authored-by: default avatarZeke Mostov <z.mostov@gmail.com>
      
      * Fix compilation
      
      * limit to test
      
      * remove unused spam slots
      
      * spellcheck
      
      * remove a tick, fix a typo
      
      * Add Code upgrade weights
      
      * comment improvements + >=
      Co-authored-by: default avatarZeke Mostov <z.mostov@gmail.com>
      
      * remove another tick
      
      * Update runtime/parachains/src/paras_inherent/benchmarking.rs
      Co-authored-by: default avatarZeke Mostov <z.mostov@gmail.com>
      
      * saturating fixins + some spaces
      
      * fix
      
      * benchmarking - preliminary results
      
      * Add training wheels
      
      * Refactor some early exit logic for enter
      
      * Gracefully handle filtering bitfields & candidates (#4280)
      
      This updates the logic for sanitize_bitfields and sanitize_backed_candidates to never error when there is an issue, but instead to simply skip the problematic items.
      
      * Refactor inherent data weight limiting logic (#4287)
      
      * Apply suggestions from code review
      
      * Update runtime/parachains/src/builder.rs
      Co-authored-by: default avatarZeke Mostov <z.mostov@gmail.com>
      
      * Update runtime/parachains/src/builder.rs
      
      * Update runtime/parachains/src/paras_inherent.rs
      
      * final pass
      
      * Run cargo +nightly-2021-10-29 fmt
      
      * Update implementors guide with `sanitize_*` & `enter` (#4294)
      
      * Make spell check happier
      
      * Make wasm runtimes compile with benchmarks enabled (#4303)
      
      * comment stuff out, use old toml
      
      * Seems to be working?
      
      * Remove feature gating from builder
      
      * Remove commented out stuff
      
      * Remove generic from digest
      
      * Update weight files for runtime
      Co-authored-by: asynchronous rob's avatarRobert Habermeier <rphmeier@gmail.com>
      Co-authored-by: default avatarZeke Mostov <32168567+emostov@users.noreply.github.com>
      Co-authored-by: Lldenaurois's avatarLldenaurois <Ljdenaurois@gmail.com>
      Co-authored-by: default avatarZeke Mostov <z.mostov@gmail.com>
      Co-authored-by: default avatarBastian Köcher <info@kchr.de>
      c198d26d
    • dependabot[bot]'s avatar
      Bump serde_json from 1.0.69 to 1.0.70 (#4284) · f0160fb0
      dependabot[bot] authored
      Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.69 to 1.0.70.
      - [Release notes](https://github.com/serde-rs/json/releases)
      - [Commits](https://github.com/serde-rs/json/compare/v1.0.69...v1.0.70
      
      )
      
      ---
      updated-dependencies:
      - dependency-name: serde_json
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      f0160fb0
  10. 15 Nov, 2021 1 commit
  11. 13 Nov, 2021 1 commit
  12. 12 Nov, 2021 2 commits
  13. 09 Nov, 2021 1 commit
  14. 04 Nov, 2021 1 commit
  15. 31 Oct, 2021 1 commit
  16. 30 Oct, 2021 1 commit
  17. 29 Oct, 2021 1 commit
    • Bastian Köcher's avatar
      Introduce `OriginPrivilegeCmp` (#4166) · d3a9b5be
      Bastian Köcher authored
      * Introduce `OriginPrivilegeCmp`
      
      Make use of the new `OriginPrivilegeCmp` feature of pallet scheduler.
      The idea is to make sure that a council origin with more yes votes has
      higher privileges than a council origin with less yes votes. This solves
      a problem that happened recently on Kusama where the council tried to
      cancel a scheduled task, but that required that the same council origin
      was used while the cancel motion had more yes votes than the origin
      motion that scheduled this task. With this origin privilege compare it
      should now be solved by checking the yes votes directly.
      
      * Feedback
      
      * update lockfile for substrate
      
      Co-authored-by: parity-processbot <>
      d3a9b5be
  18. 28 Oct, 2021 1 commit
  19. 27 Oct, 2021 2 commits
    • Shawn Tabrizi's avatar
      Fix XCM Teleport Benchmark (#4146) · 9eb990d4
      Shawn Tabrizi authored
      
      
      * fix xcm benchmark
      
      * fix overflow
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs
      
      * fix spelling
      
      * fmt
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs
      Co-authored-by: default avatarParity Bot <admin@parity.io>
      9eb990d4
    • Gavin Wood's avatar
      Allow Queries and Subscriptions (#4150) · 9d2ef45e
      Gavin Wood authored
      * Allow Queries and Subscriptions
      
      * Formatting
      
      * Formatting
      9d2ef45e
  20. 25 Oct, 2021 2 commits
  21. 22 Oct, 2021 2 commits
  22. 21 Oct, 2021 1 commit
  23. 20 Oct, 2021 1 commit
  24. 18 Oct, 2021 2 commits
  25. 16 Oct, 2021 1 commit
  26. 15 Oct, 2021 2 commits